1 files changed, 22 insertions, 61 deletions

diff --git a/apps/workflowengine/lib/Settings/ASettings.php b/apps/workflowengine/lib/Settings/ASettings.php
index 4d0d4312f16..23e958755de 100644
--- a/apps/workflowengine/lib/Settings/ASettings.php
+++ b/apps/workflowengine/lib/Settings/ASettings.php
@@ -1,37 +1,21 @@
 <?php
 
 declare(strict_types=1);
+
 /**
- * @copyright Copyright (c) 2019 Arthur Schiwon <blizzz@arthur-schiwon.de>
- *
- * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
- *
- * @license GNU AGPL version 3 or any later version
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
+ * SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
  */
-
 namespace OCA\WorkflowEngine\Settings;
 
 use OCA\WorkflowEngine\AppInfo\Application;
 use OCA\WorkflowEngine\Manager;
 use OCP\AppFramework\Http\TemplateResponse;
+use OCP\AppFramework\Services\IInitialState;
 use OCP\EventDispatcher\IEventDispatcher;
 use OCP\IConfig;
-use OCP\IInitialStateService;
 use OCP\IL10N;
+use OCP\IURLGenerator;
 use OCP\Settings\ISettings;
 use OCP\WorkflowEngine\Events\LoadSettingsScriptsEvent;
 use OCP\WorkflowEngine\ICheck;
@@ -42,38 +26,15 @@ use OCP\WorkflowEngine\IOperation;
 use OCP\WorkflowEngine\ISpecificOperation;
 
 abstract class ASettings implements ISettings {
-	/** @var IL10N */
-	private $l10n;
-
-	/** @var string */
-	private $appName;
-
-	/** @var IEventDispatcher */
-	private $eventDispatcher;
-
-	/** @var Manager */
-	protected $manager;
-
-	/** @var IInitialStateService */
-	private $initialStateService;
-
-	/** @var IConfig */
-	private $config;
-
 	public function __construct(
-		string $appName,
-		IL10N $l,
-		IEventDispatcher $eventDispatcher,
-		Manager $manager,
-		IInitialStateService $initialStateService,
-		IConfig $config
+		private string $appName,
+		private IL10N $l10n,
+		private IEventDispatcher $eventDispatcher,
+		protected Manager $manager,
+		private IInitialState $initialStateService,
+		private IConfig $config,
+		private IURLGenerator $urlGenerator,
 	) {
-		$this->appName = $appName;
-		$this->l10n = $l;
-		$this->eventDispatcher = $eventDispatcher;
-		$this->manager = $manager;
-		$this->initialStateService = $initialStateService;
-		$this->config = $config;
 	}
 
 	abstract public function getScope(): int;
@@ -81,7 +42,7 @@ abstract class ASettings implements ISettings {
 	/**
 	 * @return TemplateResponse
 	 */
-	public function getForm() {
+	public function getForm(): TemplateResponse {
 		// @deprecated in 20.0.0: retire this one in favor of the typed event
 		$this->eventDispatcher->dispatch(
 			'OCP\WorkflowEngine::loadAdditionalSettingScripts',
@@ -91,55 +52,55 @@ abstract class ASettings implements ISettings {
 
 		$entities = $this->manager->getEntitiesList();
 		$this->initialStateService->provideInitialState(
-			Application::APP_ID,
 			'entities',
 			$this->entitiesToArray($entities)
 		);
 
 		$operators = $this->manager->getOperatorList();
 		$this->initialStateService->provideInitialState(
-			Application::APP_ID,
 			'operators',
 			$this->operatorsToArray($operators)
 		);
 
 		$checks = $this->manager->getCheckList();
 		$this->initialStateService->provideInitialState(
-			Application::APP_ID,
 			'checks',
 			$this->checksToArray($checks)
 		);
 
 		$this->initialStateService->provideInitialState(
-			Application::APP_ID,
 			'scope',
 			$this->getScope()
 		);
 
 		$this->initialStateService->provideInitialState(
-			Application::APP_ID,
 			'appstoreenabled',
 			$this->config->getSystemValueBool('appstoreenabled', true)
 		);
 
+		$this->initialStateService->provideInitialState(
+			'doc-url',
+			$this->urlGenerator->linkToDocs('admin-workflowengine')
+		);
+
 		return new TemplateResponse(Application::APP_ID, 'settings', [], 'blank');
 	}
 
 	/**
 	 * @return string the section ID, e.g. 'sharing'
 	 */
-	public function getSection() {
+	public function getSection(): ?string {
 		return 'workflow';
 	}
 
 	/**
 	 * @return int whether the form should be rather on the top or bottom of
-	 * the admin section. The forms are arranged in ascending order of the
-	 * priority values. It is required to return a value between 0 and 100.
+	 *             the admin section. The forms are arranged in ascending order of the
+	 *             priority values. It is required to return a value between 0 and 100.
 	 *
 	 * E.g.: 70
 	 */
-	public function getPriority() {
+	public function getPriority(): int {
 		return 0;
 	}