diff options
Diffstat (limited to 'cypress/e2e/files_versions')
-rw-r--r-- | cypress/e2e/files_versions/filesVersionsUtils.ts | 90 | ||||
-rw-r--r-- | cypress/e2e/files_versions/version_creation.cy.ts | 47 | ||||
-rw-r--r-- | cypress/e2e/files_versions/version_cross_share_move_and_copy.cy.ts | 102 | ||||
-rw-r--r-- | cypress/e2e/files_versions/version_deletion.cy.ts | 98 | ||||
-rw-r--r-- | cypress/e2e/files_versions/version_download.cy.ts | 94 | ||||
-rw-r--r-- | cypress/e2e/files_versions/version_expiration.cy.ts | 56 | ||||
-rw-r--r-- | cypress/e2e/files_versions/version_naming.cy.ts | 133 | ||||
-rw-r--r-- | cypress/e2e/files_versions/version_restoration.cy.ts | 116 | ||||
-rw-r--r-- | cypress/e2e/files_versions/version_sharing.cy.ts | 46 |
9 files changed, 782 insertions, 0 deletions
diff --git a/cypress/e2e/files_versions/filesVersionsUtils.ts b/cypress/e2e/files_versions/filesVersionsUtils.ts new file mode 100644 index 00000000000..75c76b7e97c --- /dev/null +++ b/cypress/e2e/files_versions/filesVersionsUtils.ts @@ -0,0 +1,90 @@ +/** + * SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors + * SPDX-License-Identifier: AGPL-3.0-or-later + */ +/* eslint-disable jsdoc/require-jsdoc */ +import type { User } from '@nextcloud/cypress' +import { createShare, type ShareSetting } from '../files_sharing/FilesSharingUtils' + +export const uploadThreeVersions = (user: User, fileName: string) => { + // A new version will not be created if the changes occur + // within less than one second of each other. + // eslint-disable-next-line cypress/no-unnecessary-waiting + cy.uploadContent(user, new Blob(['v1'], { type: 'text/plain' }), 'text/plain', `/${fileName}`) + .wait(1100) + .uploadContent(user, new Blob(['v2'], { type: 'text/plain' }), 'text/plain', `/${fileName}`) + .wait(1100) + .uploadContent(user, new Blob(['v3'], { type: 'text/plain' }), 'text/plain', `/${fileName}`) + cy.login(user) +} + +export function openVersionsPanel(fileName: string) { + // Detect the versions list fetch + cy.intercept('PROPFIND', '**/dav/versions/*/versions/**').as('getVersions') + + // Open the versions tab + cy.window().then(win => { + win.OCA.Files.Sidebar.setActiveTab('version_vue') + win.OCA.Files.Sidebar.open(`/${fileName}`) + }) + + // Wait for the versions list to be fetched + cy.wait('@getVersions') + cy.get('#tab-version_vue').should('be.visible', { timeout: 10000 }) +} + +export function toggleVersionMenu(index: number) { + cy.get('#tab-version_vue [data-files-versions-version]') + .eq(index) + .find('button') + .click() +} + +export function triggerVersionAction(index: number, actionName: string) { + toggleVersionMenu(index) + cy.get(`[data-cy-files-versions-version-action="${actionName}"]`).filter(':visible').click() +} + +export function nameVersion(index: number, name: string) { + cy.intercept('PROPPATCH', '**/dav/versions/*/versions/**').as('labelVersion') + triggerVersionAction(index, 'label') + cy.get(':focused').type(`${name}{enter}`) + cy.wait('@labelVersion') +} + +export function restoreVersion(index: number) { + cy.intercept('MOVE', '**/dav/versions/*/versions/**').as('restoreVersion') + triggerVersionAction(index, 'restore') + cy.wait('@restoreVersion') +} + +export function deleteVersion(index: number) { + cy.intercept('DELETE', '**/dav/versions/*/versions/**').as('deleteVersion') + triggerVersionAction(index, 'delete') + cy.wait('@deleteVersion') +} + +export function doesNotHaveAction(index: number, actionName: string) { + toggleVersionMenu(index) + cy.get(`[data-cy-files-versions-version-action="${actionName}"]`).should('not.exist') + toggleVersionMenu(index) +} + +export function assertVersionContent(index: number, expectedContent: string) { + cy.intercept({ method: 'GET', times: 1, url: 'remote.php/**' }).as('downloadVersion') + triggerVersionAction(index, 'download') + cy.wait('@downloadVersion') + .then(({ response }) => expect(response?.body).to.equal(expectedContent)) +} + +export function setupTestSharedFileFromUser(owner: User, randomFileName: string, shareOptions: Partial<ShareSetting>) { + return cy.createRandomUser() + .then((recipient) => { + cy.login(owner) + cy.visit('/apps/files') + createShare(randomFileName, recipient.userId, shareOptions) + cy.login(recipient) + cy.visit('/apps/files') + return cy.wrap(recipient) + }) +} diff --git a/cypress/e2e/files_versions/version_creation.cy.ts b/cypress/e2e/files_versions/version_creation.cy.ts new file mode 100644 index 00000000000..a0441e96b29 --- /dev/null +++ b/cypress/e2e/files_versions/version_creation.cy.ts @@ -0,0 +1,47 @@ +/** + * SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors + * SPDX-License-Identifier: AGPL-3.0-or-later + */ + +import { openVersionsPanel, uploadThreeVersions } from './filesVersionsUtils' + +describe('Versions creation', () => { + let randomFileName = '' + + before(() => { + randomFileName = Math.random().toString(36).replace(/[^a-z]+/g, '').substring(0, 10) + '.txt' + + cy.createRandomUser() + .then((user) => { + uploadThreeVersions(user, randomFileName) + cy.login(user) + cy.visit('/apps/files') + openVersionsPanel(randomFileName) + }) + }) + + it('Opens the versions panel and sees the versions', () => { + cy.visit('/apps/files') + openVersionsPanel(randomFileName) + + cy.get('#tab-version_vue').within(() => { + cy.get('[data-files-versions-version]').should('have.length', 3) + cy.get('[data-files-versions-version]').eq(0).contains('Current version') + cy.get('[data-files-versions-version]').eq(2).contains('Initial version') + }) + }) + + it('See yourself as version author', () => { + cy.visit('/apps/files') + openVersionsPanel(randomFileName) + + cy.findByRole('tabpanel', { name: 'Versions' }) + .findByRole('list', { name: 'File versions' }) + .findAllByRole('listitem') + .should('have.length', 3) + .first() + .find('[data-cy-files-version-author-name]') + .should('exist') + .and('contain.text', 'You') + }) +}) diff --git a/cypress/e2e/files_versions/version_cross_share_move_and_copy.cy.ts b/cypress/e2e/files_versions/version_cross_share_move_and_copy.cy.ts new file mode 100644 index 00000000000..8c673b13d4c --- /dev/null +++ b/cypress/e2e/files_versions/version_cross_share_move_and_copy.cy.ts @@ -0,0 +1,102 @@ +/** + * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors + * SPDX-License-Identifier: AGPL-3.0-or-later + */ + +import { assertVersionContent, openVersionsPanel, setupTestSharedFileFromUser, uploadThreeVersions, nameVersion } from './filesVersionsUtils' +import { clickOnBreadcrumbs, closeSidebar, copyFile, moveFile, navigateToFolder } from '../files/FilesUtils' +import type { User } from '@nextcloud/cypress' + +/** + * + * @param filePath + */ +function assertVersionsContent(filePath: string) { + const path = filePath.split('/').slice(0, -1).join('/') + + clickOnBreadcrumbs('All files') + + if (path !== '') { + navigateToFolder(path) + } + + openVersionsPanel(filePath) + + cy.get('[data-files-versions-version]').should('have.length', 3) + assertVersionContent(0, 'v3') + assertVersionContent(1, 'v2') + assertVersionContent(2, 'v1') +} + +describe('Versions cross share move and copy', () => { + let randomSharedFolderName = '' + let randomFileName = '' + let randomFilePath = '' + let alice: User + let bob: User + + before(() => { + randomSharedFolderName = Math.random().toString(36).replace(/[^a-z]+/g, '').substring(0, 10) + + cy.createRandomUser() + .then((user) => { + alice = user + cy.mkdir(alice, `/${randomSharedFolderName}`) + setupTestSharedFileFromUser(alice, randomSharedFolderName, {}) + }) + .then((user) => { bob = user }) + }) + + beforeEach(() => { + randomFileName = Math.random().toString(36).replace(/[^a-z]+/g, '').substring(0, 10) + '.txt' + randomFilePath = `${randomSharedFolderName}/${randomFileName}` + uploadThreeVersions(alice, randomFilePath) + + cy.login(bob) + cy.visit('/apps/files') + navigateToFolder(randomSharedFolderName) + openVersionsPanel(randomFilePath) + nameVersion(2, 'v1') + closeSidebar() + }) + + it('Also moves versions when bob moves the file out of a received share', () => { + moveFile(randomFileName, '/') + assertVersionsContent(randomFileName) + // TODO: move that in assertVersionsContent when copying files keeps the versions' metadata + cy.get('[data-files-versions-version]').eq(2).contains('v1') + }) + + it('Also copies versions when bob copies the file out of a received share', () => { + copyFile(randomFileName, '/') + assertVersionsContent(randomFileName) + }) + + context('When a file is in a subfolder', () => { + let randomSubFolderName + let randomSubSubFolderName + + beforeEach(() => { + randomSubFolderName = Math.random().toString(36).replace(/[^a-z]+/g, '').substring(0, 10) + randomSubSubFolderName = Math.random().toString(36).replace(/[^a-z]+/g, '').substring(0, 10) + clickOnBreadcrumbs('All files') + cy.mkdir(bob, `/${randomSharedFolderName}/${randomSubFolderName}`) + cy.mkdir(bob, `/${randomSharedFolderName}/${randomSubFolderName}/${randomSubSubFolderName}`) + cy.login(bob) + navigateToFolder(randomSharedFolderName) + moveFile(randomFileName, `${randomSubFolderName}/${randomSubSubFolderName}`) + }) + + it('Also moves versions when bob moves the containing folder out of a received share', () => { + moveFile(randomSubFolderName, '/') + assertVersionsContent(`${randomSubFolderName}/${randomSubSubFolderName}/${randomFileName}`) + // TODO: move that in assertVersionsContent when copying files keeps the versions' metadata + cy.get('[data-files-versions-version]').eq(2).contains('v1') + }) + + it('Also copies versions when bob copies the containing folder out of a received share', () => { + copyFile(randomSubFolderName, '/') + assertVersionsContent(`${randomSubFolderName}/${randomSubSubFolderName}/${randomFileName}`) + }) + }) +}) diff --git a/cypress/e2e/files_versions/version_deletion.cy.ts b/cypress/e2e/files_versions/version_deletion.cy.ts new file mode 100644 index 00000000000..b49aa872639 --- /dev/null +++ b/cypress/e2e/files_versions/version_deletion.cy.ts @@ -0,0 +1,98 @@ +/** + * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors + * SPDX-License-Identifier: AGPL-3.0-or-later + */ + +import type { User } from '@nextcloud/cypress' +import { doesNotHaveAction, openVersionsPanel, setupTestSharedFileFromUser, uploadThreeVersions, deleteVersion } from './filesVersionsUtils' +import { navigateToFolder, getRowForFile } from '../files/FilesUtils' + +describe('Versions restoration', () => { + const folderName = 'shared_folder' + const randomFileName = Math.random().toString(36).replace(/[^a-z]+/g, '').substring(0, 10) + '.txt' + const randomFilePath = `/${folderName}/${randomFileName}` + let user: User + let versionCount = 0 + + before(() => { + cy.createRandomUser() + .then((_user) => { + user = _user + cy.mkdir(user, `/${folderName}`) + uploadThreeVersions(user, randomFilePath) + uploadThreeVersions(user, randomFilePath) + versionCount = 6 + cy.login(user) + cy.visit('/apps/files') + navigateToFolder(folderName) + openVersionsPanel(randomFilePath) + }) + }) + + it('Delete initial version', () => { + cy.get('[data-files-versions-version]').should('have.length', versionCount) + deleteVersion(2) + versionCount-- + cy.get('[data-files-versions-version]').should('have.length', versionCount) + }) + + context('Delete versions of shared file', () => { + it('Works with delete permission', () => { + setupTestSharedFileFromUser(user, folderName, { delete: true }) + navigateToFolder(folderName) + openVersionsPanel(randomFilePath) + + cy.get('[data-files-versions-version]').should('have.length', versionCount) + deleteVersion(2) + versionCount-- + cy.get('[data-files-versions-version]').should('have.length', versionCount) + }) + + it('Does not work without delete permission', () => { + setupTestSharedFileFromUser(user, folderName, { delete: false }) + navigateToFolder(folderName) + openVersionsPanel(randomFilePath) + + doesNotHaveAction(0, 'delete') + doesNotHaveAction(1, 'delete') + doesNotHaveAction(2, 'delete') + }) + + it('Does not work without delete permission through direct API access', () => { + let fileId: string|undefined + let versionId: string|undefined + + setupTestSharedFileFromUser(user, folderName, { delete: false }) + .then(recipient => { + navigateToFolder(folderName) + openVersionsPanel(randomFilePath) + + getRowForFile(randomFileName) + .should('be.visible') + .invoke('attr', 'data-cy-files-list-row-fileid') + .then(($fileId) => { fileId = $fileId }) + + cy.get('[data-files-versions-version]') + .eq(1) + .invoke('attr', 'data-files-versions-version') + .then(($versionId) => { versionId = $versionId }) + + cy.logout() + cy.then(() => { + const base = Cypress.config('baseUrl')!.replace(/\/index\.php\/?$/, '') + return cy.request({ + method: 'DELETE', + url: `${base}/remote.php/dav/versions/${recipient.userId}/versions/${fileId}/${versionId}`, + auth: { user: recipient.userId, pass: recipient.password }, + headers: { + cookie: '', + }, + failOnStatusCode: false, + }) + }).then(({ status }) => { + expect(status).to.equal(403) + }) + }) + }) + }) +}) diff --git a/cypress/e2e/files_versions/version_download.cy.ts b/cypress/e2e/files_versions/version_download.cy.ts new file mode 100644 index 00000000000..548cb86a207 --- /dev/null +++ b/cypress/e2e/files_versions/version_download.cy.ts @@ -0,0 +1,94 @@ +/** + * SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors + * SPDX-License-Identifier: AGPL-3.0-or-later + */ + +import { assertVersionContent, doesNotHaveAction, openVersionsPanel, setupTestSharedFileFromUser, uploadThreeVersions } from './filesVersionsUtils' +import type { User } from '@nextcloud/cypress' +import { getRowForFile } from '../files/FilesUtils' + +describe('Versions download', () => { + let randomFileName = '' + let user: User + + before(() => { + randomFileName = Math.random().toString(36).replace(/[^a-z]+/g, '').substring(0, 10) + '.txt' + + cy.runOccCommand('config:app:set --value no core shareapi_allow_view_without_download') + cy.createRandomUser() + .then((_user) => { + user = _user + uploadThreeVersions(user, randomFileName) + cy.login(user) + cy.visit('/apps/files') + openVersionsPanel(randomFileName) + }) + }) + + after(() => { + cy.runOccCommand('config:app:delete core shareapi_allow_view_without_download') + }) + + it('Download versions and assert their content', () => { + assertVersionContent(0, 'v3') + assertVersionContent(1, 'v2') + assertVersionContent(2, 'v1') + }) + + context('Download versions of shared file', () => { + it('Works with download permission', () => { + setupTestSharedFileFromUser(user, randomFileName, { download: true }) + openVersionsPanel(randomFileName) + + assertVersionContent(0, 'v3') + assertVersionContent(1, 'v2') + assertVersionContent(2, 'v1') + }) + + it('Does not show action without download permission', () => { + setupTestSharedFileFromUser(user, randomFileName, { download: false }) + openVersionsPanel(randomFileName) + + cy.get('[data-files-versions-version]').eq(0).find('.action-item__menutoggle').should('not.exist') + cy.get('[data-files-versions-version]').eq(0).get('[data-cy-version-action="download"]').should('not.exist') + + doesNotHaveAction(1, 'download') + doesNotHaveAction(2, 'download') + }) + + it('Does not work without download permission through direct API access', () => { + let fileId: string|undefined + let versionId: string|undefined + + setupTestSharedFileFromUser(user, randomFileName, { download: false }) + .then((recipient) => { + openVersionsPanel(randomFileName) + + getRowForFile(randomFileName) + .should('be.visible') + .invoke('attr', 'data-cy-files-list-row-fileid') + .then(($fileId) => { fileId = $fileId }) + + cy.get('[data-files-versions-version]') + .eq(1) + .invoke('attr', 'data-files-versions-version') + .then(($versionId) => { versionId = $versionId }) + + cy.logout() + cy.then(() => { + const base = Cypress.config('baseUrl')!.replace(/\/index\.php\/?$/, '') + return cy.request({ + url: `${base}/remote.php/dav/versions/${recipient.userId}/versions/${fileId}/${versionId}`, + auth: { user: recipient.userId, pass: recipient.password }, + headers: { + cookie: '', + }, + failOnStatusCode: false, + }) + }).then(({ status }) => { + expect(status).to.equal(403) + }) + }) + }) + }) +}) diff --git a/cypress/e2e/files_versions/version_expiration.cy.ts b/cypress/e2e/files_versions/version_expiration.cy.ts new file mode 100644 index 00000000000..118ac01532f --- /dev/null +++ b/cypress/e2e/files_versions/version_expiration.cy.ts @@ -0,0 +1,56 @@ +/** + * SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors + * SPDX-License-Identifier: AGPL-3.0-or-later + */ + +import { assertVersionContent, nameVersion, openVersionsPanel, uploadThreeVersions } from './filesVersionsUtils' + +describe('Versions expiration', () => { + let randomFileName = '' + + beforeEach(() => { + randomFileName = Math.random().toString(36).replace(/[^a-z]+/g, '').substring(0, 10) + '.txt' + + cy.createRandomUser() + .then((user) => { + uploadThreeVersions(user, randomFileName) + cy.login(user) + cy.visit('/apps/files') + openVersionsPanel(randomFileName) + }) + }) + + it('Expire all versions', () => { + cy.runOccCommand('config:system:set versions_retention_obligation --value \'0, 0\'') + cy.runOccCommand('versions:expire') + cy.runOccCommand('config:system:set versions_retention_obligation --value auto') + cy.visit('/apps/files') + openVersionsPanel(randomFileName) + + cy.get('#tab-version_vue').within(() => { + cy.get('[data-files-versions-version]').should('have.length', 1) + cy.get('[data-files-versions-version]').eq(0).contains('Current version') + }) + + assertVersionContent(0, 'v3') + }) + + it('Expire versions v2', () => { + nameVersion(2, 'v1') + + cy.runOccCommand('config:system:set versions_retention_obligation --value \'0, 0\'') + cy.runOccCommand('versions:expire') + cy.runOccCommand('config:system:set versions_retention_obligation --value auto') + cy.visit('/apps/files') + openVersionsPanel(randomFileName) + + cy.get('#tab-version_vue').within(() => { + cy.get('[data-files-versions-version]').should('have.length', 2) + cy.get('[data-files-versions-version]').eq(0).contains('Current version') + cy.get('[data-files-versions-version]').eq(1).contains('v1') + }) + + assertVersionContent(0, 'v3') + assertVersionContent(1, 'v1') + }) +}) diff --git a/cypress/e2e/files_versions/version_naming.cy.ts b/cypress/e2e/files_versions/version_naming.cy.ts new file mode 100644 index 00000000000..ff299c53227 --- /dev/null +++ b/cypress/e2e/files_versions/version_naming.cy.ts @@ -0,0 +1,133 @@ +/** + * SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors + * SPDX-License-Identifier: AGPL-3.0-or-later + */ + +import type { User } from '@nextcloud/cypress' +import { nameVersion, openVersionsPanel, uploadThreeVersions, doesNotHaveAction, setupTestSharedFileFromUser } from './filesVersionsUtils' +import { getRowForFile } from '../files/FilesUtils' + +describe('Versions naming', () => { + let randomFileName = '' + let user: User + + before(() => { + randomFileName = Math.random().toString(36).replace(/[^a-z]+/g, '').substring(0, 10) + '.txt' + + cy.createRandomUser() + .then((_user) => { + user = _user + uploadThreeVersions(user, randomFileName) + cy.login(user) + cy.visit('/apps/files') + openVersionsPanel(randomFileName) + }) + }) + + it('Names the versions', () => { + nameVersion(2, 'v1') + cy.get('#tab-version_vue').within(() => { + cy.get('[data-files-versions-version]').eq(2).contains('v1') + cy.get('[data-files-versions-version]').eq(2).contains('Initial version').should('not.exist') + }) + + nameVersion(1, 'v2') + cy.get('#tab-version_vue').within(() => { + cy.get('[data-files-versions-version]').eq(1).contains('v2') + }) + + nameVersion(0, 'v3') + cy.get('#tab-version_vue').within(() => { + cy.get('[data-files-versions-version]').eq(0).contains('v3 (Current version)') + }) + }) + + context('Name versions of shared file', () => { + context('with edit permission', () => { + before(() => { + setupTestSharedFileFromUser(user, randomFileName, { update: true }) + openVersionsPanel(randomFileName) + }) + + it('Names the versions', () => { + nameVersion(2, 'v1 - shared') + cy.get('#tab-version_vue').within(() => { + cy.get('[data-files-versions-version]').eq(2).contains('v1 - shared') + cy.get('[data-files-versions-version]').eq(2).contains('Initial version').should('not.exist') + }) + + nameVersion(1, 'v2 - shared') + cy.get('#tab-version_vue').within(() => { + cy.get('[data-files-versions-version]').eq(1).contains('v2 - shared') + }) + + nameVersion(0, 'v3 - shared') + cy.get('#tab-version_vue').within(() => { + cy.get('[data-files-versions-version]').eq(0).contains('v3 - shared (Current version)') + }) + }) + }) + + context('without edit permission', () => { + let recipient: User + + beforeEach(() => { + setupTestSharedFileFromUser(user, randomFileName, { update: false }) + .then(($recipient) => { + recipient = $recipient + openVersionsPanel(randomFileName) + }) + }) + + it('Does not show action', () => { + cy.get('[data-files-versions-version]').eq(0).find('.action-item__menutoggle').should('not.exist') + cy.get('[data-files-versions-version]').eq(0).get('[data-cy-version-action="label"]').should('not.exist') + + doesNotHaveAction(1, 'label') + doesNotHaveAction(2, 'label') + }) + + it('Does not work without update permission through direct API access', () => { + let fileId: string|undefined + let versionId: string|undefined + + getRowForFile(randomFileName) + .should('be.visible') + .invoke('attr', 'data-cy-files-list-row-fileid') + .then(($fileId) => { fileId = $fileId }) + + cy.get('[data-files-versions-version]') + .eq(1) + .invoke('attr', 'data-files-versions-version') + .then(($versionId) => { versionId = $versionId }) + + cy.logout() + cy.then(() => { + const base = Cypress.config('baseUrl')!.replace(/index\.php\/?/, '') + return cy.request({ + method: 'PROPPATCH', + url: `${base}/remote.php/dav/versions/${recipient.userId}/versions/${fileId}/${versionId}`, + auth: { user: recipient.userId, pass: recipient.password }, + headers: { + cookie: '', + }, + body: `<?xml version="1.0"?> + <d:propertyupdate xmlns:d="DAV:" + xmlns:oc="http://owncloud.org/ns" + xmlns:nc="http://nextcloud.org/ns" + xmlns:ocs="http://open-collaboration-services.org/ns"> + <d:set> + <d:prop> + <nc:version-label>not authorized labeling</nc:version-label> + </d:prop> + </d:set> + </d:propertyupdate>`, + failOnStatusCode: false, + }) + }).then(({ status }) => { + expect(status).to.equal(403) + }) + }) + }) + }) +}) diff --git a/cypress/e2e/files_versions/version_restoration.cy.ts b/cypress/e2e/files_versions/version_restoration.cy.ts new file mode 100644 index 00000000000..34360808f61 --- /dev/null +++ b/cypress/e2e/files_versions/version_restoration.cy.ts @@ -0,0 +1,116 @@ +/** + * SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors + * SPDX-License-Identifier: AGPL-3.0-or-later + */ + +import type { User } from '@nextcloud/cypress' +import { assertVersionContent, doesNotHaveAction, openVersionsPanel, setupTestSharedFileFromUser, restoreVersion, uploadThreeVersions } from './filesVersionsUtils' +import { getRowForFile } from '../files/FilesUtils' + +describe('Versions restoration', () => { + let randomFileName = '' + let user: User + + before(() => { + randomFileName = Math.random().toString(36).replace(/[^a-z]+/g, '').substring(0, 10) + '.txt' + + cy.createRandomUser() + .then((_user) => { + user = _user + uploadThreeVersions(user, randomFileName) + cy.login(user) + cy.visit('/apps/files') + openVersionsPanel(randomFileName) + }) + }) + + it('Current version does not have restore action', () => { + doesNotHaveAction(0, 'restore') + }) + + it('Restores initial version', () => { + restoreVersion(2) + + cy.get('#tab-version_vue').within(() => { + cy.get('[data-files-versions-version]').should('have.length', 3) + cy.get('[data-files-versions-version]').eq(0).contains('Current version') + cy.get('[data-files-versions-version]').eq(2).contains('Initial version').should('not.exist') + }) + }) + + it('Downloads versions and assert there content', () => { + assertVersionContent(0, 'v1') + assertVersionContent(1, 'v3') + assertVersionContent(2, 'v2') + }) + + context('Restore versions of shared file', () => { + it('Works with update permission', () => { + setupTestSharedFileFromUser(user, randomFileName, { update: true }) + openVersionsPanel(randomFileName) + + it('Restores initial version', () => { + restoreVersion(2) + cy.get('#tab-version_vue').within(() => { + cy.get('[data-files-versions-version]').should('have.length', 3) + cy.get('[data-files-versions-version]').eq(0).contains('Current version') + cy.get('[data-files-versions-version]').eq(2).contains('Initial version').should('not.exist') + }) + }) + + it('Downloads versions and assert there content', () => { + assertVersionContent(0, 'v1') + assertVersionContent(1, 'v3') + assertVersionContent(2, 'v2') + }) + }) + + it('Does not show action without delete permission', () => { + setupTestSharedFileFromUser(user, randomFileName, { update: false }) + openVersionsPanel(randomFileName) + + cy.get('[data-files-versions-version]').eq(0).find('.action-item__menutoggle').should('not.exist') + cy.get('[data-files-versions-version]').eq(0).get('[data-cy-version-action="restore"]').should('not.exist') + + doesNotHaveAction(1, 'restore') + doesNotHaveAction(2, 'restore') + }) + + it('Does not work without update permission through direct API access', () => { + let fileId: string|undefined + let versionId: string|undefined + + setupTestSharedFileFromUser(user, randomFileName, { update: false }) + .then((recipient) => { + openVersionsPanel(randomFileName) + + getRowForFile(randomFileName) + .should('be.visible') + .invoke('attr', 'data-cy-files-list-row-fileid') + .then(($fileId) => { fileId = $fileId }) + + cy.get('[data-files-versions-version]') + .eq(1) + .invoke('attr', 'data-files-versions-version') + .then(($versionId) => { versionId = $versionId }) + + cy.logout() + cy.then(() => { + const base = Cypress.config('baseUrl')!.replace(/\/index\.php\/?$/, '') + return cy.request({ + method: 'MOVE', + url: `${base}/remote.php/dav/versions/${recipient.userId}/versions/${fileId}/${versionId}`, + auth: { user: recipient.userId, pass: recipient.password }, + headers: { + cookie: '', + Destination: `${base}}/remote.php/dav/versions/${recipient.userId}/restore/target`, + }, + failOnStatusCode: false, + }) + }).then(({ status }) => { + expect(status).to.equal(403) + }) + }) + }) + }) +}) diff --git a/cypress/e2e/files_versions/version_sharing.cy.ts b/cypress/e2e/files_versions/version_sharing.cy.ts new file mode 100644 index 00000000000..e978cb42fd9 --- /dev/null +++ b/cypress/e2e/files_versions/version_sharing.cy.ts @@ -0,0 +1,46 @@ +/** + * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors + * SPDX-License-Identifier: AGPL-3.0-or-later + */ +import type { User } from '@nextcloud/cypress' +import { openVersionsPanel, setupTestSharedFileFromUser, uploadThreeVersions } from './filesVersionsUtils.ts' +import { navigateToFolder, triggerActionForFile } from '../files/FilesUtils.ts' + +describe('Versions on shares', () => { + const randomSharedFolderName = Math.random().toString(36).replace(/[^a-z]+/g, '').substring(0, 10) + const randomFileName = Math.random().toString(36).replace(/[^a-z]+/g, '').substring(0, 10) + '.txt' + const randomFilePath = `${randomSharedFolderName}/${randomFileName}` + let alice: User + let bob: User + + before(() => { + cy.createRandomUser() + .then((user) => { + alice = user + }) + .then(() => { + cy.mkdir(alice, `/${randomSharedFolderName}`) + return setupTestSharedFileFromUser(alice, randomSharedFolderName, {}) + }) + .then((user) => { bob = user }) + .then(() => uploadThreeVersions(alice, randomFilePath)) + }) + + it('See sharees display name as author', () => { + cy.login(bob) + cy.visit('/apps/files') + + navigateToFolder(randomSharedFolderName) + + triggerActionForFile(randomFileName, 'details') + cy.findByRole('tab', { name: 'Versions' }).click() + + cy.findByRole('tabpanel', { name: 'Versions' }) + .findByRole('list', { name: 'File versions' }) + .findAllByRole('listitem') + .first() + .find('[data-cy-files-version-author-name]') + .should('be.visible') + .and('contain.text', alice.userId) + }) +}) |