aboutsummaryrefslogtreecommitdiffstats
path: root/lib/private/Template/JSResourceLocator.php
diff options
context:
space:
mode:
Diffstat (limited to 'lib/private/Template/JSResourceLocator.php')
-rw-r--r--lib/private/Template/JSResourceLocator.php118
1 files changed, 40 insertions, 78 deletions
diff --git a/lib/private/Template/JSResourceLocator.php b/lib/private/Template/JSResourceLocator.php
index 68a83fa4b73..a6d2d13a2ad 100644
--- a/lib/private/Template/JSResourceLocator.php
+++ b/lib/private/Template/JSResourceLocator.php
@@ -1,29 +1,9 @@
<?php
+
/**
- * @copyright Copyright (c) 2016, ownCloud, Inc.
- *
- * @author Bart Visscher <bartv@thisnet.nl>
- * @author Christoph Wurst <christoph@winzerhof-wurst.at>
- * @author Joas Schilling <coding@schilljs.com>
- * @author Kyle Fazzari <kyrofa@ubuntu.com>
- * @author Morris Jobke <hey@morrisjobke.de>
- * @author Roeland Jago Douma <roeland@famdouma.nl>
- * @author Thomas Müller <thomas.mueller@tmit.eu>
- *
- * @license AGPL-3.0
- *
- * This code is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License, version 3,
- * as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License, version 3,
- * along with this program. If not, see <http://www.gnu.org/licenses/>
- *
+ * SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-FileCopyrightText: 2016 ownCloud, Inc.
+ * SPDX-License-Identifier: AGPL-3.0-only
*/
namespace OC\Template;
@@ -46,84 +26,66 @@ class JSResourceLocator extends ResourceLocator {
* @param string $script
*/
public function doFind($script) {
- $theme_dir = 'themes/'.$this->theme.'/';
+ $theme_dir = 'themes/' . $this->theme . '/';
// Extracting the appId and the script file name
$app = substr($script, 0, strpos($script, '/'));
$scriptName = basename($script);
+ // Get the app root path
+ $appRoot = $this->serverroot . '/apps/';
+ $appWebRoot = null;
+ try {
+ // We need the dir name as getAppPath appends the appid
+ $appRoot = dirname($this->appManager->getAppPath($app));
+ // Only do this if $app_path is set, because an empty argument to realpath gets turned into cwd.
+ if ($appRoot) {
+ // Handle symlinks
+ $appRoot = realpath($appRoot);
+ }
+ // Get the app webroot
+ $appWebRoot = dirname($this->appManager->getAppWebPath($app));
+ } catch (AppPathNotFoundException $e) {
+ // ignore
+ }
if (str_contains($script, '/l10n/')) {
// For language files we try to load them all, so themes can overwrite
// single l10n strings without having to translate all of them.
$found = 0;
- $found += $this->appendScriptIfExist($this->serverroot, 'core/'.$script);
- $found += $this->appendScriptIfExist($this->serverroot, $theme_dir.'core/'.$script);
+ $found += $this->appendScriptIfExist($this->serverroot, 'core/' . $script);
+ $found += $this->appendScriptIfExist($this->serverroot, $theme_dir . 'core/' . $script);
$found += $this->appendScriptIfExist($this->serverroot, $script);
- $found += $this->appendScriptIfExist($this->serverroot, $theme_dir.$script);
-
- foreach (\OC::$APPSROOTS as $appRoot) {
- $dirName = basename($appRoot['path']);
- $rootPath = dirname($appRoot['path']);
- $found += $this->appendScriptIfExist($rootPath, $dirName.'/'.$script);
- $found += $this->appendScriptIfExist($this->serverroot, $theme_dir.$dirName.'/'.$script);
- }
+ $found += $this->appendScriptIfExist($this->serverroot, $theme_dir . $script);
+ $found += $this->appendScriptIfExist($appRoot, $script, $appWebRoot);
+ $found += $this->appendScriptIfExist($this->serverroot, $theme_dir . 'apps/' . $script);
if ($found) {
return;
}
- } elseif ($this->appendScriptIfExist($this->serverroot, $theme_dir.'apps/'.$script)
- || $this->appendScriptIfExist($this->serverroot, $theme_dir.$script)
+ } elseif ($this->appendScriptIfExist($this->serverroot, $theme_dir . 'apps/' . $script)
+ || $this->appendScriptIfExist($this->serverroot, $theme_dir . $script)
|| $this->appendScriptIfExist($this->serverroot, $script)
- || $this->appendScriptIfExist($this->serverroot, $theme_dir."dist/$app-$scriptName")
+ || $this->appendScriptIfExist($this->serverroot, $theme_dir . "dist/$app-$scriptName")
|| $this->appendScriptIfExist($this->serverroot, "dist/$app-$scriptName")
- || $this->appendScriptIfExist($this->serverroot, 'apps/'.$script)
- || $this->cacheAndAppendCombineJsonIfExist($this->serverroot, $script.'.json')
- || $this->appendScriptIfExist($this->serverroot, $theme_dir.'core/'.$script)
- || $this->appendScriptIfExist($this->serverroot, 'core/'.$script)
- || (strpos($scriptName, '/') === -1 && ($this->appendScriptIfExist($this->serverroot, $theme_dir."dist/core-$scriptName")
+ || $this->appendScriptIfExist($appRoot, $script, $appWebRoot)
+ || $this->cacheAndAppendCombineJsonIfExist($this->serverroot, $script . '.json')
+ || $this->cacheAndAppendCombineJsonIfExist($appRoot, $script . '.json', $app)
+ || $this->appendScriptIfExist($this->serverroot, $theme_dir . 'core/' . $script)
+ || $this->appendScriptIfExist($this->serverroot, 'core/' . $script)
+ || (strpos($scriptName, '/') === -1 && ($this->appendScriptIfExist($this->serverroot, $theme_dir . "dist/core-$scriptName")
|| $this->appendScriptIfExist($this->serverroot, "dist/core-$scriptName")))
- || $this->cacheAndAppendCombineJsonIfExist($this->serverroot, 'core/'.$script.'.json')
+ || $this->cacheAndAppendCombineJsonIfExist($this->serverroot, 'core/' . $script . '.json')
) {
return;
}
- $script = substr($script, strpos($script, '/') + 1);
- $app_url = null;
-
- try {
- $app_url = $this->appManager->getAppWebPath($app);
- } catch (AppPathNotFoundException) {
- // pass
- }
-
- try {
- $app_path = $this->appManager->getAppPath($app);
-
- // Account for the possibility of having symlinks in app path. Only
- // do this if $app_path is set, because an empty argument to realpath
- // gets turned into cwd.
- $app_path = realpath($app_path);
-
- // check combined files
- if (!str_starts_with($script, 'l10n/') && $this->cacheAndAppendCombineJsonIfExist($app_path, $script.'.json', $app)) {
- return;
- }
-
- // fallback to plain file location
- if ($this->appendScriptIfExist($app_path, $script, $app_url)) {
- return;
- }
- } catch (AppPathNotFoundException) {
- // pass (general error handling happens below)
- }
-
// missing translations files will be ignored
- if (str_starts_with($script, 'l10n/')) {
+ if (str_contains($script, '/l10n/')) {
return;
}
$this->logger->error('Could not find resource {resource} to load', [
- 'resource' => $app . '/' . $script . '.js',
+ 'resource' => $script . '.js',
'app' => 'jsresourceloader',
]);
}
@@ -138,7 +100,7 @@ class JSResourceLocator extends ResourceLocator {
* Try to find ES6 script file (`.mjs`) with fallback to plain javascript (`.js`)
* @see appendIfExist()
*/
- protected function appendScriptIfExist(string $root, string $file, string $webRoot = null) {
+ protected function appendScriptIfExist(string $root, string $file, ?string $webRoot = null) {
if (!$this->appendIfExist($root, $file . '.mjs', $webRoot)) {
return $this->appendIfExist($root, $file . '.js', $webRoot);
}
@@ -146,7 +108,7 @@ class JSResourceLocator extends ResourceLocator {
}
protected function cacheAndAppendCombineJsonIfExist($root, $file, $app = 'core') {
- if (is_file($root.'/'.$file)) {
+ if (is_file($root . '/' . $file)) {
if ($this->jsCombiner->process($root, $file, $app)) {
$this->append($this->serverroot, $this->jsCombiner->getCachedJS($app, $file), false, false);
} else {
generated by cgit v1.2.3 (git 2.39.1) at 2025-08-14 21:45:01 +0000