1 files changed, 8 insertions, 11 deletions
diff --git a/tests/lib/AppFramework/Controller/PublicShareControllerTest.php b/tests/lib/AppFramework/Controller/PublicShareControllerTest.php
index f8430d42ef1..97216845617 100644
--- a/tests/lib/AppFramework/Controller/PublicShareControllerTest.php
+++ b/tests/lib/AppFramework/Controller/PublicShareControllerTest.php
@@ -11,17 +11,14 @@ use OCP\IRequest;
 use OCP\ISession;
 
 class TestController extends PublicShareController {
-	/** @var string */
-	private $hash;
-
-	/** @var bool */
-	private $isProtected;
-
-	public function __construct(string $appName, IRequest $request, ISession $session, string $hash, bool $isProtected) {
+	public function __construct(
+		string $appName,
+		IRequest $request,
+		ISession $session,
+		private string $hash,
+		private bool $isProtected,
+	) {
 		parent::__construct($appName, $request, $session);
-
-		$this->hash = $hash;
-		$this->isProtected = $isProtected;
 	}
 
 	protected function getPasswordHash(): string {
@@ -57,7 +54,7 @@ class PublicShareControllerTest extends \Test\TestCase {
 		$this->assertEquals('test', $controller->getToken());
 	}
 
-	public function dataIsAuthenticated() {
+	public static function dataIsAuthenticated(): array {
 		return [
 			[false, 'token1', 'token1', 'hash1', 'hash1',  true],
 			[false, 'token1', 'token1', 'hash1', 'hash2',  true],