1 files changed, 51 insertions, 25 deletions

diff --git a/tests/lib/Route/RouterTest.php b/tests/lib/Route/RouterTest.php
index 1f03f4edecb..560cd5d3aed 100644
--- a/tests/lib/Route/RouterTest.php
+++ b/tests/lib/Route/RouterTest.php
@@ -2,51 +2,77 @@
 
 declare(strict_types=1);
 /**
- * @copyright Copyright (c) 2019 Morris Jobke <hey@morrisjobke.de>
- *
- * @license GNU AGPL version 3 or any later version
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
+ * SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
 namespace Test\Route;
 
 use OC\Route\Router;
+use OCP\App\IAppManager;
+use OCP\Diagnostics\IEventLogger;
+use OCP\IConfig;
+use OCP\IRequest;
+use PHPUnit\Framework\MockObject\MockObject;
+use Psr\Container\ContainerInterface;
 use Psr\Log\LoggerInterface;
 use Test\TestCase;
 
 /**
  * Class RouterTest
  *
+ * @group RoutingWeirdness
+ *
  * @package Test\Route
  */
 class RouterTest extends TestCase {
-	public function testGenerateConsecutively(): void {
+	private Router $router;
+	private IAppManager&MockObject $appManager;
+
+	protected function setUp(): void {
+		parent::setUp();
 		/** @var LoggerInterface $logger */
 		$logger = $this->createMock(LoggerInterface::class);
-		$router = new Router($logger);
+		$logger->method('info')
+			->willReturnCallback(
+				function (string $message, array $data): void {
+					$this->fail('Unexpected info log: ' . (string)($data['exception'] ?? $message));
+				}
+			);
 
-		$this->assertEquals('/index.php/apps/files/', $router->generate('files.view.index'));
+		$this->appManager = $this->createMock(IAppManager::class);
 
-		// the OCS route is the prefixed one for the AppFramework - see /ocs/v1.php for routing details
-		$this->assertEquals('/index.php/ocsapp/apps/dav/api/v1/direct', $router->generate('ocs.dav.direct.getUrl'));
+		$this->router = new Router(
+			$logger,
+			$this->createMock(IRequest::class),
+			$this->createMock(IConfig::class),
+			$this->createMock(IEventLogger::class),
+			$this->createMock(ContainerInterface::class),
+			$this->appManager,
+		);
+	}
+
+	public function testHeartbeat(): void {
+		$this->assertEquals('/index.php/heartbeat', $this->router->generate('heartbeat'));
+	}
 
-		// special route name - should load all apps and then find the route
-		$this->assertEquals('/index.php/apps/files/ajax/list.php', $router->generate('files_ajax_list'));
+	public function testGenerateConsecutively(): void {
+		$this->appManager->expects(self::atLeastOnce())
+			->method('cleanAppId')
+			->willReturnArgument(0);
+		$this->appManager->expects(self::atLeastOnce())
+			->method('getAppPath')
+			->willReturnCallback(fn (string $appid): string => \OC::$SERVERROOT . '/apps/' . $appid);
+		$this->appManager->expects(self::atLeastOnce())
+			->method('isAppLoaded')
+			->willReturn(true);
+
+		$this->assertEquals('/index.php/apps/files/', $this->router->generate('files.view.index'));
+
+		// the OCS route is the prefixed one for the AppFramework - see /ocs/v1.php for routing details
+		$this->assertEquals('/index.php/ocsapp/apps/dav/api/v1/direct', $this->router->generate('ocs.dav.direct.getUrl'));
 
 		// test caching
-		$this->assertEquals('/index.php/apps/files/', $router->generate('files.view.index'));
+		$this->assertEquals('/index.php/apps/files/', $this->router->generate('files.view.index'));
 	}
 }