aboutsummaryrefslogtreecommitdiffstats
path: root/tests/lib/Share20/ManagerTest.php
diff options
context:
space:
mode:
Diffstat (limited to 'tests/lib/Share20/ManagerTest.php')
-rw-r--r--tests/lib/Share20/ManagerTest.php76
1 files changed, 22 insertions, 54 deletions
diff --git a/tests/lib/Share20/ManagerTest.php b/tests/lib/Share20/ManagerTest.php
index 92fa0f3854a..7859407651f 100644
--- a/tests/lib/Share20/ManagerTest.php
+++ b/tests/lib/Share20/ManagerTest.php
@@ -245,9 +245,7 @@ class ManagerTest extends \Test\TestCase {
];
}
- /**
- * @dataProvider dataTestDelete
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('dataTestDelete')]
public function testDelete($shareType, $sharedWith): void {
$manager = $this->createManagerMock()
->onlyMethods(['getShareById', 'deleteChildren', 'promoteReshares'])
@@ -1000,12 +998,12 @@ class ManagerTest extends \Test\TestCase {
}
/**
- * @dataProvider dataGeneralChecks
*
* @param $share
* @param $exceptionMessage
* @param $exception
*/
+ #[\PHPUnit\Framework\Attributes\DataProvider('dataGeneralChecks')]
public function testGeneralChecks($share, $exceptionMessage, $exception): void {
$thrown = null;
@@ -1076,9 +1074,7 @@ class ManagerTest extends \Test\TestCase {
return [[IShare::TYPE_USER], [IShare::TYPE_REMOTE], [IShare::TYPE_REMOTE_GROUP]];
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalInPast($shareType): void {
$this->expectException(GenericShareException::class);
$this->expectExceptionMessage('Expiration date is in the past');
@@ -1094,9 +1090,7 @@ class ManagerTest extends \Test\TestCase {
self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalEnforceButNotSet($shareType): void {
$this->expectException(\InvalidArgumentException::class);
$this->expectExceptionMessage('Expiration date is enforced');
@@ -1121,9 +1115,7 @@ class ManagerTest extends \Test\TestCase {
self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalEnforceButNotEnabledAndNotSet($shareType): void {
$share = $this->manager->newShare();
$share->setProviderId('foo')->setId('bar');
@@ -1146,9 +1138,7 @@ class ManagerTest extends \Test\TestCase {
$this->assertNull($share->getExpirationDate());
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalEnforceButNotSetNewShare($shareType): void {
$share = $this->manager->newShare();
$share->setShareType($shareType);
@@ -1181,9 +1171,7 @@ class ManagerTest extends \Test\TestCase {
$this->assertEquals($expected, $share->getExpirationDate());
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalEnforceRelaxedDefaultButNotSetNewShare($shareType): void {
$share = $this->manager->newShare();
$share->setShareType($shareType);
@@ -1216,9 +1204,7 @@ class ManagerTest extends \Test\TestCase {
$this->assertEquals($expected, $share->getExpirationDate());
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalEnforceTooFarIntoFuture($shareType): void {
$this->expectException(GenericShareException::class);
$this->expectExceptionMessage('Cannot set expiration date more than 3 days in the future');
@@ -1249,9 +1235,7 @@ class ManagerTest extends \Test\TestCase {
self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalEnforceValid($shareType): void {
$future = new \DateTime('now', $this->dateTimeZone->getTimeZone());
$future->add(new \DateInterval('P2D'));
@@ -1291,9 +1275,7 @@ class ManagerTest extends \Test\TestCase {
$this->assertEquals($expected, $share->getExpirationDate());
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalNoDefault($shareType): void {
$date = new \DateTime('now', $this->dateTimeZone->getTimeZone());
$date->add(new \DateInterval('P5D'));
@@ -1317,9 +1299,7 @@ class ManagerTest extends \Test\TestCase {
$this->assertEquals($expected, $share->getExpirationDate());
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalNoDateNoDefault($shareType): void {
$hookListener = $this->createMock(DummyShareManagerListener::class);
Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListener, 'listener');
@@ -1336,9 +1316,7 @@ class ManagerTest extends \Test\TestCase {
$this->assertNull($share->getExpirationDate());
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalNoDateDefault($shareType): void {
$share = $this->manager->newShare();
$share->setShareType($shareType);
@@ -1375,9 +1353,7 @@ class ManagerTest extends \Test\TestCase {
$this->assertEquals($expected, $share->getExpirationDate());
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalDefault($shareType): void {
$future = new \DateTime('now', $this->timezone);
$future->add(new \DateInterval('P5D'));
@@ -1417,9 +1393,7 @@ class ManagerTest extends \Test\TestCase {
$this->assertEquals($expected, $share->getExpirationDate());
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalHookModification($shareType): void {
$nextWeek = new \DateTime('now', $this->timezone);
$nextWeek->add(new \DateInterval('P7D'));
@@ -1443,9 +1417,7 @@ class ManagerTest extends \Test\TestCase {
$this->assertEquals($save, $share->getExpirationDate());
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalHookException($shareType): void {
$this->expectException(\Exception::class);
$this->expectExceptionMessage('Invalid date!');
@@ -1468,9 +1440,7 @@ class ManagerTest extends \Test\TestCase {
self::invokePrivate($this->manager, 'validateExpirationDateInternal', [$share]);
}
- /**
- * @dataProvider validateExpirationDateInternalProvider
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('validateExpirationDateInternalProvider')]
public function testValidateExpirationDateInternalExistingShareNoDefault($shareType): void {
$share = $this->manager->newShare();
$share->setShareType($shareType);
@@ -2356,7 +2326,6 @@ class ManagerTest extends \Test\TestCase {
}
/**
- * @dataProvider dataIsSharingDisabledForUser
*
* @param string $excludeGroups
* @param string $groupList
@@ -2364,6 +2333,7 @@ class ManagerTest extends \Test\TestCase {
* @param string[] $groupIds
* @param bool $expected
*/
+ #[\PHPUnit\Framework\Attributes\DataProvider('dataIsSharingDisabledForUser')]
public function testIsSharingDisabledForUser($excludeGroups, $groupList, $setList, $groupIds, $expected): void {
$user = $this->createMock(IUser::class);
@@ -2408,12 +2378,12 @@ class ManagerTest extends \Test\TestCase {
}
/**
- * @dataProvider dataCanShare
*
* @param bool $expected
* @param string $sharingEnabled
* @param bool $disabledForUser
*/
+ #[\PHPUnit\Framework\Attributes\DataProvider('dataCanShare')]
public function testCanShare($expected, $sharingEnabled, $disabledForUser): void {
$this->config->method('getAppValue')
->willReturnMap([
@@ -2960,7 +2930,7 @@ class ManagerTest extends \Test\TestCase {
->onlyMethods(['deleteShare'])
->getMock();
- /** @var \OCP\Share\IShare[] $shares */
+ /** @var IShare[] $shares */
$shares = [];
/*
@@ -2983,7 +2953,7 @@ class ManagerTest extends \Test\TestCase {
$shares[4]->setExpirationDate($today);
$shares[5]->setExpirationDate($today);
- /** @var \OCP\Share\IShare[] $i */
+ /** @var IShare[] $i */
$shares2 = [];
for ($i = 0; $i < 8; $i++) {
$shares2[] = clone $shares[$i];
@@ -4476,9 +4446,7 @@ class ManagerTest extends \Test\TestCase {
$this->addToAssertionCount(1);
}
- /**
- * @dataProvider dataTestShareProviderExists
- */
+ #[\PHPUnit\Framework\Attributes\DataProvider('dataTestShareProviderExists')]
public function testShareProviderExists($shareType, $expected): void {
$factory = $this->getMockBuilder('OCP\Share\IProviderFactory')->getMock();
$factory->expects($this->any())->method('getProviderForType')
@@ -4849,9 +4817,9 @@ class ManagerTest extends \Test\TestCase {
}
/**
- * @dataProvider dataCurrentUserCanEnumerateTargetUser
* @param bool $expected
*/
+ #[\PHPUnit\Framework\Attributes\DataProvider('dataCurrentUserCanEnumerateTargetUser')]
public function testCurrentUserCanEnumerateTargetUser(bool $currentUserIsGuest, bool $allowEnumerationFullMatch, bool $allowEnumeration, bool $limitEnumerationToPhone, bool $limitEnumerationToGroups, bool $isKnownToUser, bool $haveCommonGroup, bool $expected): void {
/** @var IManager|MockObject $manager */
$manager = $this->createManagerMock()