1 files changed, 22 insertions, 30 deletions

diff --git a/tests/lib/Share20/ShareTest.php b/tests/lib/Share20/ShareTest.php
index 7d4dc6de2d6..f15fbb860db 100644
--- a/tests/lib/Share20/ShareTest.php
+++ b/tests/lib/Share20/ShareTest.php
@@ -1,28 +1,19 @@
 <?php
+
 /**
- * @author Roeland Jago Douma <rullzer@owncloud.com>
- *
- * @copyright Copyright (c) 2016, ownCloud, Inc.
- * @license AGPL-3.0
- *
- * This code is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License, version 3,
- * as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License, version 3,
- * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *
+ * SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-FileCopyrightText: 2016 ownCloud, Inc.
+ * SPDX-License-Identifier: AGPL-3.0-only
  */
 
 namespace Test\Share20;
 
+use OC\Share20\Share;
 use OCP\Files\IRootFolder;
 use OCP\IUserManager;
+use OCP\Share\Exceptions\IllegalIDChangeException;
+use OCP\Share\IShare;
+use PHPUnit\Framework\MockObject\MockObject;
 
 /**
  * Class ShareTest
@@ -30,40 +21,41 @@ use OCP\IUserManager;
  * @package Test\Share20
  */
 class ShareTest extends \Test\TestCase {
-
-	/** @var IRootFolder|\PHPUnit\Framework\MockObject\MockObject */
+	/** @var IRootFolder|MockObject */
 	protected $rootFolder;
-	/** @var \OCP\Share\IShare */
+	/** @var IUserManager|MockObject */
+	protected $userManager;
+	/** @var IShare */
 	protected $share;
 
 	protected function setUp(): void {
 		$this->rootFolder = $this->createMock(IRootFolder::class);
 		$this->userManager = $this->createMock(IUserManager::class);
-		$this->share = new \OC\Share20\Share($this->rootFolder, $this->userManager);
+		$this->share = new Share($this->rootFolder, $this->userManager);
 	}
 
 
-	public function testSetIdInvalid() {
+	public function testSetIdInvalid(): void {
 		$this->expectException(\InvalidArgumentException::class);
 		$this->expectExceptionMessage('String expected.');
 
 		$this->share->setId(1.2);
 	}
 
-	public function testSetIdInt() {
+	public function testSetIdInt(): void {
 		$this->share->setId(42);
 		$this->assertEquals('42', $this->share->getId());
 	}
 
 
-	public function testSetIdString() {
+	public function testSetIdString(): void {
 		$this->share->setId('foo');
 		$this->assertEquals('foo', $this->share->getId());
 	}
 
 
-	public function testSetIdOnce() {
-		$this->expectException(\OCP\Share\Exceptions\IllegalIDChangeException::class);
+	public function testSetIdOnce(): void {
+		$this->expectException(IllegalIDChangeException::class);
 		$this->expectExceptionMessage('Not allowed to assign a new internal id to a share');
 
 		$this->share->setId('foo');
@@ -71,7 +63,7 @@ class ShareTest extends \Test\TestCase {
 	}
 
 
-	public function testSetProviderIdInt() {
+	public function testSetProviderIdInt(): void {
 		$this->expectException(\InvalidArgumentException::class);
 		$this->expectExceptionMessage('String expected.');
 
@@ -79,15 +71,15 @@ class ShareTest extends \Test\TestCase {
 	}
 
 
-	public function testSetProviderIdString() {
+	public function testSetProviderIdString(): void {
 		$this->share->setProviderId('foo');
 		$this->share->setId('bar');
 		$this->assertEquals('foo:bar', $this->share->getFullId());
 	}
 
 
-	public function testSetProviderIdOnce() {
-		$this->expectException(\OCP\Share\Exceptions\IllegalIDChangeException::class);
+	public function testSetProviderIdOnce(): void {
+		$this->expectException(IllegalIDChangeException::class);
 		$this->expectExceptionMessage('Not allowed to assign a new provider id to a share');
 
 		$this->share->setProviderId('foo');