1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
|
<?php
declare(strict_types=1);
/**
* SPDX-FileCopyrightText: 2020 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
namespace OCA\user_ldap\tests\Service;
use OCA\User_LDAP\Db\GroupMembership;
use OCA\User_LDAP\Db\GroupMembershipMapper;
use OCA\User_LDAP\Group_Proxy;
use OCA\User_LDAP\Service\UpdateGroupsService;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\EventDispatcher\IEventDispatcher;
use OCP\Group\Events\UserAddedEvent;
use OCP\Group\Events\UserRemovedEvent;
use OCP\IConfig;
use OCP\IGroup;
use OCP\IGroupManager;
use OCP\IUser;
use OCP\IUserManager;
use PHPUnit\Framework\MockObject\MockObject;
use Psr\Log\LoggerInterface;
use Test\TestCase;
class UpdateGroupsServiceTest extends TestCase {
/** @var Group_Proxy|MockObject */
protected $groupBackend;
/** @var IEventDispatcher|MockObject */
protected $dispatcher;
/** @var IGroupManager|MockObject */
protected $groupManager;
/** @var IUserManager|MockObject */
protected $userManager;
/** @var LoggerInterface|MockObject */
protected $logger;
/** @var GroupMembershipMapper|MockObject */
protected $groupMembershipMapper;
/** @var IConfig|MockObject */
protected $config;
/** @var ITimeFactory|MockObject */
protected $timeFactory;
protected UpdateGroupsService $updateGroupsService;
public function setUp(): void {
$this->groupBackend = $this->createMock(Group_Proxy::class);
$this->dispatcher = $this->createMock(IEventDispatcher::class);
$this->groupManager = $this->createMock(IGroupManager::class);
$this->userManager = $this->createMock(IUserManager::class);
$this->logger = $this->createMock(LoggerInterface::class);
$this->groupMembershipMapper = $this->createMock(GroupMembershipMapper::class);
$this->config = $this->createMock(IConfig::class);
$this->timeFactory = $this->createMock(ITimeFactory::class);
$this->updateGroupsService = new UpdateGroupsService(
$this->groupBackend,
$this->dispatcher,
$this->groupManager,
$this->userManager,
$this->logger,
$this->groupMembershipMapper,
$this->config,
$this->timeFactory
);
}
public function testHandleKnownGroups(): void {
$knownGroups = [
'emptyGroup' => [],
'stableGroup' => ['userA', 'userC', 'userE'],
'groupWithAdditions' => ['userA', 'userC', 'userE'],
'groupWithRemovals' => ['userA', 'userC', 'userDeleted', 'userE'],
'groupWithAdditionsAndRemovals' => ['userA', 'userC', 'userE'],
'vanishedGroup' => ['userB', 'userDeleted'],
];
$knownGroupsDB = [];
foreach ($knownGroups as $gid => $members) {
$knownGroupsDB[] = [
'owncloudname' => $gid,
'owncloudusers' => $members
];
}
$actualGroups = [
'emptyGroup' => [],
'stableGroup' => ['userA', 'userC', 'userE'],
'groupWithAdditions' => ['userA', 'userC', 'userE', 'userF'],
'groupWithRemovals' => ['userA', 'userE'],
'groupWithAdditionsAndRemovals' => ['userC', 'userE', 'userF'],
'newGroup' => ['userB', 'userF'],
];
$groups = array_intersect(array_keys($knownGroups), array_keys($actualGroups));
$this->groupMembershipMapper->expects($this->never())
->method('getKnownGroups');
$this->groupMembershipMapper->expects($this->exactly(5))
->method('findGroupMemberships')
->willReturnCallback(
fn ($group) => array_map(
fn ($userid) => GroupMembership::fromParams(['groupid' => $group,'userid' => $userid]),
$knownGroups[$group]
)
);
$this->groupMembershipMapper->expects($this->exactly(3))
->method('delete');
$this->groupMembershipMapper->expects($this->exactly(2))
->method('insert');
$this->groupBackend->expects($this->any())
->method('usersInGroup')
->willReturnCallback(function ($groupID) use ($actualGroups) {
return $actualGroups[$groupID] ?? [];
});
$this->groupManager->expects($this->any())
->method('get')
->willReturnCallback(function (string $groupId): ?IGroup {
if ($groupId === 'vanishedGroup') {
return null;
}
return $this->createMock(IGroup::class);
});
$this->userManager->expects($this->exactly(5))
->method('get')
->willReturnCallback(function (string $userId) {
if ($userId === 'userDeleted') {
// user already deleted
return null;
}
return $this->createMock(IUser::class);
});
$addedEvents = 0;
$removedEvents = 0;
$this->dispatcher->expects($this->exactly(4))
->method('dispatchTyped')
->willReturnCallback(function ($event) use (&$addedEvents, &$removedEvents): void {
if ($event instanceof UserRemovedEvent) {
$removedEvents++;
} elseif ($event instanceof UserAddedEvent) {
$addedEvents++;
}
});
$this->updateGroupsService->handleKnownGroups($groups);
$this->assertSame(2, $removedEvents);
$this->assertSame(2, $addedEvents);
// and no event for the user that is already deleted, the DB is nevertheless updated, hence 5
}
}
|
