1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
|
<?php
declare(strict_types=1);
/**
* SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
namespace lib\Security;
use OC\Net\HostnameClassifier;
use OC\Net\IpAddressClassifier;
use OC\Security\RemoteHostValidator;
use OCP\IConfig;
use OCP\Server;
use PHPUnit\Framework\MockObject\MockObject;
use Psr\Log\NullLogger;
use Test\TestCase;
class RemoteHostValidatorIntegrationTest extends TestCase {
/** @var IConfig|IConfig&MockObject|MockObject */
private IConfig $config;
private RemoteHostValidator $validator;
protected function setUp(): void {
parent::setUp();
// Mock config to avoid any side effects
$this->config = $this->createMock(IConfig::class);
$this->validator = new RemoteHostValidator(
$this->config,
Server::get(HostnameClassifier::class),
Server::get(IpAddressClassifier::class),
new NullLogger(),
);
}
public function localHostsData(): array {
return [
['[::1]'],
['[::]'],
['192.168.0.1'],
['172.16.42.1'],
['[fdf8:f53b:82e4::53]'],
['[fe80::200:5aee:feaa:20a2]'],
['[0:0:0:0:0:ffff:10.0.0.1]'],
['[0:0:0:0:0:ffff:127.0.0.0]'],
['10.0.0.1'],
['!@#$'], // test invalid url
['100.100.100.200'],
['192.0.0.1'],
['0177.0.0.9'],
['⑯⑨。②⑤④。⑯⑨。②⑤④'],
['127。②⑤④。⑯⑨.②⑤④'],
['127.0.00000000000000000000000000000000001'],
['127.1'],
['127.000.001'],
['0177.0.0.01'],
['0x7f.0x0.0x0.0x1'],
['0x7f000001'],
['2130706433'],
['00000000000000000000000000000000000000000000000000177.1'],
['0x7f.1'],
['127.0x1'],
['[0000:0000:0000:0000:0000:0000:0000:0001]'],
['[0:0:0:0:0:0:0:1]'],
['[0:0:0:0::0:0:1]'],
['%31%32%37%2E%30%2E%30%2E%31'],
['%31%32%37%2E%30%2E%30.%31'],
['[%3A%3A%31]'],
];
}
/**
* @dataProvider localHostsData
*/
public function testLocalHostsWhenNotAllowed(string $host): void {
$this->config
->method('getSystemValueBool')
->with('allow_local_remote_servers', false)
->willReturn(false);
$isValid = $this->validator->isValid($host);
self::assertFalse($isValid);
}
/**
* @dataProvider localHostsData
*/
public function testLocalHostsWhenAllowed(string $host): void {
$this->config
->method('getSystemValueBool')
->with('allow_local_remote_servers', false)
->willReturn(true);
$isValid = $this->validator->isValid($host);
self::assertTrue($isValid);
}
public function externalAddressesData():array {
return [
['8.8.8.8'],
['8.8.4.4'],
['8.8.8.8'],
['8.8.4.4'],
['[2001:4860:4860::8888]'],
];
}
/**
* @dataProvider externalAddressesData
*/
public function testExternalHost(string $host): void {
$this->config
->method('getSystemValueBool')
->with('allow_local_remote_servers', false)
->willReturn(false);
$isValid = $this->validator->isValid($host);
self::assertTrue($isValid);
}
}
|