aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDecebal Suiu <decebal.suiu@gmail.com>2015-10-06 11:22:51 +0300
committerDecebal Suiu <decebal.suiu@gmail.com>2015-10-06 11:22:51 +0300
commitaf4dc9ed4239e9b4e2ef8724a7d30038c485535f (patch)
tree9ee344150f6a4304e4ecce9ad4a427017b6b38a5
parent57c9474e207806e5e2b72b19a5a53dce1a62cee3 (diff)
downloadpf4j-af4dc9ed4239e9b4e2ef8724a7d30038c485535f.tar.gz
pf4j-af4dc9ed4239e9b4e2ef8724a7d30038c485535f.zip
use FileUtils.writeLines
-rw-r--r--pf4j/src/main/java/ro/fortsoft/pf4j/util/FileUtils.java2
-rw-r--r--pf4j/src/test/java/ro/fortsoft/pf4j/DefaultPluginStatusProviderTest.java32
2 files changed, 18 insertions, 16 deletions
diff --git a/pf4j/src/main/java/ro/fortsoft/pf4j/util/FileUtils.java b/pf4j/src/main/java/ro/fortsoft/pf4j/util/FileUtils.java
index 0c3f534..7f0b10c 100644
--- a/pf4j/src/main/java/ro/fortsoft/pf4j/util/FileUtils.java
+++ b/pf4j/src/main/java/ro/fortsoft/pf4j/util/FileUtils.java
@@ -58,7 +58,7 @@ public class FileUtils {
writer = new BufferedWriter(new FileWriter(file));
for (String line : lines) {
writer.write(line);
- writer.write('\n');
+ writer.newLine();
}
} finally {
if (writer != null) {
diff --git a/pf4j/src/test/java/ro/fortsoft/pf4j/DefaultPluginStatusProviderTest.java b/pf4j/src/test/java/ro/fortsoft/pf4j/DefaultPluginStatusProviderTest.java
index 9ee6ca6..17a698b 100644
--- a/pf4j/src/test/java/ro/fortsoft/pf4j/DefaultPluginStatusProviderTest.java
+++ b/pf4j/src/test/java/ro/fortsoft/pf4j/DefaultPluginStatusProviderTest.java
@@ -18,13 +18,12 @@ package ro.fortsoft.pf4j;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
+import ro.fortsoft.pf4j.util.FileUtils;
-import java.io.BufferedWriter;
import java.io.File;
-import java.io.FileOutputStream;
import java.io.IOException;
-import java.io.OutputStreamWriter;
-import java.io.Writer;
+import java.util.ArrayList;
+import java.util.List;
import static org.junit.Assert.*;
@@ -133,20 +132,23 @@ public class DefaultPluginStatusProviderTest {
}
private void createDisabledFile() throws IOException {
- File file = testFolder.newFile("disabled.txt");
- try (Writer writer = new BufferedWriter(new OutputStreamWriter(new FileOutputStream(file), "utf-8"))) {
- writer.write("plugin-2\r\n");
- }
- file.createNewFile();
+ List<String> plugins = new ArrayList<>();
+ plugins.add("plugin-2");
+
+ writeLines(plugins, "disabled.txt");
}
private void createEnabledFile() throws IOException {
- File file = testFolder.newFile("enabled.txt");
- file.createNewFile();
- try (Writer writer = new BufferedWriter(new OutputStreamWriter(new FileOutputStream(file), "utf-8"))) {
- writer.write("plugin-1\r\n");
- writer.write("plugin-2\r\n");
- }
+ List<String> plugins = new ArrayList<>();
+ plugins.add("plugin-1");
+ plugins.add("plugin-2");
+
+ writeLines(plugins, "enabled.txt");
+ }
+
+ private void writeLines(List<String> lines, String fileName) throws IOException {
+ File file = testFolder.newFile(fileName);
+ FileUtils.writeLines(lines, file);
}
}