diff options
author | Dominik Stadler <centic@apache.org> | 2015-08-17 20:54:32 +0000 |
---|---|---|
committer | Dominik Stadler <centic@apache.org> | 2015-08-17 20:54:32 +0000 |
commit | 74c8ca4e5e87bbaa075a0dcc1acd0bdcb999d115 (patch) | |
tree | d4016b3dddfebcf8f57a6c93fed4b3837bfafd4a | |
parent | c26d5250d66e628d73bb80e3c1e4c0e279385b69 (diff) | |
download | poi-74c8ca4e5e87bbaa075a0dcc1acd0bdcb999d115.tar.gz poi-74c8ca4e5e87bbaa075a0dcc1acd0bdcb999d115.zip |
Bug 54938: Throw InvalidFormatException as documented instead of IllegalArgumentException in WorkbookFactory.create()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696338 13f79535-47bb-0310-9956-ffa450edef68
-rw-r--r-- | src/ooxml/java/org/apache/poi/ss/usermodel/WorkbookFactory.java | 2 | ||||
-rw-r--r-- | src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/src/ooxml/java/org/apache/poi/ss/usermodel/WorkbookFactory.java b/src/ooxml/java/org/apache/poi/ss/usermodel/WorkbookFactory.java index dfdf3f92ec..8188b0287d 100644 --- a/src/ooxml/java/org/apache/poi/ss/usermodel/WorkbookFactory.java +++ b/src/ooxml/java/org/apache/poi/ss/usermodel/WorkbookFactory.java @@ -208,7 +208,7 @@ public class WorkbookFactory { if (POIXMLDocument.hasOOXMLHeader(inp)) { return new XSSFWorkbook(OPCPackage.open(inp)); } - throw new IllegalArgumentException("Your InputStream was neither an OLE2 stream, nor an OOXML stream"); + throw new InvalidFormatException("Your InputStream was neither an OLE2 stream, nor an OOXML stream"); } /** diff --git a/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java b/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java index f3fcbb889e..965aa2c3a4 100644 --- a/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java +++ b/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java @@ -30,6 +30,7 @@ import org.apache.poi.ss.usermodel.Workbook; import org.apache.poi.ss.usermodel.WorkbookFactory; import org.apache.poi.util.TempFile; import org.apache.poi.xssf.usermodel.XSSFWorkbook; +import org.apache.poi.openxml4j.exceptions.InvalidFormatException; import org.apache.poi.openxml4j.opc.OPCPackage; import junit.framework.TestCase; @@ -135,7 +136,7 @@ public final class TestWorkbookFactory extends TestCase { stream.close(); } fail(); - } catch(IllegalArgumentException e) { + } catch(InvalidFormatException e) { // Good } } |