sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751007 13f79535-47bb-0310-9956-ffa450edef68

9 files changed, 9 insertions, 9 deletions

diff --git a/src/java/org/apache/poi/poifs/filesystem/Ole10Native.java b/src/java/org/apache/poi/poifs/filesystem/Ole10Native.java
index 11f18a40a6..aee6747592 100644
--- a/src/java/org/apache/poi/poifs/filesystem/Ole10Native.java
+++ b/src/java/org/apache/poi/poifs/filesystem/Ole10Native.java
@@ -393,6 +393,6 @@ public class Ole10Native {
     }

 

     public void setDataBuffer(byte dataBuffer[]) {

-        this.dataBuffer = dataBuffer;

+        this.dataBuffer = dataBuffer.clone();

     }

 }

diff --git a/src/java/org/apache/poi/poifs/nio/ByteArrayBackedDataSource.java b/src/java/org/apache/poi/poifs/nio/ByteArrayBackedDataSource.java
index 6da40cd5ce..88ee7da7f3 100644
--- a/src/java/org/apache/poi/poifs/nio/ByteArrayBackedDataSource.java
+++ b/src/java/org/apache/poi/poifs/nio/ByteArrayBackedDataSource.java
@@ -28,7 +28,7 @@ public class ByteArrayBackedDataSource extends DataSource {
    private byte[] buffer;
    private long size;
    
-   public ByteArrayBackedDataSource(byte[] data, int size) {
+   public ByteArrayBackedDataSource(byte[] data, int size) { // NOSONAR
       this.buffer = data;
       this.size = size;
    }
diff --git a/src/java/org/apache/poi/poifs/storage/DataInputBlock.java b/src/java/org/apache/poi/poifs/storage/DataInputBlock.java
index 2550d2d910..0710b4ee73 100644
--- a/src/java/org/apache/poi/poifs/storage/DataInputBlock.java
+++ b/src/java/org/apache/poi/poifs/storage/DataInputBlock.java
@@ -47,7 +47,7 @@ public final class DataInputBlock {
 	private int _readIndex;
 	private int _maxIndex;
 
-	DataInputBlock(byte[] data, int startOffset) {
+	DataInputBlock(byte[] data, int startOffset) { // NOSONAR
 		_buf = data;
 		_readIndex = startOffset;
 		_maxIndex = _buf.length;
diff --git a/src/java/org/apache/poi/ss/formula/SheetRangeEvaluator.java b/src/java/org/apache/poi/ss/formula/SheetRangeEvaluator.java
index a69d76d145..68dbb9be3f 100644
--- a/src/java/org/apache/poi/ss/formula/SheetRangeEvaluator.java
+++ b/src/java/org/apache/poi/ss/formula/SheetRangeEvaluator.java
@@ -36,7 +36,7 @@ final class SheetRangeEvaluator implements SheetRange {
         }
         _firstSheetIndex = firstSheetIndex;
         _lastSheetIndex = lastSheetIndex;
-        _sheetEvaluators = sheetEvaluators;
+        _sheetEvaluators = sheetEvaluators.clone();
 	}
     public SheetRangeEvaluator(int onlySheetIndex, SheetRefEvaluator sheetEvaluator) {
         this(onlySheetIndex, onlySheetIndex, new SheetRefEvaluator[] {sheetEvaluator});
diff --git a/src/java/org/apache/poi/ss/usermodel/charts/DataSources.java b/src/java/org/apache/poi/ss/usermodel/charts/DataSources.java
index bd78672340..2f443814ee 100644
--- a/src/java/org/apache/poi/ss/usermodel/charts/DataSources.java
+++ b/src/java/org/apache/poi/ss/usermodel/charts/DataSources.java
@@ -77,7 +77,7 @@ public class DataSources {
         private final T[] elements;
 
         public ArrayDataSource(T[] elements) {
-            this.elements = elements;
+            this.elements = elements.clone();
         }
 
         public int getPointCount() {
diff --git a/src/java/org/apache/poi/ss/util/SSCellRange.java b/src/java/org/apache/poi/ss/util/SSCellRange.java
index 6a44a81f6b..f58a2780e8 100644
--- a/src/java/org/apache/poi/ss/util/SSCellRange.java
+++ b/src/java/org/apache/poi/ss/util/SSCellRange.java
@@ -45,7 +45,7 @@ public final class SSCellRange<K extends Cell> implements CellRange<K> {
 		_firstColumn = firstColumn;
 		_height = height;
 		_width = width;
-		_flattenedArray = flattenedArray;
+		_flattenedArray = flattenedArray.clone();
 	}
 
 	public static <B extends Cell> SSCellRange<B> create(int firstRow, int firstColumn, int height, int width, List<B> flattenedList, Class<B> cellClass) {
diff --git a/src/java/org/apache/poi/ss/util/SheetBuilder.java b/src/java/org/apache/poi/ss/util/SheetBuilder.java
index 960d2d6ca2..366d783baf 100644
--- a/src/java/org/apache/poi/ss/util/SheetBuilder.java
+++ b/src/java/org/apache/poi/ss/util/SheetBuilder.java
@@ -40,7 +40,7 @@ public class SheetBuilder {
 
     public SheetBuilder(Workbook workbook, Object[][] cells) {
         this.workbook = workbook;
-        this.cells = cells;
+        this.cells = cells.clone();
     }
 
     /**
diff --git a/src/java/org/apache/poi/util/LittleEndianByteArrayInputStream.java b/src/java/org/apache/poi/util/LittleEndianByteArrayInputStream.java
index 7f509396a6..54388e1518 100644
--- a/src/java/org/apache/poi/util/LittleEndianByteArrayInputStream.java
+++ b/src/java/org/apache/poi/util/LittleEndianByteArrayInputStream.java
@@ -27,7 +27,7 @@ public final class LittleEndianByteArrayInputStream implements LittleEndianInput
 	private final int _endIndex;
 	private int _readIndex;
 
-	public LittleEndianByteArrayInputStream(byte[] buf, int startOffset, int maxReadLen) {
+	public LittleEndianByteArrayInputStream(byte[] buf, int startOffset, int maxReadLen) { // NOSONAR
 		_buf = buf;
 		_readIndex = startOffset;
 		_endIndex = startOffset + maxReadLen;
diff --git a/src/java/org/apache/poi/util/LittleEndianByteArrayOutputStream.java b/src/java/org/apache/poi/util/LittleEndianByteArrayOutputStream.java
index 0320734b2d..081309cc2e 100644
--- a/src/java/org/apache/poi/util/LittleEndianByteArrayOutputStream.java
+++ b/src/java/org/apache/poi/util/LittleEndianByteArrayOutputStream.java
@@ -29,7 +29,7 @@ public final class LittleEndianByteArrayOutputStream implements LittleEndianOutp
 	private final int _endIndex;
 	private int _writeIndex;
 
-	public LittleEndianByteArrayOutputStream(byte[] buf, int startOffset, int maxWriteLen) {
+	public LittleEndianByteArrayOutputStream(byte[] buf, int startOffset, int maxWriteLen) { // NOSONAR
 		if (startOffset < 0 || startOffset > buf.length) {
 			throw new IllegalArgumentException("Specified startOffset (" + startOffset 
 					+ ") is out of allowable range (0.." + buf.length + ")");