aboutsummaryrefslogtreecommitdiffstats
path: root/src/ooxml/java/org/apache/poi/xssf/usermodel
diff options
context:
space:
mode:
authorDominik Stadler <centic@apache.org>2019-04-23 20:27:39 +0000
committerDominik Stadler <centic@apache.org>2019-04-23 20:27:39 +0000
commitcd52566c981c75fb147b39e346001c60587c1374 (patch)
treee594f2f98ae96df8f316c7b00208870d6b61073b /src/ooxml/java/org/apache/poi/xssf/usermodel
parentd7aedc7978e9c401b6f3c4bc350ac5e99d2cbe6f (diff)
downloadpoi-cd52566c981c75fb147b39e346001c60587c1374.tar.gz
poi-cd52566c981c75fb147b39e346001c60587c1374.zip
Bug 63073: Adjust returned index of merged regions and verify all calls in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858021 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'src/ooxml/java/org/apache/poi/xssf/usermodel')
-rw-r--r--src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
index 8f3e411644..955fcdec7c 100644
--- a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
+++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
@@ -392,7 +392,7 @@ public class XSSFSheet extends POIXMLDocumentPart implements Sheet {
*
* @param region to merge
* @param validate whether to validate merged region
- * @return index of this region
+ * @return 0-based index of this region
* @throws IllegalArgumentException if region contains fewer than 2 cells (this check is inexpensive and is performed regardless of <tt>validate</tt>)
* @throws IllegalStateException if region intersects with a multi-cell array formula
* @throws IllegalStateException if region intersects with an existing region on this sheet
@@ -409,14 +409,14 @@ public class XSSFSheet extends POIXMLDocumentPart implements Sheet {
validateArrayFormulas(region);
// Throw IllegalStateException if the argument CellRangeAddress intersects with
- // a merged region already in this sheet
+ // a merged region already in this sheet
validateMergedRegions(region);
}
CTMergeCells ctMergeCells = worksheet.isSetMergeCells() ? worksheet.getMergeCells() : worksheet.addNewMergeCells();
CTMergeCell ctMergeCell = ctMergeCells.addNewMergeCell();
ctMergeCell.setRef(region.formatAsString());
- return ctMergeCells.sizeOfMergeCellArray();
+ return ctMergeCells.sizeOfMergeCellArray()-1;
}
/**