Sonar fixes

JUnit5 test classes and methods should have default package visibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885340 13f79535-47bb-0310-9956-ffa450edef68

10 files changed, 10 insertions, 11 deletions

diff --git a/src/testcases/org/apache/poi/util/TestBitField.java b/src/testcases/org/apache/poi/util/TestBitField.java
index 2834466979..55c30087fa 100644
--- a/src/testcases/org/apache/poi/util/TestBitField.java
+++ b/src/testcases/org/apache/poi/util/TestBitField.java
@@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Class to test BitField functionality
  */
-public final class TestBitField {
+final class TestBitField {
     private static BitField bf_multi  = BitFieldFactory.getInstance(0x3F80);
     private static BitField bf_single = BitFieldFactory.getInstance(0x4000);
 
diff --git a/src/testcases/org/apache/poi/util/TestByteField.java b/src/testcases/org/apache/poi/util/TestByteField.java
index 782a87b032..8c37667fbc 100644
--- a/src/testcases/org/apache/poi/util/TestByteField.java
+++ b/src/testcases/org/apache/poi/util/TestByteField.java
@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Unit test for ByteField class
  */
-public final class TestByteField {
+final class TestByteField {
 
     private static final byte[] _test_array = {
         Byte.MIN_VALUE, ( byte ) -1, ( byte ) 0, ( byte ) 1, Byte.MAX_VALUE
diff --git a/src/testcases/org/apache/poi/util/TestIOUtils.java b/src/testcases/org/apache/poi/util/TestIOUtils.java
index a4a3513ba5..196fcf401b 100644
--- a/src/testcases/org/apache/poi/util/TestIOUtils.java
+++ b/src/testcases/org/apache/poi/util/TestIOUtils.java
@@ -45,7 +45,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Class to test IOUtils
  */
-public final class TestIOUtils {
+final class TestIOUtils {
 
     private static File TMP;
     private static final long LENGTH = 300+new Random().nextInt(9000);
diff --git a/src/testcases/org/apache/poi/util/TestIntList.java b/src/testcases/org/apache/poi/util/TestIntList.java
index 38e8cc2cc3..3483933ce4 100644
--- a/src/testcases/org/apache/poi/util/TestIntList.java
+++ b/src/testcases/org/apache/poi/util/TestIntList.java
@@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test;
  *
  * @author Marc Johnson
  */
-public final class TestIntList {
+final class TestIntList {
     @Test
     void testConstructors() {
         IntList list = new IntList();
diff --git a/src/testcases/org/apache/poi/util/TestIntegerField.java b/src/testcases/org/apache/poi/util/TestIntegerField.java
index 96740ce464..d8e2f1b66f 100644
--- a/src/testcases/org/apache/poi/util/TestIntegerField.java
+++ b/src/testcases/org/apache/poi/util/TestIntegerField.java
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Test IntegerField code
  */
-public final class TestIntegerField {
+final class TestIntegerField {
 
     private static final int[] _test_array = {Integer.MIN_VALUE, -1, 0, 1, Integer.MAX_VALUE};
 
diff --git a/src/testcases/org/apache/poi/util/TestLittleEndian.java b/src/testcases/org/apache/poi/util/TestLittleEndian.java
index 268dba5621..27e5e3fe1a 100644
--- a/src/testcases/org/apache/poi/util/TestLittleEndian.java
+++ b/src/testcases/org/apache/poi/util/TestLittleEndian.java
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Class to test LittleEndian functionality
  */
-public final class TestLittleEndian {
+final class TestLittleEndian {
 
     /**
      * test the getShort() method
diff --git a/src/testcases/org/apache/poi/util/TestLittleEndianStreams.java b/src/testcases/org/apache/poi/util/TestLittleEndianStreams.java
index dfeff3cc04..54ebefa5b5 100644
--- a/src/testcases/org/apache/poi/util/TestLittleEndianStreams.java
+++ b/src/testcases/org/apache/poi/util/TestLittleEndianStreams.java
@@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Class to test {@link LittleEndianInputStream} and {@link LittleEndianOutputStream}
  */
-public final class TestLittleEndianStreams {
+final class TestLittleEndianStreams {
 
 	@Test
 	void testRead() throws IOException {
diff --git a/src/testcases/org/apache/poi/util/TestLongField.java b/src/testcases/org/apache/poi/util/TestLongField.java
index 164c6ceb01..8cd39aba92 100644
--- a/src/testcases/org/apache/poi/util/TestLongField.java
+++ b/src/testcases/org/apache/poi/util/TestLongField.java
@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Test LongField code
  */
-public final class TestLongField {
+final class TestLongField {
 
     static private final long[] _test_array =
     {
diff --git a/src/testcases/org/apache/poi/util/TestPOILogFactory.java b/src/testcases/org/apache/poi/util/TestPOILogFactory.java
index 9fa8fe8271..05553887d6 100644
--- a/src/testcases/org/apache/poi/util/TestPOILogFactory.java
+++ b/src/testcases/org/apache/poi/util/TestPOILogFactory.java
@@ -19,7 +19,7 @@ package org.apache.poi.util;
 
 import org.junit.jupiter.api.Test;
 
-public final class TestPOILogFactory {
+final class TestPOILogFactory {
 
 
     /**
diff --git a/src/testcases/org/apache/poi/util/TestShortField.java b/src/testcases/org/apache/poi/util/TestShortField.java
index 73f22250ca..8c863ee074 100644
--- a/src/testcases/org/apache/poi/util/TestShortField.java
+++ b/src/testcases/org/apache/poi/util/TestShortField.java
@@ -19,7 +19,6 @@ package org.apache.poi.util;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.fail;
 
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
@@ -29,7 +28,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Test ShortField code
  */
-public final class TestShortField {
+final class TestShortField {
 
     private static final short[] _test_array = {Short.MIN_VALUE, -1, 0, 1, Short.MAX_VALUE};