aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorJaven O'Neal <onealj@apache.org>2016-06-13 06:38:53 +0000
committerJaven O'Neal <onealj@apache.org>2016-06-13 06:38:53 +0000
commitabb3591635b88bd238eca2a3457f9099059f8b5a (patch)
treee3555f8966c1404e95e0d81c768105bf40c09bef /src
parentf31c1d72fc725ce0def018094b046e80a44dba6d (diff)
downloadpoi-abb3591635b88bd238eca2a3457f9099059f8b5a.tar.gz
poi-abb3591635b88bd238eca2a3457f9099059f8b5a.zip
findbugs: fix SF_SWITCH_NO_DEFAULT warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748090 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'src')
-rw-r--r--src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java2
-rw-r--r--src/java/org/apache/poi/ss/util/AreaReference.java5
-rw-r--r--src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java4
3 files changed, 9 insertions, 2 deletions
diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java b/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java
index dbefaabe5c..1f3175121c 100644
--- a/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java
+++ b/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java
@@ -78,6 +78,8 @@ public class HSSFHyperlink implements Hyperlink {
case LINK_DOCUMENT:
record.newDocumentLink();
break;
+ default:
+ throw new IllegalArgumentException("Invalid type: " + type);
}
}
diff --git a/src/java/org/apache/poi/ss/util/AreaReference.java b/src/java/org/apache/poi/ss/util/AreaReference.java
index f046338488..6d2e4530bf 100644
--- a/src/java/org/apache/poi/ss/util/AreaReference.java
+++ b/src/java/org/apache/poi/ss/util/AreaReference.java
@@ -355,10 +355,11 @@ public class AreaReference {
}
delimiterPos = i;
}
+ // fall through
default:
- continue;
+ continue; //continue the for-loop
case SPECIAL_NAME_DELIMITER:
- // fall through
+ break;
}
if(!insideDelimitedName) {
insideDelimitedName = true;
diff --git a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java
index 7ef52c1a7d..cf1b419902 100644
--- a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java
+++ b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java
@@ -779,6 +779,10 @@ public class SXSSFCell implements Cell {
current=new HyperlinkProperty(value);
break;
}
+ default:
+ {
+ throw new IllegalArgumentException("Invalid type: " + type);
+ }
}
if(previous!=null)
{