aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorYegor Kozlov <yegor@apache.org>2012-05-25 12:53:12 +0000
committerYegor Kozlov <yegor@apache.org>2012-05-25 12:53:12 +0000
commitd677bc00f2f0502f3a19545e0f12a73b711ce20c (patch)
tree9515106af9478b70a1a90f9977db6abe3a39af46 /src
parenta91a13bb2a7cf3e822f5a883529c45d246d5b7b5 (diff)
downloadpoi-d677bc00f2f0502f3a19545e0f12a73b711ce20c.tar.gz
poi-d677bc00f2f0502f3a19545e0f12a73b711ce20c.zip
Bugzilla 53271 - Removed unconditional asserts in SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1342604 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'src')
-rw-r--r--src/documentation/content/xdocs/status.xml1
-rw-r--r--src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java4
-rw-r--r--src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java1
-rw-r--r--src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java1
-rw-r--r--src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java2
-rw-r--r--src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java1
6 files changed, 1 insertions, 9 deletions
diff --git a/src/documentation/content/xdocs/status.xml b/src/documentation/content/xdocs/status.xml
index d73559ac54..b2c7083a8b 100644
--- a/src/documentation/content/xdocs/status.xml
+++ b/src/documentation/content/xdocs/status.xml
@@ -34,6 +34,7 @@
<changes>
<release version="3.9-beta1" date="2012-??-??">
+ <action dev="poi-developers" type="fix">53271 - Removed unconditional asserts in SXSSF</action>
<action dev="poi-developers" type="add">53025 - Updatad documentation and example on using Data Validations </action>
<action dev="poi-developers" type="add">53227 - Corrected AddDimensionedImage.java to support XSSF/SXSSF </action>
<action dev="poi-developers" type="add">53058 - Utility for representing drawings contained in a binary Excel file as a XML tree</action>
diff --git a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java
index bd57fc3ded..46ca95fcf7 100644
--- a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java
+++ b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java
@@ -728,10 +728,6 @@ public class SXSSFCell implements Cell
}
void ensureTypeOrFormulaType(int type)
{
- assert type==CELL_TYPE_NUMERIC||
- type==CELL_TYPE_STRING||
- type==CELL_TYPE_BOOLEAN||
- type==CELL_TYPE_ERROR;
if(_value.getType()==type)
{
if(type==CELL_TYPE_STRING&&((StringValue)_value).isRichText())
diff --git a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java
index 1bd53bc8b2..a762de822b 100644
--- a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java
+++ b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java
@@ -212,7 +212,6 @@ public class SXSSFRow implements Row
*/
public Cell getCell(int cellnum, MissingCellPolicy policy)
{
- assert false;
Cell cell = getCell(cellnum);
if(policy == RETURN_NULL_AND_BLANK)
{
diff --git a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java
index afe8612002..5eb3338afb 100644
--- a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java
+++ b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java
@@ -1330,7 +1330,6 @@ public class SXSSFSheet implements Sheet, Cloneable
if(entry.getValue()==row)
return entry.getKey().intValue();
}
- assert false;
return -1;
}
}
diff --git a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java
index a79f1aad02..056dca313f 100644
--- a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java
+++ b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java
@@ -244,7 +244,6 @@ public class SXSSFWorkbook implements Workbook
XSSFSheet getXSSFSheet(SXSSFSheet sheet)
{
XSSFSheet result=_sxFromXHash.get(sheet);
- assert result!=null;
return result;
}
@@ -543,7 +542,6 @@ public class SXSSFWorkbook implements Workbook
*/
public int getSheetIndex(Sheet sheet)
{
- assert sheet instanceof SXSSFSheet;
return _wb.getSheetIndex(getXSSFSheet((SXSSFSheet)sheet));
}
diff --git a/src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java b/src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java
index 1823fec798..521f9d56ee 100644
--- a/src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java
+++ b/src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java
@@ -204,7 +204,6 @@ public class SheetDataWriter {
break;
}
default: {
- assert false;
throw new RuntimeException("Huh?");
}
}