diff options
Diffstat (limited to 'src/java/org/apache/poi/hssf/usermodel')
| -rw-r--r-- | src/java/org/apache/poi/hssf/usermodel/HSSFErrorConstants.java | 59 | ||||
| -rw-r--r-- | src/java/org/apache/poi/hssf/usermodel/HSSFSheetConditionalFormatting.java | 7 |
2 files changed, 6 insertions, 60 deletions
diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFErrorConstants.java b/src/java/org/apache/poi/hssf/usermodel/HSSFErrorConstants.java index 89c25d1e87..f82ee721d0 100644 --- a/src/java/org/apache/poi/hssf/usermodel/HSSFErrorConstants.java +++ b/src/java/org/apache/poi/hssf/usermodel/HSSFErrorConstants.java @@ -16,67 +16,12 @@ ==================================================================== */ package org.apache.poi.hssf.usermodel; +import org.apache.poi.ss.usermodel.ErrorConstants; /** * Contains raw Excel error codes (as defined in OOO's excelfileformat.pdf (2.5.6) * * @author Michael Harhen */ -public final class HSSFErrorConstants { - private HSSFErrorConstants() { - // no instances of this class - } - - /** <b>#NULL!</b> - Intersection of two cell ranges is empty */ - public static final int ERROR_NULL = 0x00; - /** <b>#DIV/0!</b> - Division by zero */ - public static final int ERROR_DIV_0 = 0x07; - /** <b>#VALUE!</b> - Wrong type of operand */ - public static final int ERROR_VALUE = 0x0F; - /** <b>#REF!</b> - Illegal or deleted cell reference */ - public static final int ERROR_REF = 0x17; - /** <b>#NAME?</b> - Wrong function or range name */ - public static final int ERROR_NAME = 0x1D; - /** <b>#NUM!</b> - Value range overflow */ - public static final int ERROR_NUM = 0x24; - /** <b>#N/A</b> - Argument or function not available */ - public static final int ERROR_NA = 0x2A; - - - /** - * @return Standard Excel error literal for the specified error code. - * @throws IllegalArgumentException if the specified error code is not one of the 7 - * standard error codes - */ - public static final String getText(int errorCode) { - switch(errorCode) { - case ERROR_NULL: return "#NULL!"; - case ERROR_DIV_0: return "#DIV/0!"; - case ERROR_VALUE: return "#VALUE!"; - case ERROR_REF: return "#REF!"; - case ERROR_NAME: return "#NAME?"; - case ERROR_NUM: return "#NUM!"; - case ERROR_NA: return "#N/A"; - } - throw new IllegalArgumentException("Bad error code (" + errorCode + ")"); - } - - /** - * @return <code>true</code> if the specified error code is a standard Excel error code. - */ - public static final boolean isValidCode(int errorCode) { - // This method exists because it would be bad to force clients to catch - // IllegalArgumentException if there were potential for passing an invalid error code. - switch(errorCode) { - case ERROR_NULL: - case ERROR_DIV_0: - case ERROR_VALUE: - case ERROR_REF: - case ERROR_NAME: - case ERROR_NUM: - case ERROR_NA: - return true; - } - return false; - } +public final class HSSFErrorConstants extends ErrorConstants { } diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFSheetConditionalFormatting.java b/src/java/org/apache/poi/hssf/usermodel/HSSFSheetConditionalFormatting.java index c042456a4f..8e8cf40a1b 100644 --- a/src/java/org/apache/poi/hssf/usermodel/HSSFSheetConditionalFormatting.java +++ b/src/java/org/apache/poi/hssf/usermodel/HSSFSheetConditionalFormatting.java @@ -39,7 +39,8 @@ public final class HSSFSheetConditionalFormatting { /**
* A factory method allowing to create a conditional formatting rule
- * with a cell comparison operator
+ * with a cell comparison operator<p/>
+ * TODO - formulas containing cell references are currently not parsed properly
*
* @param comparisonOperation - a constant value from
* <tt>{@link HSSFConditionalFormattingRule.ComparisonOperator}</tt>: <p>
@@ -72,8 +73,8 @@ public final class HSSFSheetConditionalFormatting { /**
* A factory method allowing to create a conditional formatting rule with a formula.<br>
*
- * The formatting rules are applied by Excel when the value of the formula not equal to 0.
- *
+ * The formatting rules are applied by Excel when the value of the formula not equal to 0.<p/>
+ * TODO - formulas containing cell references are currently not parsed properly
* @param formula - formula for the valued, compared with the cell
*/
public HSSFConditionalFormattingRule createConditionalFormattingRule(String formula) {
|