aboutsummaryrefslogtreecommitdiffstats
path: root/src/java/org/apache/poi/hssf
Commit message (Collapse)AuthorAgeFilesLines
* 65206 - Migrate ant / maven to gradle buildAndreas Beeker2021-03-27356-77908/+0
| | | | | | | | update gradle files and project structure along https://github.com/centic9/poi/tree/gradle_build remove eclipse IDE project files remove obsolete record generator files git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888111 13f79535-47bb-0310-9956-ffa450edef68
* #65192 - Allow change of EncryptionModeAndreas Beeker2021-03-171-0/+42
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887764 13f79535-47bb-0310-9956-ffa450edef68
* Try to fix sonar buildAndreas Beeker2021-03-143-0/+3
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887659 13f79535-47bb-0310-9956-ffa450edef68
* Deprecate functions that duplicate functionalityMarius Volkhart2021-03-014-5/+18
| | | | | | DrawingGroupRecord#processChildRecords and AbstractEscherHolderRecord#convertRawBytesToEscherRecords duplicate the functionality of AbstractEscherHolderRecord#decode. This makes the code harder to follow, as it is not clear when certain access patterns repeat. Accordingly, these functions are deprecated and flagged for removal. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887021 13f79535-47bb-0310-9956-ffa450edef68
* Review EscherContainerRecord#getChildRecords() call sites for unnecessary workMarius Volkhart2021-03-013-6/+6
| | | | | | | | This started off as wanting to add the EscherContainerRecord#getChildCount() function in order to do an efficient check for how many children the container has. This was desirable in new code for editing HSSF pictures. The existing option of calling getChildRecords().size() was undesirable as this requires a list copy first. In the process of finding call sites that would benefit from replacing getChildRecords().size(), I realized that several other patterns would benefit from eliminating a copy, such as iterating over the children in a for-each loop, and indexed access to specific children. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887020 13f79535-47bb-0310-9956-ffa450edef68
* Replace magic constant use of Escher Blip Start type ID with referenceMarius Volkhart2021-02-271-1/+1
| | | | | | Instead of referring to the magic constant 0xF018, reference the value in the EscherRecordTypes enum. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886987 13f79535-47bb-0310-9956-ffa450edef68
* Fix bug with record indexes for HSSF WorkbooksMarius Volkhart2021-02-272-2/+3
| | | | | | | | We have encountered workbooks that do not have a TabIdRecord (see 55982.xls). However, the WorkbookRecordList#updateRecordPos() method would still increment the position of the TabIdRecord for such workbooks. Changing the default position of the record from 0 to -1 indicates that the record position has now been set. This bug was discovered while adding support for editing pictures in HSSF documents. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886963 13f79535-47bb-0310-9956-ffa450edef68
* [bug-63046] Use Log4j 2 for loggingMarius Volkhart2021-02-2131-354/+347
| | | | | | | | | | This removes the POILogger and POILogFactory mechanism for logging. This mechanism was created at a time when the Java landscape looked very different than it does today. Log4j 2 is an Apache Foundation project that is well maintained and is widely regarded as having good performance and capabilities. We use only the Log4j API artifact. This lets application developers choose how they want to capture logging events if at all. Integrations with Log4j 2 Core and Logback are available from the Log4j project. Closes #224 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886770 13f79535-47bb-0310-9956-ffa450edef68
* Code cleanup AbstractEscherHolderRecordMarius Volkhart2021-02-171-21/+21
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886623 13f79535-47bb-0310-9956-ffa450edef68
* Add documentation for DrawingGroupRecordMarius Volkhart2021-02-171-1/+9
| | | | | | Documentation adapted from [MS-XLS].pdf v20190618. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886619 13f79535-47bb-0310-9956-ffa450edef68
* Fix inconsistent logging statementMarius Volkhart2021-02-011-1/+1
| | | | | | The conditions check for max, but the logging was copy/pasted and still uses the minimum. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886089 13f79535-47bb-0310-9956-ffa450edef68
* Sonar fixesAndreas Beeker2021-01-1732-148/+149
| | | | | | | constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' reorder "final static" -> "static final" git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885613 13f79535-47bb-0310-9956-ffa450edef68
* Properly close file handles in extractors and when handling ↵Dominik Stadler2021-01-073-1/+34
| | | | | | password-protected files git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885229 13f79535-47bb-0310-9956-ffa450edef68
* Adjust some JavaDocDominik Stadler2020-12-291-2/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884918 13f79535-47bb-0310-9956-ffa450edef68
* Improve the speed of the styles-optimiser when there are many styles in a ↵Dominik Stadler2020-12-291-28/+36
| | | | | | | | | | | | | Workbook Profiling showed that the call to isUserDefined() took most of the time, so we now fetch this only once for each style and remember the result and use it in the inner loop. The attached sample-file took aprox. 1m30s on a decent machine, now it is down to around 2s. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884917 13f79535-47bb-0310-9956-ffa450edef68
* Sonar fixesAndreas Beeker2020-12-268-38/+56
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884807 13f79535-47bb-0310-9956-ffa450edef68
* [github-208] Fix a few instances of incorrect NotImplemented documentation. ↵PJ Fanning2020-12-171-24/+13
| | | | | | Thanks to Marius Volkhart. This closes #208 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884575 13f79535-47bb-0310-9956-ffa450edef68
* avoid string concatsPJ Fanning2020-12-173-5/+5
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884574 13f79535-47bb-0310-9956-ffa450edef68
* avoid string concatsPJ Fanning2020-12-174-16/+10
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884573 13f79535-47bb-0310-9956-ffa450edef68
* avoid string concatsPJ Fanning2020-12-175-14/+14
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884572 13f79535-47bb-0310-9956-ffa450edef68
* [bug-64972] HSSFPictureData#getPictureType() should return 0 for unknown ↵PJ Fanning2020-12-091-1/+1
| | | | | | picture type (to be consistent with other implementations) git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884271 13f79535-47bb-0310-9956-ffa450edef68
* [bug-64972] HSSFPictureData#getPictureType() should return 0 for unknown ↵PJ Fanning2020-12-091-2/+3
| | | | | | picture type (to be consistent with other implementations) git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884270 13f79535-47bb-0310-9956-ffa450edef68
* remove more deprecated code (fix some issues)PJ Fanning2020-12-091-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884265 13f79535-47bb-0310-9956-ffa450edef68
* remove more deprecated codePJ Fanning2020-12-092-15/+7
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884263 13f79535-47bb-0310-9956-ffa450edef68
* remove more deprecated codePJ Fanning2020-12-0916-184/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884262 13f79535-47bb-0310-9956-ffa450edef68
* remove more deprecated codePJ Fanning2020-12-091-3/+3
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884259 13f79535-47bb-0310-9956-ffa450edef68
* remove more deprecated codePJ Fanning2020-12-094-135/+7
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884257 13f79535-47bb-0310-9956-ffa450edef68
* remove more deprecated codePJ Fanning2020-12-0935-454/+8
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884256 13f79535-47bb-0310-9956-ffa450edef68
* remove some deprecated codePJ Fanning2020-12-092-37/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884229 13f79535-47bb-0310-9956-ffa450edef68
* remove some deprecated codePJ Fanning2020-12-0918-200/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884228 13f79535-47bb-0310-9956-ffa450edef68
* remove some deprecated codePJ Fanning2020-12-099-100/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884227 13f79535-47bb-0310-9956-ffa450edef68
* remove some deprecated codePJ Fanning2020-12-0949-446/+2
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884226 13f79535-47bb-0310-9956-ffa450edef68
* remove some deprecated codePJ Fanning2020-12-08108-381/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884223 13f79535-47bb-0310-9956-ffa450edef68
* [bug-64964] HSSFCell.convertCellValueToBoolean shall throw more specific ↵PJ Fanning2020-12-081-1/+3
| | | | | | exception git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884210 13f79535-47bb-0310-9956-ffa450edef68
* remove some deprecated codePJ Fanning2020-12-061-1/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884158 13f79535-47bb-0310-9956-ffa450edef68
* Apply patch for bug 64791 to use proper position for the WriteAccessRecordDominik Stadler2020-10-251-1/+2
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1882829 13f79535-47bb-0310-9956-ffa450edef68
* Apply some IDE suggestionsDominik Stadler2020-10-251-7/+7
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1882828 13f79535-47bb-0310-9956-ffa450edef68
* Sonar fixes - a few "Try-with-resources should be used"Andreas Beeker2020-10-241-19/+12
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1882820 13f79535-47bb-0310-9956-ffa450edef68
* [bug-64721] NullPointerException occurs when calling getDataSize() of an ↵PJ Fanning2020-09-091-0/+1
| | | | | | object created with ExtRst.copy(). Thanks to Kwon Ohyoung git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1881582 13f79535-47bb-0310-9956-ffa450edef68
* Update library versionsAndreas Beeker2020-08-181-2/+4
| | | | | | | Replace deprecated junit @Rules with assertThrows Adapt to XMLSec refactoring in version 2.2.0 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1880965 13f79535-47bb-0310-9956-ffa450edef68
* #64036 - Replace reflection calls in factories for Java 9+Andreas Beeker2020-08-171-0/+6
| | | | | | provide EvalutionWorkbook in HSSF/XSSF/SXSSF git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1880925 13f79535-47bb-0310-9956-ffa450edef68
* #64411 - Provide JigSaw modulesAndreas Beeker2020-08-133-27/+94
| | | | | | - rework extractors - see bugzilla entry for more information git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1880839 13f79535-47bb-0310-9956-ffa450edef68
* #64411 - Provide JigSaw modulesAndreas Beeker2020-07-222-12/+53
| | | | | | | | | | | | | | | - use classpath-build for Java 8, otherwise use modulepath - save module-info classes to source, when using Java 9+ environment - rename example packages - otherwise package clashes occured in the tests - move agile encryption from ooxml to main. remove EncryptionInfo XmlBeans and schema and use custom xml marshalling - move ooxml test classes which reside in the same package as their tested main class - rename base test classes to "BaseTest..." - temporarily I've used a light version of the main test classes to test scratchpad / ooxml - build.xml - fixed the Rhino javascript errors of the dependency-macros - DrawTextParagraph - fixed StringIndexOutOfBounds when logging set to debug level - use JigSaw provider interface (= Java ServiceLoader), i.e. it wasn't possible (without openening everything), to access ooxml factory classes from main factory stub git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1880164 13f79535-47bb-0310-9956-ffa450edef68
* remove some deprecated codePJ Fanning2020-07-151-23/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879911 13f79535-47bb-0310-9956-ffa450edef68
* remove some deprecated codePJ Fanning2020-07-151-14/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879909 13f79535-47bb-0310-9956-ffa450edef68
* remove some more deprecated codePJ Fanning2020-06-282-192/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879299 13f79535-47bb-0310-9956-ffa450edef68
* remove some more deprecated codePJ Fanning2020-06-281-37/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879298 13f79535-47bb-0310-9956-ffa450edef68
* remove some deprecated classesPJ Fanning2020-06-271-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879269 13f79535-47bb-0310-9956-ffa450edef68
* update deprecation versionPJ Fanning2020-06-271-1/+2
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879268 13f79535-47bb-0310-9956-ffa450edef68
* remove some deprecated methods from CellPJ Fanning2020-06-271-16/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879266 13f79535-47bb-0310-9956-ffa450edef68