summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGo MAEDA <maeda@farend.jp>2020-03-24 12:16:06 +0000
committerGo MAEDA <maeda@farend.jp>2020-03-24 12:16:06 +0000
commit1473996f92fd8e77af4736353bcb0190e79b144d (patch)
treec64f5c736d8bbb54af95a33816a382cc6607a497
parent64abc4bd85489db63943a13eb6f418cb53220776 (diff)
downloadredmine-1473996f92fd8e77af4736353bcb0190e79b144d.tar.gz
redmine-1473996f92fd8e77af4736353bcb0190e79b144d.zip
Export to PDF fails when subject of parent task is included in issue list (#33103).
Patch by Marius BALTEANU and Yuichi HARADA. git-svn-id: http://svn.redmine.org/redmine/trunk@19611 e93f8b46-1217-0410-a6f0-8f06a7374b81
-rw-r--r--lib/redmine/export/pdf/issues_pdf_helper.rb2
-rw-r--r--test/unit/lib/redmine/export/pdf/issues_pdf_test.rb11
2 files changed, 12 insertions, 1 deletions
diff --git a/lib/redmine/export/pdf/issues_pdf_helper.rb b/lib/redmine/export/pdf/issues_pdf_helper.rb
index 2f73e52a4..b49691695 100644
--- a/lib/redmine/export/pdf/issues_pdf_helper.rb
+++ b/lib/redmine/export/pdf/issues_pdf_helper.rb
@@ -379,7 +379,7 @@ module Redmine
cv = issue.visible_custom_field_values.detect {|v| v.custom_field_id == column.custom_field.id}
show_value(cv, false)
else
- value = issue.send(column.name)
+ value = column.value_object(issue)
case column.name
when :subject
value = " " * level + value
diff --git a/test/unit/lib/redmine/export/pdf/issues_pdf_test.rb b/test/unit/lib/redmine/export/pdf/issues_pdf_test.rb
index c9e4e4863..07b246424 100644
--- a/test/unit/lib/redmine/export/pdf/issues_pdf_test.rb
+++ b/test/unit/lib/redmine/export/pdf/issues_pdf_test.rb
@@ -36,4 +36,15 @@ class IssuesPdfHelperTest < ActiveSupport::TestCase
results = fetch_row_values(issue, query, 0)
assert_equal ["2", "Add ingredients categories", "4.34"], results
end
+
+ def test_fetch_row_values_should_be_able_to_handle_parent_issue_subject
+ query = IssueQuery.new(:project => Project.find(1), :name => '_')
+ query.column_names = [:subject, 'parent.subject']
+ issue = Issue.find(2)
+ issue.parent = Issue.find(1)
+ issue.save!
+
+ results = fetch_row_values(issue, query, 0)
+ assert_equal ['2', 'Add ingredients categories', 'Cannot print recipes'], results
+ end
end