summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorToshi MARUYAMA <marutosijp2@yahoo.co.jp>2019-10-07 11:44:54 +0000
committerToshi MARUYAMA <marutosijp2@yahoo.co.jp>2019-10-07 11:44:54 +0000
commit21cc761b539817f9c60dba119e49b4a9842d2d90 (patch)
tree9d87707bf0ba4f7282de093bf25f6baf3c0ecb2a
parent6972d7e982d1383b091a6b0331983c722e687947 (diff)
downloadredmine-21cc761b539817f9c60dba119e49b4a9842d2d90.tar.gz
redmine-21cc761b539817f9c60dba119e49b4a9842d2d90.zip
use "attr_reader" instead of "attr_accessor" for CustomFieldValue#value
CustomFieldValue#value= is already defined in this class. git-svn-id: http://svn.redmine.org/redmine/trunk@18615 e93f8b46-1217-0410-a6f0-8f06a7374b81
-rw-r--r--.rubocop_todo.yml1
-rw-r--r--app/models/custom_field_value.rb3
2 files changed, 2 insertions, 2 deletions
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index b2aee54e2..cbaa842b8 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -495,7 +495,6 @@ Lint/DeprecatedClassMethods:
Lint/DuplicateMethods:
Exclude:
- - 'app/models/custom_field_value.rb'
- 'app/models/query.rb'
- 'app/models/wiki_page.rb'
diff --git a/app/models/custom_field_value.rb b/app/models/custom_field_value.rb
index aa2e66145..8e4cda92a 100644
--- a/app/models/custom_field_value.rb
+++ b/app/models/custom_field_value.rb
@@ -18,7 +18,8 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
class CustomFieldValue
- attr_accessor :custom_field, :customized, :value, :value_was
+ attr_accessor :custom_field, :customized, :value_was
+ attr_reader :value
def initialize(attributes={})
attributes.each do |name, v|