diff options
| author | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2018-09-23 14:55:35 +0000 |
|---|---|---|
| committer | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2018-09-23 14:55:35 +0000 |
| commit | 5282a45b9b8eb39a25416cf270ca423db485a976 (patch) | |
| tree | bc7b7f631520f677a5f5148b5cfe0ba8c194c8fc | |
| parent | 7d7e44ba9cb3c6a4b6a8549a8cf253b789fc85ae (diff) | |
| download | redmine-5282a45b9b8eb39a25416cf270ca423db485a976.tar.gz redmine-5282a45b9b8eb39a25416cf270ca423db485a976.zip | |
Link to user in wiki syntax only works when login is written in lower case (#26892).
Patch by Marius BALTEANU and Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17516 e93f8b46-1217-0410-a6f0-8f06a7374b81
| -rw-r--r-- | app/helpers/application_helper.rb | 6 | ||||
| -rw-r--r-- | test/helpers/application_helper_test.rb | 2 |
2 files changed, 5 insertions, 3 deletions
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 419287533..62987ca29 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -1025,12 +1025,12 @@ module ApplicationHelper link = link_to_project(p, {:only_path => only_path}, :class => 'project') end when 'user' - u = User.visible.where(:login => name, :type => 'User').first + u = User.visible.where("LOWER(login) = :s AND type = 'User'", :s => name.downcase).first link = link_to_user(u, :only_path => only_path) if u end elsif sep == "@" name = remove_double_quotes(identifier) - u = User.visible.where(:login => name, :type => 'User').first + u = User.visible.where("LOWER(login) = :s AND type = 'User'", :s => name.downcase).first link = link_to_user(u, :only_path => only_path) if u end end @@ -1067,7 +1067,7 @@ module ApplicationHelper )| ( (?<sep4>@) - (?<identifier3>[a-z0-9_\-@\.]*) + (?<identifier3>[A-Za-z0-9_\-@\.]*) ) ) (?= diff --git a/test/helpers/application_helper_test.rb b/test/helpers/application_helper_test.rb index fd0886c80..d4990d39f 100644 --- a/test/helpers/application_helper_test.rb +++ b/test/helpers/application_helper_test.rb @@ -403,8 +403,10 @@ RAW "http://foo.bar/FAQ#3" => '<a class="external" href="http://foo.bar/FAQ#3">http://foo.bar/FAQ#3</a>', # user 'user:jsmith' => link_to_user(User.find_by_id(2)), + 'user:JSMITH' => link_to_user(User.find_by_id(2)), 'user#2' => link_to_user(User.find_by_id(2)), '@jsmith' => link_to_user(User.find_by_id(2)), + '@JSMITH' => link_to_user(User.find_by_id(2)), '@abcd@example.com' => link_to_user(User.find_by_id(u_email_id)), 'user:abcd@example.com' => link_to_user(User.find_by_id(u_email_id)), '@foo.bar@example.com' => link_to_user(User.find_by_id(u_email_id_2)), |