summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGo MAEDA <maeda@farend.jp>2024-08-12 07:51:45 +0000
committerGo MAEDA <maeda@farend.jp>2024-08-12 07:51:45 +0000
commit79873291d724025b2082f1d42cabc5c4504c5e0e (patch)
tree29a68a1097c9592093c4b11ca677a74a10ca52d7
parent74e2262efb366a37a70f64dc0faec2d63086b9e5 (diff)
downloadredmine-79873291d724025b2082f1d42cabc5c4504c5e0e.tar.gz
redmine-79873291d724025b2082f1d42cabc5c4504c5e0e.zip
Fix RuboCop offense Layout/EmptyLinesAroundModuleBody, one of the offenses enabled in rubocop-rails-omakase (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22951 e93f8b46-1217-0410-a6f0-8f06a7374b81
-rw-r--r--.rubocop_todo.yml23
-rw-r--r--app/helpers/attachments_helper.rb1
-rw-r--r--app/helpers/custom_fields_helper.rb1
-rw-r--r--app/helpers/email_addresses_helper.rb1
-rw-r--r--app/helpers/journals_helper.rb1
-rw-r--r--app/helpers/reports_helper.rb1
-rw-r--r--app/helpers/routes_helper.rb1
-rw-r--r--app/helpers/timelog_helper.rb1
-rw-r--r--app/helpers/trackers_helper.rb1
-rw-r--r--app/helpers/watchers_helper.rb1
-rw-r--r--lib/redmine/access_control.rb1
-rw-r--r--lib/redmine/activity.rb1
-rw-r--r--lib/redmine/codeset_util.rb1
-rw-r--r--lib/redmine/configuration.rb1
-rw-r--r--lib/redmine/helpers/calendar.rb1
-rw-r--r--lib/redmine/mime_type.rb1
-rw-r--r--lib/redmine/plugin.rb1
-rw-r--r--lib/redmine/search.rb1
18 files changed, 0 insertions, 40 deletions
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 0c325bb69..cdd5ade40 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -53,29 +53,6 @@ Layout/EmptyLinesAroundExceptionHandlingKeywords:
- 'test/functional/settings_controller_test.rb'
# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
-Layout/EmptyLinesAroundModuleBody:
- Exclude:
- - 'app/helpers/attachments_helper.rb'
- - 'app/helpers/custom_fields_helper.rb'
- - 'app/helpers/email_addresses_helper.rb'
- - 'app/helpers/journals_helper.rb'
- - 'app/helpers/reports_helper.rb'
- - 'app/helpers/routes_helper.rb'
- - 'app/helpers/timelog_helper.rb'
- - 'app/helpers/trackers_helper.rb'
- - 'app/helpers/watchers_helper.rb'
- - 'lib/redmine/access_control.rb'
- - 'lib/redmine/activity.rb'
- - 'lib/redmine/codeset_util.rb'
- - 'lib/redmine/configuration.rb'
- - 'lib/redmine/helpers/calendar.rb'
- - 'lib/redmine/mime_type.rb'
- - 'lib/redmine/plugin.rb'
- - 'lib/redmine/search.rb'
-
-# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
Layout/ExtraSpacing:
Enabled: false
diff --git a/app/helpers/attachments_helper.rb b/app/helpers/attachments_helper.rb
index cf534fdfe..785f833c6 100644
--- a/app/helpers/attachments_helper.rb
+++ b/app/helpers/attachments_helper.rb
@@ -18,7 +18,6 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
module AttachmentsHelper
-
def container_attachments_edit_path(container)
object_attachments_edit_path container.class.name.underscore.pluralize, container.id
end
diff --git a/app/helpers/custom_fields_helper.rb b/app/helpers/custom_fields_helper.rb
index a6149909d..f59a8f4cd 100644
--- a/app/helpers/custom_fields_helper.rb
+++ b/app/helpers/custom_fields_helper.rb
@@ -18,7 +18,6 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
module CustomFieldsHelper
-
CUSTOM_FIELDS_TABS = [
{:name => 'IssueCustomField', :partial => 'custom_fields/index',
:label => :label_issue_plural},
diff --git a/app/helpers/email_addresses_helper.rb b/app/helpers/email_addresses_helper.rb
index 4edd8835b..06ea8f0a1 100644
--- a/app/helpers/email_addresses_helper.rb
+++ b/app/helpers/email_addresses_helper.rb
@@ -18,7 +18,6 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
module EmailAddressesHelper
-
# Returns a link to enable or disable notifications for the address
def toggle_email_address_notify_link(address)
if address.notify?
diff --git a/app/helpers/journals_helper.rb b/app/helpers/journals_helper.rb
index 5c5b69131..d5c996d87 100644
--- a/app/helpers/journals_helper.rb
+++ b/app/helpers/journals_helper.rb
@@ -18,7 +18,6 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
module JournalsHelper
-
# Returns the attachments of a journal that are displayed as thumbnails
def journal_thumbnail_attachments(journal)
journal.attachments.select(&:thumbnailable?)
diff --git a/app/helpers/reports_helper.rb b/app/helpers/reports_helper.rb
index bd0da005f..d49b43f4e 100644
--- a/app/helpers/reports_helper.rb
+++ b/app/helpers/reports_helper.rb
@@ -18,7 +18,6 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
module ReportsHelper
-
def aggregate(data, criteria)
a = 0
data.each do |row|
diff --git a/app/helpers/routes_helper.rb b/app/helpers/routes_helper.rb
index 369b14c4b..f5d6dbd38 100644
--- a/app/helpers/routes_helper.rb
+++ b/app/helpers/routes_helper.rb
@@ -18,7 +18,6 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
module RoutesHelper
-
# Returns the path to project issues or to the cross-project
# issue list if project is nil
def _project_issues_path(project, *args)
diff --git a/app/helpers/timelog_helper.rb b/app/helpers/timelog_helper.rb
index 92104495c..a03f9c701 100644
--- a/app/helpers/timelog_helper.rb
+++ b/app/helpers/timelog_helper.rb
@@ -146,5 +146,4 @@ module TimelogHelper
fallback_path = project ? project_time_entries_path(project) : time_entries_path
cancel_button_tag(fallback_path)
end
-
end
diff --git a/app/helpers/trackers_helper.rb b/app/helpers/trackers_helper.rb
index 418914703..8bceac655 100644
--- a/app/helpers/trackers_helper.rb
+++ b/app/helpers/trackers_helper.rb
@@ -18,7 +18,6 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
module TrackersHelper
-
def tracker_name_tag(tracker)
title = tracker.description.presence
css = title ? "field-description" : nil
diff --git a/app/helpers/watchers_helper.rb b/app/helpers/watchers_helper.rb
index c9d14d95f..8afd5af31 100644
--- a/app/helpers/watchers_helper.rb
+++ b/app/helpers/watchers_helper.rb
@@ -18,7 +18,6 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
module WatchersHelper
-
def watcher_link(objects, user)
return '' unless user && user.logged?
diff --git a/lib/redmine/access_control.rb b/lib/redmine/access_control.rb
index fdc051edd..ee59bdd7b 100644
--- a/lib/redmine/access_control.rb
+++ b/lib/redmine/access_control.rb
@@ -19,7 +19,6 @@
module Redmine
module AccessControl
-
class << self
def map
mapper = Mapper.new
diff --git a/lib/redmine/activity.rb b/lib/redmine/activity.rb
index b758431ed..0df7c6096 100644
--- a/lib/redmine/activity.rb
+++ b/lib/redmine/activity.rb
@@ -19,7 +19,6 @@
module Redmine
module Activity
-
mattr_accessor :available_event_types, :default_event_types, :providers
@@available_event_types = []
diff --git a/lib/redmine/codeset_util.rb b/lib/redmine/codeset_util.rb
index b26e0ad04..04284e194 100644
--- a/lib/redmine/codeset_util.rb
+++ b/lib/redmine/codeset_util.rb
@@ -19,7 +19,6 @@
module Redmine
module CodesetUtil
-
def self.replace_invalid_utf8(str)
return nil if str.nil?
diff --git a/lib/redmine/configuration.rb b/lib/redmine/configuration.rb
index 4fdd29184..b1ce9e374 100644
--- a/lib/redmine/configuration.rb
+++ b/lib/redmine/configuration.rb
@@ -21,7 +21,6 @@ require 'redmine'
module Redmine
module Configuration
-
# Configuration default values
@defaults = {
'avatar_server_url' => 'https://www.gravatar.com',
diff --git a/lib/redmine/helpers/calendar.rb b/lib/redmine/helpers/calendar.rb
index 618e9fbf0..69ed62b05 100644
--- a/lib/redmine/helpers/calendar.rb
+++ b/lib/redmine/helpers/calendar.rb
@@ -19,7 +19,6 @@
module Redmine
module Helpers
-
# Simple class to compute the start and end dates of a calendar
class Calendar
include Redmine::I18n
diff --git a/lib/redmine/mime_type.rb b/lib/redmine/mime_type.rb
index a97994ad5..5554cc5a9 100644
--- a/lib/redmine/mime_type.rb
+++ b/lib/redmine/mime_type.rb
@@ -19,7 +19,6 @@
module Redmine
module MimeType
-
MIME_TYPES = {
'text/plain' => 'txt,tpl,properties,patch,diff,ini,readme,install,upgrade,sql',
'text/css' => 'css',
diff --git a/lib/redmine/plugin.rb b/lib/redmine/plugin.rb
index 3e442cd12..7ea6bfada 100644
--- a/lib/redmine/plugin.rb
+++ b/lib/redmine/plugin.rb
@@ -18,7 +18,6 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
module Redmine
-
# Exception raised when a plugin cannot be found given its id.
class PluginNotFound < StandardError; end
diff --git a/lib/redmine/search.rb b/lib/redmine/search.rb
index 6c3ee835c..088ad5785 100644
--- a/lib/redmine/search.rb
+++ b/lib/redmine/search.rb
@@ -19,7 +19,6 @@
module Redmine
module Search
-
mattr_accessor :available_search_types
@@available_search_types = []