diff options
| author | Go MAEDA <maeda@farend.jp> | 2025-01-21 08:58:17 +0000 |
|---|---|---|
| committer | Go MAEDA <maeda@farend.jp> | 2025-01-21 08:58:17 +0000 |
| commit | 880e7a50b2bce481735e1bdec97580378dd633db (patch) | |
| tree | e9ae53876ea87424f22a60ed9437398797ecd6b1 | |
| parent | 7ca4cf24c067b8f733bd3000269019c034965b75 (diff) | |
| download | redmine-880e7a50b2bce481735e1bdec97580378dd633db.tar.gz redmine-880e7a50b2bce481735e1bdec97580378dd633db.zip | |
Fix rapid flickering of placeholder icon for non-existent thumbnails on hover (#42084).
Patch by Mizuki ISHIKAWA (user:ishikawa999).
git-svn-id: https://svn.redmine.org/redmine/trunk@23452 e93f8b46-1217-0410-a6f0-8f06a7374b81
| -rw-r--r-- | app/helpers/application_helper.rb | 1 | ||||
| -rw-r--r-- | test/helpers/application_helper_test.rb | 4 |
2 files changed, 3 insertions, 2 deletions
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 3174261a9..c7ed1bf97 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -352,6 +352,7 @@ module ApplicationHelper :srcset => "#{thumbnail_path} 2x", :style => "max-width: #{thumbnail_size}px; max-height: #{thumbnail_size}px;", :title => attachment.filename, + :alt => attachment.filename, :loading => "lazy" ), attachment_path( diff --git a/test/helpers/application_helper_test.rb b/test/helpers/application_helper_test.rb index 31c87daea..dc52bf758 100644 --- a/test/helpers/application_helper_test.rb +++ b/test/helpers/application_helper_test.rb @@ -1921,8 +1921,8 @@ class ApplicationHelperTest < Redmine::HelperTest a = Attachment.find(3) assert_select_in( thumbnail_tag(a), - 'a[href=?] img[title=?][src=?][loading="lazy"]', - "/attachments/3", "logo.gif", "/attachments/thumbnail/3/200") + 'a[href=?] img[title=?][alt=?][src=?][loading="lazy"]', + "/attachments/3", "logo.gif", "logo.gif", "/attachments/thumbnail/3/200") end def test_link_to_project |