summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJean-Philippe Lang <jp_lang@yahoo.fr>2014-02-06 17:58:24 +0000
committerJean-Philippe Lang <jp_lang@yahoo.fr>2014-02-06 17:58:24 +0000
commita11aec0d4c9543ed310085914ac24144f325a608 (patch)
tree1e6fd56c47484abc5eed9385dc23bfbec501fede
parenta9f44b323ffef53d3904b16dc9116aba3db7514c (diff)
downloadredmine-a11aec0d4c9543ed310085914ac24144f325a608.tar.gz
redmine-a11aec0d4c9543ed310085914ac24144f325a608.zip
Merged r12660 (#13544).
git-svn-id: http://svn.redmine.org/redmine/branches/2.4-stable@12845 e93f8b46-1217-0410-a6f0-8f06a7374b81
-rw-r--r--app/models/changeset.rb11
-rw-r--r--test/unit/changeset_test.rb10
2 files changed, 16 insertions, 5 deletions
diff --git a/app/models/changeset.rb b/app/models/changeset.rb
index ff210e9b8..3d52df2bd 100644
--- a/app/models/changeset.rb
+++ b/app/models/changeset.rb
@@ -154,13 +154,14 @@ class Changeset < ActiveRecord::Base
end
def text_tag(ref_project=nil)
+ repo = ""
+ if repository && repository.identifier.present?
+ repo = "#{repository.identifier}|"
+ end
tag = if scmid?
- "commit:#{scmid}"
+ "commit:#{repo}#{scmid}"
else
- "r#{revision}"
- end
- if repository && repository.identifier.present?
- tag = "#{repository.identifier}|#{tag}"
+ "#{repo}r#{revision}"
end
if ref_project && project && ref_project != project
tag = "#{project.identifier}:#{tag}"
diff --git a/test/unit/changeset_test.rb b/test/unit/changeset_test.rb
index 0eea5f88b..d2db5e4fb 100644
--- a/test/unit/changeset_test.rb
+++ b/test/unit/changeset_test.rb
@@ -345,6 +345,16 @@ class ChangesetTest < ActiveSupport::TestCase
assert_equal 'commit:0123456789', c.text_tag
end
+ def test_text_tag_hash_with_repository_identifier
+ r = Repository::Subversion.new(
+ :project_id => 1,
+ :url => 'svn://localhost/test',
+ :identifier => 'documents')
+ c = Changeset.new(:revision => '7234cb27', :scmid => '7234cb27', :repository => r)
+ assert_equal 'commit:documents|7234cb27', c.text_tag
+ assert_equal 'ecookbook:commit:documents|7234cb27', c.text_tag(Project.find(2))
+ end
+
def test_previous
changeset = Changeset.find_by_revision('3')
assert_equal Changeset.find_by_revision('2'), changeset.previous