summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGo MAEDA <maeda@farend.jp>2024-06-13 03:06:04 +0000
committerGo MAEDA <maeda@farend.jp>2024-06-13 03:06:04 +0000
commitaf6a627d205fba99a8bda29b0e0bfea0a766506e (patch)
tree1129ace4f09b4a135a94a5cc89d8e17b80033c23
parentb803bddb1f32842b0a5ec93640778d902b5f7999 (diff)
downloadredmine-af6a627d205fba99a8bda29b0e0bfea0a766506e.tar.gz
redmine-af6a627d205fba99a8bda29b0e0bfea0a766506e.zip
Revisions count is wrong on the wiki content page (#40655).
Contributed by Karel Pičman (@picman). git-svn-id: https://svn.redmine.org/redmine/trunk@22877 e93f8b46-1217-0410-a6f0-8f06a7374b81
-rw-r--r--app/views/wiki/show.html.erb2
-rw-r--r--test/functional/wiki_controller_test.rb14
2 files changed, 15 insertions, 1 deletions
diff --git a/app/views/wiki/show.html.erb b/app/views/wiki/show.html.erb
index 6a0245809..be0d7355a 100644
--- a/app/views/wiki/show.html.erb
+++ b/app/views/wiki/show.html.erb
@@ -85,7 +85,7 @@
<p class="wiki-update-info">
<% if User.current.allowed_to?(:view_wiki_edits, @project) %>
<%= wiki_content_update_info(@content) %>
- · <%= link_to l(:label_x_revisions, :count => @content.version), {:action => 'history', :id => @page.title} %>
+ · <%= link_to l(:label_x_revisions, :count => @page.content.versions.size), {:action => 'history', :id => @page.title} %>
<% end %>
<% if @page.protected? %>
<span class="badge badge-status-locked"><%= l('status_locked') %></span>
diff --git a/test/functional/wiki_controller_test.rb b/test/functional/wiki_controller_test.rb
index d7e9676f8..be62dcc8e 100644
--- a/test/functional/wiki_controller_test.rb
+++ b/test/functional/wiki_controller_test.rb
@@ -233,6 +233,20 @@ class WikiControllerTest < Redmine::ControllerTest
end
end
+ def test_show_should_display_revisions_count
+ # To ensure that the number of versions is correctly displayed instead of
+ # the last version number of the wiki page, make a situation where the
+ # those two numbers are different.
+ content_versions = WikiContentVersion.where(page_id: 1)
+ content_versions.first.destroy
+ assert 3, content_versions.last.version
+ assert 2, content_versions.size
+
+ get :show, :params => {:project_id => 1, :id => 'CookBook_documentation'}
+ assert_response :success
+ assert_select 'a[href=?]', '/projects/1/wiki/CookBook_documentation/history', :text => /2 revisions/
+ end
+
def test_get_new
@request.session[:user_id] = 2