diff options
author | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2008-06-08 18:10:49 +0000 |
---|---|---|
committer | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2008-06-08 18:10:49 +0000 |
commit | e833cab30e19b5c9d17db405660f081923482f11 (patch) | |
tree | f930999b228ed572eeb1e7d5f71e71f7f041aa81 | |
parent | b78b62df8d1fd34321cffd3785121da98f64265b (diff) | |
download | redmine-e833cab30e19b5c9d17db405660f081923482f11.tar.gz redmine-e833cab30e19b5c9d17db405660f081923482f11.zip |
Move diff viewer to a partial.
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1515 e93f8b46-1217-0410-a6f0-8f06a7374b81
-rw-r--r-- | app/views/common/_diff.rhtml | 74 | ||||
-rw-r--r-- | app/views/repositories/diff.rhtml | 71 |
2 files changed, 75 insertions, 70 deletions
diff --git a/app/views/common/_diff.rhtml b/app/views/common/_diff.rhtml new file mode 100644 index 000000000..c849b7ff7 --- /dev/null +++ b/app/views/common/_diff.rhtml @@ -0,0 +1,74 @@ +<% Redmine::UnifiedDiff.new(diff, diff_type).each do |table_file| -%> +<div class="autoscroll"> +<% if diff_type == 'sbs' -%> +<table class="filecontent CodeRay"> +<thead> +<tr><th colspan="4" class="filename"><%= table_file.file_name %></th></tr> +<% unless @rev.nil? -%> +<tr> + <th colspan="2">@<%= format_revision @rev %></th> + <th colspan="2">@<%= format_revision @rev_to %></th> +</tr> +<% end -%> +</thead> +<tbody> +<% prev_line_left, prev_line_right = nil, nil -%> +<% table_file.keys.sort.each do |key| -%> +<% if prev_line_left && prev_line_right && (table_file[key].nb_line_left != prev_line_left+1) && (table_file[key].nb_line_right != prev_line_right+1) -%> +<tr class="spacing"><td colspan="4"></td></tr> +<% end -%> +<tr> + <th class="line-num"><%= table_file[key].nb_line_left %></th> + <td class="line-code <%= table_file[key].type_diff_left %>"> + <pre><%=to_utf8 table_file[key].line_left %></pre> + </td> + <th class="line-num"><%= table_file[key].nb_line_right %></th> + <td class="line-code <%= table_file[key].type_diff_right %>"> + <pre><%=to_utf8 table_file[key].line_right %></pre> + </td> +</tr> +<% prev_line_left, prev_line_right = table_file[key].nb_line_left.to_i, table_file[key].nb_line_right.to_i -%> +<% end -%> +</tbody> +</table> + +<% else -%> +<table class="filecontent CodeRay"> +<thead> +<tr><th colspan="3" class="filename"><%= table_file.file_name %></th></tr> +<% unless @rev.nil? -%> +<tr> + <th>@<%= format_revision @rev %></th> + <th>@<%= format_revision @rev_to %></th> + <th></th> +</tr> +<% end -%> +</thead> +<tbody> +<% prev_line_left, prev_line_right = nil, nil -%> +<% table_file.keys.sort.each do |key, line| %> +<% if prev_line_left && prev_line_right && (table_file[key].nb_line_left != prev_line_left+1) && (table_file[key].nb_line_right != prev_line_right+1) -%> +<tr class="spacing"><td colspan="3"></td></tr> +<% end -%> +<tr> + <th class="line-num"><%= table_file[key].nb_line_left %></th> + <th class="line-num"><%= table_file[key].nb_line_right %></th> + <% if table_file[key].line_left.empty? -%> + <td class="line-code <%= table_file[key].type_diff_right %>"> + <pre><%=to_utf8 table_file[key].line_right %></pre> + </td> + <% else -%> + <td class="line-code <%= table_file[key].type_diff_left %>"> + <pre><%=to_utf8 table_file[key].line_left %></pre> + </td> + <% end -%> +</tr> +<% prev_line_left = table_file[key].nb_line_left.to_i if table_file[key].nb_line_left.to_i > 0 -%> +<% prev_line_right = table_file[key].nb_line_right.to_i if table_file[key].nb_line_right.to_i > 0 -%> +<% end -%> +</tbody> +</table> +<% end -%> + +</div> +<% end -%> diff --git a/app/views/repositories/diff.rhtml b/app/views/repositories/diff.rhtml index 802082740..52a5d6057 100644 --- a/app/views/repositories/diff.rhtml +++ b/app/views/repositories/diff.rhtml @@ -12,76 +12,7 @@ <% end %> <% cache(@cache_key) do -%> -<% Redmine::UnifiedDiff.new(@diff, @diff_type).each do |table_file| -%> -<div class="autoscroll"> -<% if @diff_type == 'sbs' -%> -<table class="filecontent CodeRay"> -<thead> -<tr><th colspan="4" class="filename"><%= table_file.file_name %></th></tr> -<tr> - <th colspan="2">@<%= format_revision @rev %></th> - <th colspan="2">@<%= format_revision @rev_to %></th> -</tr> -</thead> -<tbody> -<% prev_line_left, prev_line_right = nil, nil -%> -<% table_file.keys.sort.each do |key| -%> -<% if prev_line_left && prev_line_right && (table_file[key].nb_line_left != prev_line_left+1) && (table_file[key].nb_line_right != prev_line_right+1) -%> -<tr class="spacing"><td colspan="4"></td></tr> -<% end -%> -<tr> - <th class="line-num"><%= table_file[key].nb_line_left %></th> - <td class="line-code <%= table_file[key].type_diff_left %>"> - <pre><%=to_utf8 table_file[key].line_left %></pre> - </td> - <th class="line-num"><%= table_file[key].nb_line_right %></th> - <td class="line-code <%= table_file[key].type_diff_right %>"> - <pre><%=to_utf8 table_file[key].line_right %></pre> - </td> -</tr> -<% prev_line_left, prev_line_right = table_file[key].nb_line_left.to_i, table_file[key].nb_line_right.to_i -%> -<% end -%> -</tbody> -</table> - -<% else -%> -<table class="filecontent CodeRay"> -<thead> -<tr><th colspan="3" class="filename"><%= table_file.file_name %></th></tr> -<tr> - <th>@<%= format_revision @rev %></th> - <th>@<%= format_revision @rev_to %></th> - <th></th> -</tr> -</thead> -<tbody> -<% prev_line_left, prev_line_right = nil, nil -%> -<% table_file.keys.sort.each do |key, line| %> -<% if prev_line_left && prev_line_right && (table_file[key].nb_line_left != prev_line_left+1) && (table_file[key].nb_line_right != prev_line_right+1) -%> -<tr class="spacing"><td colspan="3"></td></tr> -<% end -%> -<tr> - <th class="line-num"><%= table_file[key].nb_line_left %></th> - <th class="line-num"><%= table_file[key].nb_line_right %></th> - <% if table_file[key].line_left.empty? -%> - <td class="line-code <%= table_file[key].type_diff_right %>"> - <pre><%=to_utf8 table_file[key].line_right %></pre> - </td> - <% else -%> - <td class="line-code <%= table_file[key].type_diff_left %>"> - <pre><%=to_utf8 table_file[key].line_left %></pre> - </td> - <% end -%> -</tr> -<% prev_line_left = table_file[key].nb_line_left.to_i if table_file[key].nb_line_left.to_i > 0 -%> -<% prev_line_right = table_file[key].nb_line_right.to_i if table_file[key].nb_line_right.to_i > 0 -%> -<% end -%> -</tbody> -</table> -<% end -%> - -</div> -<% end -%> +<%= render :partial => 'common/diff', :locals => {:diff => @diff, :diff_type => @diff_type} %> <% end -%> <p class="other-formats"> |