diff options
| author | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2016-05-07 10:42:22 +0000 |
|---|---|---|
| committer | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2016-05-07 10:42:22 +0000 |
| commit | ed50d42210eaf7ca216e9cd3a043b36aa68eb51d (patch) | |
| tree | fbc801683ee622f43e790ec6cf2785fd8f94a43c /app/models/issue.rb | |
| parent | 40c9c3e922e15ab7d88b5d06c60e51ed1ba40a7f (diff) | |
| download | redmine-ed50d42210eaf7ca216e9cd3a043b36aa68eb51d.tar.gz redmine-ed50d42210eaf7ca216e9cd3a043b36aa68eb51d.zip | |
Replace Date.today with User.current.today (#22320).
Depending on the offset between a user's configured timezone and the server
timezone, Date.today may be more or less often wrong from the user's
perspective, leading to things like issues marked as overdue too early or too
late, or yesterday / tomorrow being displayed / selected where 'today' is
intended.
A test case illustrating the problem with Issue#overdue? is included
Patch by Jens Kraemer.
git-svn-id: http://svn.redmine.org/redmine/trunk@15379 e93f8b46-1217-0410-a6f0-8f06a7374b81
Diffstat (limited to 'app/models/issue.rb')
| -rw-r--r-- | app/models/issue.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/app/models/issue.rb b/app/models/issue.rb index 7d7db13e1..0ee8ff3d3 100644 --- a/app/models/issue.rb +++ b/app/models/issue.rb @@ -807,14 +807,14 @@ class Issue < ActiveRecord::Base # Returns true if the issue is overdue def overdue? - due_date.present? && (due_date < Date.today) && !closed? + due_date.present? && (due_date < User.current.today) && !closed? end # Is the amount of work done less than it should for the due date def behind_schedule? return false if start_date.nil? || due_date.nil? done_date = start_date + ((due_date - start_date + 1) * done_ratio / 100).floor - return done_date <= Date.today + return done_date <= User.current.today end # Does this issue have children? |