diff options
author | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2018-10-06 13:08:52 +0000 |
---|---|---|
committer | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2018-10-06 13:08:52 +0000 |
commit | 015ca366341ba2fa9f1d7903907ddab19a87865f (patch) | |
tree | fce88f7a0fb880d3584352e255dfd420c3e798d6 /test/functional/issues_custom_fields_visibility_test.rb | |
parent | b41096d9d00b0eb4c9004936b4ed5f127ec3f2c4 (diff) | |
download | redmine-015ca366341ba2fa9f1d7903907ddab19a87865f.tar.gz redmine-015ca366341ba2fa9f1d7903907ddab19a87865f.zip |
Send individual emails for each mail recipient (#26791).
We are creating multipe mails per class notification event, one per
recipient, wrapped in a Mailer::MultiMessage object to send them all at
once.
We keep the existing interface of all class methods intended to be used
by external code the same as they were before, with one exception:
We provide additional recipient addresses in options[:recipients] for
Mailer.security_notification. Since the first-class recipients have to
be users to render individual mails for them, additional recipient
addresses have to be provided with some other channel.
By providing additional recipients in options[:recipients], we can solve
the use-case for address change notifications for users, which probably
is the only real use-case for having to use a plain email address
instead of a User as a notification recipient.
Patch by Holger Just and Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17583 e93f8b46-1217-0410-a6f0-8f06a7374b81
Diffstat (limited to 'test/functional/issues_custom_fields_visibility_test.rb')
-rw-r--r-- | test/functional/issues_custom_fields_visibility_test.rb | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/test/functional/issues_custom_fields_visibility_test.rb b/test/functional/issues_custom_fields_visibility_test.rb index 1ce32bf79..485b55be8 100644 --- a/test/functional/issues_custom_fields_visibility_test.rb +++ b/test/functional/issues_custom_fields_visibility_test.rb @@ -285,7 +285,8 @@ class IssuesCustomFieldsVisibilityTest < Redmine::ControllerTest assert_response 302 end end - assert_equal users_to_test.values.uniq.size, ActionMailer::Base.deliveries.size + + assert_equal users_to_test.keys.size, ActionMailer::Base.deliveries.size # tests that each user receives 1 email with the custom fields he is allowed to see only users_to_test.each do |user, fields| mails = ActionMailer::Base.deliveries.select {|m| m.bcc.include? user.mail} @@ -322,7 +323,7 @@ class IssuesCustomFieldsVisibilityTest < Redmine::ControllerTest } assert_response 302 end - assert_equal users_to_test.values.uniq.size, ActionMailer::Base.deliveries.size + assert_equal users_to_test.keys.size, ActionMailer::Base.deliveries.size # tests that each user receives 1 email with the custom fields he is allowed to see only users_to_test.each do |user, fields| mails = ActionMailer::Base.deliveries.select {|m| m.bcc.include? user.mail} |