summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--app/models/user.rb1
-rw-r--r--test/unit/user_test.rb7
2 files changed, 7 insertions, 1 deletions
diff --git a/app/models/user.rb b/app/models/user.rb
index cc4489662..4ce63f809 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -945,6 +945,7 @@ class User < Principal
Issue.where(['author_id = ?', id]).update_all(['author_id = ?', substitute.id])
Issue.where(['assigned_to_id = ?', id]).update_all('assigned_to_id = NULL')
Journal.where(['user_id = ?', id]).update_all(['user_id = ?', substitute.id])
+ Journal.where(['updated_by_id = ?', id]).update_all(['updated_by_id = ?', substitute.id])
JournalDetail.
where(["property = 'attr' AND prop_key = 'assigned_to_id' AND old_value = ?", id.to_s]).
update_all(['old_value = ?', substitute.id.to_s])
diff --git a/test/unit/user_test.rb b/test/unit/user_test.rb
index 34c055c2b..2de0b45db 100644
--- a/test/unit/user_test.rb
+++ b/test/unit/user_test.rb
@@ -308,12 +308,17 @@ class UserTest < ActiveSupport::TestCase
def test_destroy_should_update_journals
issue = Issue.generate!(:project_id => 1, :author_id => 2,
:tracker_id => 1, :subject => 'foo')
+ # Prepare a journal with both user_id and updated_by_id set to 2
issue.init_journal(User.find(2), "update")
issue.save!
+ journal = issue.journals.first
+ journal.update_columns(updated_by_id: 2)
User.find(2).destroy
assert_nil User.find_by_id(2)
- assert_equal User.anonymous, issue.journals.first.reload.user
+ journal.reload
+ assert_equal User.anonymous, journal.user
+ assert_equal User.anonymous, journal.updated_by
end
def test_destroy_should_update_journal_details_old_value