diff options
| -rw-r--r-- | app/controllers/settings_controller.rb | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/app/controllers/settings_controller.rb b/app/controllers/settings_controller.rb index dfbf3fc1e..fd9cd04c8 100644 --- a/app/controllers/settings_controller.rb +++ b/app/controllers/settings_controller.rb @@ -32,9 +32,10 @@ class SettingsController < ApplicationController def edit @notifiables = Redmine::Notifiable.all - if request.post? && params[:settings] && params[:settings].is_a?(Hash) - Setting.set_all_from_params(params[:settings]) - flash[:notice] = l(:notice_successful_update) + if request.post? + if Setting.set_all_from_params(params[:settings]) + flash[:notice] = l(:notice_successful_update) + end redirect_to settings_path(:tab => params[:tab]) else @options = {} @@ -60,7 +61,7 @@ class SettingsController < ApplicationController end if request.post? - Setting.send "plugin_#{@plugin.id}=", params[:settings] + Setting.send "plugin_#{@plugin.id}=", params[:settings].permit!.to_h flash[:notice] = l(:notice_successful_update) redirect_to plugin_settings_path(@plugin) else |