summaryrefslogtreecommitdiffstats
path: root/test/functional/journals_controller_test.rb
blob: 8fc37c4febbf5a29e5bb4f5c34f8c16f8f05f90e (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
# frozen_string_literal: true

# Redmine - project management software
# Copyright (C) 2006-  Jean-Philippe Lang
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

require File.expand_path('../../test_helper', __FILE__)

class JournalsControllerTest < Redmine::ControllerTest
  fixtures :projects, :users, :members, :member_roles, :roles,
           :issues, :journals, :journal_details, :enabled_modules,
           :trackers, :issue_statuses, :enumerations, :custom_fields,
           :custom_values, :custom_fields_projects, :projects_trackers

  def setup
    User.current = nil
  end

  def test_index
    get(:index, :params => {:project_id => 1})
    assert_response :success
    assert_equal 'application/atom+xml', @response.media_type
  end

  def test_index_with_invalid_query_id
    get(
      :index,
      :params => {
        :project_id => 1,
        :query_id => 999
      }
    )
    assert_response 404
  end

  def test_index_should_return_privates_notes_with_permission_only
    journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Privates notes', :private_notes => true, :user_id => 1)
    @request.session[:user_id] = 2

    get(:index, :params => {:project_id => 1})
    assert_response :success
    assert_select 'entry>id', :text => "http://test.host/issues/2?journal_id=#{journal.id}"

    Role.find(1).remove_permission! :view_private_notes
    get(:index, :params => {:project_id => 1})
    assert_response :success
    assert_select 'entry>id', :text => "http://test.host/issues/2?journal_id=#{journal.id}", :count => 0
  end

  def test_index_should_show_visible_custom_fields_only
    set_tmp_attachments_directory
    Issue.destroy_all
    Journal.delete_all
    field_attributes = {:field_format => 'string', :is_for_all => true, :is_filter => true, :trackers => Tracker.all}
    @fields = []
    @fields << (@field1 = IssueCustomField.create!(field_attributes.merge(:name => 'Field 1', :visible => true)))
    @fields << (@field2 = IssueCustomField.create!(field_attributes.merge(:name => 'Field 2', :visible => false, :role_ids => [1, 2])))
    @fields << (@field3 = IssueCustomField.create!(field_attributes.merge(:name => 'Field 3', :visible => false, :role_ids => [1, 3])))
    @issue = Issue.generate!(
      :author_id => 1,
      :project_id => 1,
      :tracker_id => 1,
      :custom_field_values => {@field1.id => 'Value0', @field2.id => 'Value1', @field3.id => 'Value2'}
    )
    @issue.init_journal(User.find(1))
    @issue.custom_field_values = {@field1.id => 'NewValue0', @field2.id => 'NewValue1', @field3.id => 'NewValue2'}
    @issue.save!

    user_with_role_on_other_project = User.generate!
    User.add_to_project(user_with_role_on_other_project, Project.find(2), Role.find(3))
    users_to_test = {
      User.find(1) => [@field1, @field2, @field3],
      User.find(3) => [@field1, @field2],
      user_with_role_on_other_project => [@field1], # should see field1 only on Project 1
      User.generate! => [@field1],
      User.anonymous => [@field1]
    }

    users_to_test.each do |user, visible_fields|
      get(
        :index,
        :params => {
          :format => 'atom',
          :key => user.atom_key
        }
      )
      @fields.each_with_index do |field, i|
        if visible_fields.include?(field)
          assert_select(
            "content[type=html]",
            {:text => /NewValue#{i}/, :count => 1},
            "User #{user.id} was not able to view #{field.name} in API"
          )
        else
          assert_select(
            "content[type=html]",
            {:text => /NewValue#{i}/, :count => 0},
            "User #{user.id} was able to view #{field.name} in API"
          )
        end
      end
    end

  end

  def test_diff_for_description_change
    get(:diff, :params => {:id => 3, :detail_id => 4})
    assert_response :success

    assert_select 'span.diff_out', :text => /removed/
    assert_select 'span.diff_in', :text => /added/
  end

  def test_diff_for_custom_field
    field = IssueCustomField.create!(:name => "Long field", :field_format => 'text')
    journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Notes', :user_id => 1)
    detail = JournalDetail.create!(:journal => journal, :property => 'cf', :prop_key => field.id,
      :old_value => 'Foo', :value => 'Bar')

    get(
      :diff,
      :params => {
        :id => journal.id,
        :detail_id => detail.id
      }
    )
    assert_response :success

    assert_select 'span.diff_out', :text => /Foo/
    assert_select 'span.diff_in', :text => /Bar/
  end

  def test_diff_for_custom_field_should_be_denied_if_custom_field_is_not_visible
    field = IssueCustomField.create!(:name => "Long field", :field_format => 'text', :visible => false, :role_ids => [1])
    journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Notes', :user_id => 1)
    detail = JournalDetail.create!(:journal => journal, :property => 'cf', :prop_key => field.id,
      :old_value => 'Foo', :value => 'Bar')

    get(
      :diff,
      :params => {
        :id => journal.id,
        :detail_id => detail.id
      }
    )
    assert_response 302
  end

  def test_diff_should_default_to_description_diff
    get(:diff, :params => {:id => 3})
    assert_response :success

    assert_select 'span.diff_out', :text => /removed/
    assert_select 'span.diff_in', :text => /added/
  end

  def test_reply_to_issue
    @request.session[:user_id] = 2
    get(:new, :params => {:id => 6}, :xhr => true)
    assert_response :success

    assert_equal 'text/javascript', response.media_type
    assert_include '> This is an issue', response.body
  end

  def test_reply_to_issue_without_permission
    @request.session[:user_id] = 7
    get(:new, :params => {:id => 6}, :xhr => true)
    assert_response 403
  end

  def test_reply_to_note
    @request.session[:user_id] = 2
    get(
      :new,
      :params => {
        :id => 6,
        :journal_id => 4,
        :journal_indice => 1
      },
      :xhr => true
    )
    assert_response :success
    assert_equal 'text/javascript', response.media_type
    assert_include 'Redmine Admin wrote in #note-1:', response.body
    assert_include '> A comment with a private version', response.body
  end

  def test_reply_to_private_note_should_fail_without_permission
    journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Privates notes', :private_notes => true)
    @request.session[:user_id] = 2

    get(
      :new,
      :params => {
        :id => 2,
        :journal_id => journal.id
      },
      :xhr => true
    )
    assert_response :success
    assert_equal 'text/javascript', response.media_type
    assert_include '> Privates notes', response.body

    Role.find(1).remove_permission! :view_private_notes
    get(
      :new,
      :params => {
        :id => 2,
        :journal_id => journal.id
      },
      :xhr => true
    )
    assert_response 404
  end

  def test_edit_xhr
    @request.session[:user_id] = 1
    get(:edit, :params => {:id => 2}, :xhr => true)
    assert_response :success
    assert_equal 'text/javascript', response.media_type
    assert_include 'textarea', response.body
  end

  def test_edit_private_note_should_fail_without_permission
    journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Privates notes', :private_notes => true)
    @request.session[:user_id] = 2
    Role.find(1).add_permission! :edit_issue_notes

    get(:edit, :params => {:id => journal.id}, :xhr => true)
    assert_response :success
    assert_equal 'text/javascript', response.media_type
    assert_include 'textarea', response.body

    Role.find(1).remove_permission! :view_private_notes
    get(:edit, :params => {:id => journal.id}, :xhr => true)
    assert_response 404
  end

  def test_update_xhr
    @request.session[:user_id] = 1
    post(
      :update,
      :params => {
        :id => 2,
        :journal => {
          :notes => 'Updated notes'
        }
      },
      :xhr => true
    )
    assert_response :success
    assert_equal 'text/javascript', response.media_type
    assert_equal 'Updated notes', Journal.find(2).notes
    assert_include 'journal-2-notes', response.body
    # response should include journal_indice param for quote link
    assert_include 'journal_indice=2', response.body
  end

  def test_update_xhr_with_private_notes_checked
    @request.session[:user_id] = 1
    post(
      :update,
      :params => {
        :id => 2,
        :journal => {
          :private_notes => '1'
        }
      },
      :xhr => true
    )
    assert_response :success
    assert_equal 'text/javascript', response.media_type
    assert_equal true, Journal.find(2).private_notes
    assert_include 'change-2', response.body
    assert_include 'journal-2-private_notes', response.body
  end

  def test_update_xhr_with_private_notes_unchecked
    Journal.find(2).update(:private_notes => true)
    @request.session[:user_id] = 1
    post(
      :update,
      :params => {
        :id => 2,
        :journal => {
          :private_notes => '0'
        }
      },
      :xhr => true
    )
    assert_response :success
    assert_equal 'text/javascript', response.media_type
    assert_equal false, Journal.find(2).private_notes
    assert_include 'change-2', response.body
    assert_include 'journal-2-private_notes', response.body
  end

  def test_update_xhr_without_set_private_notes_permission_should_ignore_private_notes
    @request.session[:user_id] = 2
    Role.find(1).add_permission! :edit_issue_notes
    Role.find(1).add_permission! :view_private_notes
    Role.find(1).remove_permission! :set_notes_private

    post(
      :update,
      :params => {
        :id => 2,
        :journal => {
          :private_notes => '1'
        }
      },
      :xhr => true
    )
    assert_response :success
    assert_equal false, Journal.find(2).private_notes
  end

  def test_update_xhr_with_empty_notes_should_delete_the_journal
    @request.session[:user_id] = 1
    assert_difference 'Journal.count', -1 do
      post(
        :update,
        :params => {
          :id => 2,
          :journal => {
            :notes => ''
          }
        },
        :xhr => true
      )
      assert_response :success
      assert_equal 'text/javascript', response.media_type
    end
    assert_nil Journal.find_by_id(2)
    assert_include 'change-2', response.body
  end
end