1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
|
# frozen_string_literal: true
# Redmine - project management software
# Copyright (C) 2006- Jean-Philippe Lang
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require_relative '../test_helper'
class ReactionsControllerTest < Redmine::ControllerTest
setup do
Setting.reactions_enabled = '1'
# jsmith
@request.session[:user_id] = users(:users_002).id
end
teardown do
Setting.clear_cache
end
test 'create for issue' do
issue = issues(:issues_002)
assert_difference(
->{ Reaction.count } => 1,
->{ issue.reactions.by(users(:users_002)).count } => 1
) do
post :create, params: {
object_type: 'Issue',
object_id: issue.id
}, xhr: true
end
assert_response :success
end
test 'create for journal' do
journal = journals(:journals_005)
assert_difference(
->{ Reaction.count } => 1,
->{ journal.reactions.by(users(:users_002)).count } => 1
) do
post :create, params: {
object_type: 'Journal',
object_id: journal.id
}, xhr: true
end
assert_response :success
end
test 'create for news' do
news = news(:news_002)
assert_difference(
->{ Reaction.count } => 1,
->{ news.reactions.by(users(:users_002)).count } => 1
) do
post :create, params: {
object_type: 'News',
object_id: news.id
}, xhr: true
end
assert_response :success
end
test 'create reaction for comment' do
comment = comments(:comments_002)
assert_difference(
->{ Reaction.count } => 1,
->{ comment.reactions.by(users(:users_002)).count } => 1
) do
post :create, params: {
object_type: 'Comment',
object_id: comment.id
}, xhr: true
end
assert_response :success
end
test 'create for message' do
message = messages(:messages_001)
assert_difference(
->{ Reaction.count } => 1,
->{ message.reactions.by(users(:users_002)).count } => 1
) do
post :create, params: {
object_type: 'Message',
object_id: message.id
}, xhr: true
end
assert_response :success
end
test 'destroy for issue' do
reaction = reactions(:reaction_005)
assert_difference 'Reaction.count', -1 do
delete :destroy, params: {
id: reaction.id,
# Issue (id=6)
object_type: reaction.reactable_type,
object_id: reaction.reactable_id
}, xhr: true
end
assert_response :success
assert_not Reaction.exists?(reaction.id)
end
test 'destroy for journal' do
reaction = reactions(:reaction_006)
assert_difference 'Reaction.count', -1 do
delete :destroy, params: {
id: reaction.id,
object_type: reaction.reactable_type,
object_id: reaction.reactable_id
}, xhr: true
end
assert_response :success
assert_not Reaction.exists?(reaction.id)
end
test 'destroy for news' do
# For News(id=3)
reaction = reactions(:reaction_010)
assert_difference 'Reaction.count', -1 do
delete :destroy, params: {
id: reaction.id,
object_type: reaction.reactable_type,
object_id: reaction.reactable_id
}, xhr: true
end
assert_response :success
assert_not Reaction.exists?(reaction.id)
end
test 'destroy for comment' do
# For Comment(id=1)
reaction = reactions(:reaction_008)
assert_difference 'Reaction.count', -1 do
delete :destroy, params: {
id: reaction.id,
object_type: reaction.reactable_type,
object_id: reaction.reactable_id
}, xhr: true
end
assert_response :success
assert_not Reaction.exists?(reaction.id)
end
test 'destroy for message' do
reaction = reactions(:reaction_009)
assert_difference 'Reaction.count', -1 do
delete :destroy, params: {
id: reaction.id,
object_type: reaction.reactable_type,
object_id: reaction.reactable_id
}, xhr: true
end
assert_response :success
assert_not Reaction.exists?(reaction.id)
end
test 'create should respond with 403 when feature is disabled' do
Setting.reactions_enabled = '0'
# admin
@request.session[:user_id] = users(:users_001).id
assert_no_difference 'Reaction.count' do
post :create, params: {
object_type: 'Issue',
object_id: issues(:issues_002).id
}, xhr: true
end
assert_response :forbidden
end
test 'destroy should respond with 403 when feature is disabled' do
Setting.reactions_enabled = '0'
# admin
@request.session[:user_id] = users(:users_001).id
reaction = reactions(:reaction_001)
assert_no_difference 'Reaction.count' do
delete :destroy, params: {
id: reaction.id,
object_type: reaction.reactable_type,
object_id: reaction.reactable_id
}, xhr: true
end
assert_response :forbidden
end
test 'create by anonymou user should respond with 401 when feature is disabled' do
Setting.reactions_enabled = '0'
@request.session[:user_id] = nil
assert_no_difference 'Reaction.count' do
post :create, params: {
object_type: 'Issue',
object_id: issues(:issues_002).id
}, xhr: true
end
assert_response :unauthorized
end
test 'create by anonymous user should respond with 401' do
@request.session[:user_id] = nil
assert_no_difference 'Reaction.count' do
post :create, params: {
object_type: 'Issue',
# Issue(id=1) is an issue in a public project
object_id: issues(:issues_001).id
}, xhr: true
end
assert_response :unauthorized
end
test 'destroy by anonymous user should respond with 401' do
@request.session[:user_id] = nil
reaction = reactions(:reaction_002)
assert_no_difference 'Reaction.count' do
delete :destroy, params: {
id: reaction.id,
object_type: reaction.reactable_type,
object_id: reaction.reactable_id
}, xhr: true
end
assert_response :unauthorized
end
test 'create when reaction already exists should not create a new reaction and succeed' do
assert_no_difference 'Reaction.count' do
post :create, params: {
object_type: 'Comment',
# user(jsmith) has already reacted to Comment(id=1)
object_id: comments(:comments_001).id
}, xhr: true
end
assert_response :success
end
test 'destroy another user reaction should not destroy the reaction and succeed' do
# admin user's reaction
reaction = reactions(:reaction_001)
assert_no_difference 'Reaction.count' do
delete :destroy, params: {
id: reaction.id,
object_type: reaction.reactable_type,
object_id: reaction.reactable_id
}, xhr: true
end
assert_response :success
end
test 'destroy nonexistent reaction' do
# For Journal(id=4)
reaction = reactions(:reaction_006)
reaction.destroy!
assert_not Reaction.exists?(reaction.id)
assert_no_difference 'Reaction.count' do
delete :destroy, params: {
id: reaction.id,
object_type: reaction.reactable_type,
object_id: reaction.reactable_id
}, xhr: true
end
assert_response :success
end
test 'create with invalid object type should respond with 403' do
# admin
@request.session[:user_id] = users(:users_001).id
post :create, params: {
object_type: 'InvalidType',
object_id: 1
}, xhr: true
assert_response :forbidden
end
test 'create without permission to view should respond with 403' do
# dlopper
@request.session[:user_id] = users(:users_003).id
assert_no_difference 'Reaction.count' do
post :create, params: {
object_type: 'Issue',
# dlopper is not a member of the project where the issue (id=4) belongs.
object_id: issues(:issues_004).id
}, xhr: true
end
assert_response :forbidden
end
test 'destroy without permission to view should respond with 403' do
# dlopper
@request.session[:user_id] = users(:users_003).id
# For Issue(id=6)
reaction = reactions(:reaction_005)
assert_no_difference 'Reaction.count' do
delete :destroy, params: {
id: reaction.id,
object_type: reaction.reactable_type,
object_id: reaction.reactable_id
}, xhr: true
end
assert_response :forbidden
end
test 'create should respond with 404 for non-JS requests' do
issue = issues(:issues_002)
assert_no_difference 'Reaction.count' do
post :create, params: {
object_type: 'Issue',
object_id: issue.id
} # Sending an HTML request by omitting xhr: true
end
assert_response :not_found
end
test 'create should respond with 403 when project is closed' do
issue = issues(:issues_010)
issue.project.update!(status: Project::STATUS_CLOSED)
assert_no_difference 'Reaction.count' do
post :create, params: {
object_type: 'Issue',
object_id: issue.id
}, xhr: true
end
assert_response :forbidden
end
test 'destroy should respond with 403 when project is closed' do
reaction = reactions(:reaction_005)
reaction.reactable.project.update!(status: Project::STATUS_CLOSED)
assert_no_difference 'Reaction.count' do
delete :destroy, params: {
id: reaction.id,
object_type: reaction.reactable_type,
object_id: reaction.reactable_id
}, xhr: true
end
assert_response :forbidden
end
end
|