1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
|
# frozen_string_literal: true
# Redmine - project management software
# Copyright (C) 2006- Jean-Philippe Lang
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../../test_helper', __FILE__)
class TimeEntryTest < ActiveSupport::TestCase
include Redmine::I18n
fixtures :issues, :projects, :users, :time_entries,
:members, :roles, :member_roles,
:trackers, :issue_statuses,
:projects_trackers,
:journals, :journal_details,
:issue_categories, :enumerations,
:groups_users,
:enabled_modules,
:custom_fields, :custom_fields_projects, :custom_values
def setup
User.current = nil
end
def test_visibility_with_permission_to_view_all_time_entries
user = User.generate!
role = Role.generate!(:permissions => [:view_time_entries], :time_entries_visibility => 'all')
Role.non_member.remove_permission! :view_time_entries
project = Project.find(1)
User.add_to_project user, project, role
own = TimeEntry.generate! :user => user, :project => project
other = TimeEntry.generate! :user => User.find(2), :project => project
assert TimeEntry.visible(user).find_by_id(own.id)
assert TimeEntry.visible(user).find_by_id(other.id)
assert own.visible?(user)
assert other.visible?(user)
end
def test_visibility_with_permission_to_view_own_time_entries
user = User.generate!
role = Role.generate!(:permissions => [:view_time_entries], :time_entries_visibility => 'own')
Role.non_member.remove_permission! :view_time_entries
project = Project.find(1)
User.add_to_project user, project, role
own = TimeEntry.generate! :user => user, :project => project
other = TimeEntry.generate! :user => User.find(2), :project => project
assert TimeEntry.visible(user).find_by_id(own.id)
assert_nil TimeEntry.visible(user).find_by_id(other.id)
assert own.visible?(user)
assert_equal false, other.visible?(user)
end
def test_hours_format
assertions = {
"2" => 2.0,
"21.1" => 21.1,
"2,1" => 2.1,
"1,5h" => 1.5,
"7:12" => 7.2,
"10h" => 10.0,
"10 h" => 10.0,
"45m" => 0.75,
"45 m" => 0.75,
"3h15" => 3.25,
"3h 15" => 3.25,
"3 h 15" => 3.25,
"3 h 15m" => 3.25,
"3 h 15 m" => 3.25,
"3 hours" => 3.0,
"12min" => 0.2,
"12 Min" => 0.2,
}
assertions.each do |k, v|
t = TimeEntry.new(:hours => k)
assert_equal v, t.hours, "Converting #{k} failed:"
end
end
def test_hours_should_default_to_nil
assert_nil TimeEntry.new.hours
end
def test_should_accept_0_hours
entry = TimeEntry.generate
entry.hours = 0
assert entry.save
end
def test_should_not_accept_0_hours_if_disabled
with_settings :timelog_accept_0_hours => '0' do
entry = TimeEntry.generate
entry.hours = 0
assert !entry.save
assert entry.errors[:hours].present?
end
end
def test_should_not_accept_more_than_maximum_hours_per_day_and_user
with_settings :timelog_max_hours_per_day => '8' do
entry = TimeEntry.generate(:spent_on => '2017-07-16', :hours => 6.0, :user_id => 2)
assert entry.save
entry = TimeEntry.generate(:spent_on => '2017-07-16', :hours => 1.5, :user_id => 2)
assert entry.save
entry = TimeEntry.generate(:spent_on => '2017-07-16', :hours => 3.0, :user_id => 2)
assert !entry.save
end
end
def test_activity_id_should_default_activity_id
project = Project.find(1)
default_activity = TimeEntryActivity.find(10)
entry = TimeEntry.new(project: project)
assert_equal entry.activity_id, default_activity.id
# If there are project specific activities
project_specific_default_activity = TimeEntryActivity.create!(name: 'Development', parent_id: 10, project_id: project.id, is_default: false)
entry = TimeEntry.new(project: project)
assert_not_equal entry.activity_id, default_activity.id
assert_equal entry.activity_id, project_specific_default_activity.id
end
def test_should_accept_future_dates
entry = TimeEntry.generate
entry.spent_on = User.current.today + 1
assert entry.save
end
def test_should_not_accept_future_dates_if_disabled
with_settings :timelog_accept_future_dates => '0' do
entry = TimeEntry.generate
entry.spent_on = User.current.today + 1
assert !entry.save
assert entry.errors[:base].present?
end
end
def test_should_require_spent_on
with_settings :timelog_accept_future_dates => '0' do
entry = TimeEntry.find(1)
entry.spent_on = ''
assert !entry.save
assert entry.errors[:spent_on].present?
end
end
def test_spent_on_with_blank
c = TimeEntry.new
c.spent_on = ''
assert_nil c.spent_on
end
def test_spent_on_with_nil
c = TimeEntry.new
c.spent_on = nil
assert_nil c.spent_on
end
def test_spent_on_with_string
c = TimeEntry.new
c.spent_on = "2011-01-14"
assert_equal Date.parse("2011-01-14"), c.spent_on
end
def test_spent_on_with_invalid_string
c = TimeEntry.new
c.spent_on = "foo"
assert_nil c.spent_on
end
def test_spent_on_with_date
c = TimeEntry.new
c.spent_on = Date.today
assert_equal Date.today, c.spent_on
end
def test_spent_on_with_time
c = TimeEntry.new
c.spent_on = Time.now
assert_kind_of Date, c.spent_on
end
def test_validate_time_entry
anon = User.anonymous
project = Project.find(1)
issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => anon.id, :status_id => 1,
:priority => IssuePriority.all.first, :subject => 'test_create',
:description => 'IssueTest#test_create', :estimated_hours => '1:30')
assert issue.save
activity = TimeEntryActivity.find_by_name('Design')
te = TimeEntry.create(:spent_on => '2010-01-01',
:hours => 100000,
:issue => issue,
:project => project,
:user => anon,
:author => anon,
:activity => activity)
assert_equal 1, te.errors.count
end
def test_acitivity_should_belong_to_project_activities
activity = TimeEntryActivity.create!(:name => 'Other project activity', :project_id => 2, :active => true)
entry = TimeEntry.new(:spent_on => Date.today, :hours => 1.0, :user => User.find(1), :project_id => 1, :activity => activity)
assert !entry.valid?
assert_include I18n.translate('activerecord.errors.messages.inclusion'), entry.errors[:activity_id]
end
def test_spent_on_with_2_digits_year_should_not_be_valid
entry = TimeEntry.new(:project => Project.find(1), :user => User.find(1), :activity => TimeEntryActivity.first, :hours => 1)
entry.spent_on = "09-02-04"
assert !entry.valid?
assert_include I18n.translate('activerecord.errors.messages.not_a_date'), entry.errors[:spent_on]
end
def test_set_project_if_nil
anon = User.anonymous
project = Project.find(1)
issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => anon.id, :status_id => 1,
:priority => IssuePriority.all.first, :subject => 'test_create',
:description => 'IssueTest#test_create', :estimated_hours => '1:30')
assert issue.save
activity = TimeEntryActivity.find_by_name('Design')
te = TimeEntry.create(:spent_on => '2010-01-01',
:hours => 10,
:issue => issue,
:user => anon,
:activity => activity)
assert_equal project.id, te.project.id
end
def test_create_with_required_issue_id_and_comment_should_be_validated
set_language_if_valid 'en'
with_settings :timelog_required_fields => ['issue_id', 'comments'] do
entry = TimeEntry.new(:project => Project.find(1),
:spent_on => Date.today,
:author => User.find(1),
:user => User.find(1),
:activity => TimeEntryActivity.first,
:hours => 1)
assert !entry.save
assert_equal ["Comment cannot be blank", "Issue cannot be blank"], entry.errors.full_messages.sort
end
end
def test_create_should_validate_user_id
set_language_if_valid 'en'
entry = TimeEntry.new(:spent_on => '2010-01-01',
:hours => 10,
:project_id => 1,
:user_id => 4)
assert !entry.save
assert_equal ["User is invalid"], entry.errors.full_messages.sort
end
def test_assignable_users_should_include_active_project_members_with_log_time_permission
Role.find(2).remove_permission! :log_time
time_entry = TimeEntry.find(1)
assert_equal [2], time_entry.assignable_users.map(&:id)
end
end
|