diff options
author | Duarte Meneses <duarte.meneses@sonarsource.com> | 2017-12-29 13:09:20 +0100 |
---|---|---|
committer | Duarte Meneses <duarte.meneses@sonarsource.com> | 2017-12-29 14:17:45 +0100 |
commit | 4d6a2243d4799026ee5351261fd238fde400a8bc (patch) | |
tree | ea85f6bdda54ae7519877fbe4ef42ba2761e1380 /src/test/java | |
parent | 7465b0c71083c5ea1297cbd44f86a84bc00a665b (diff) | |
download | sonar-scanner-cli-4d6a2243d4799026ee5351261fd238fde400a8bc.tar.gz sonar-scanner-cli-4d6a2243d4799026ee5351261fd238fde400a8bc.zip |
SQSCANNER-47 Improve error logs when exception is a MessageException
Diffstat (limited to 'src/test/java')
-rw-r--r-- | src/test/java/org/sonarsource/scanner/cli/MainTest.java | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/src/test/java/org/sonarsource/scanner/cli/MainTest.java b/src/test/java/org/sonarsource/scanner/cli/MainTest.java index 869a183..e7b2e64 100644 --- a/src/test/java/org/sonarsource/scanner/cli/MainTest.java +++ b/src/test/java/org/sonarsource/scanner/cli/MainTest.java @@ -85,7 +85,7 @@ public class MainTest { e = new IllegalStateException("Error", e); doThrow(e).when(runner).execute(any(Map.class)); when(scannerFactory.create(any(Properties.class))).thenReturn(runner); - + when(cli.isDebugEnabled()).thenReturn(true); Main main = new Main(exit, cli, conf, scannerFactory, logs); main.execute(); @@ -99,6 +99,7 @@ public class MainTest { Exception e = new NullPointerException("NPE"); e = new IllegalStateException("Error", e); doThrow(e).when(runner).start(); + when(cli.isDebugEnabled()).thenReturn(true); when(scannerFactory.create(any(Properties.class))).thenReturn(runner); Main main = new Main(exit, cli, conf, scannerFactory, logs); @@ -111,22 +112,23 @@ public class MainTest { } @Test - public void show_error_with_stacktrace() { - Exception e = createException(false); + public void show_error_MessageException() { + Exception e = createException(true); testException(e, false); - verify(logs).error("Error during SonarQube Scanner execution", e); + verify(logs).error("Error during SonarQube Scanner execution"); + verify(logs).error("Caused by: NPE"); verify(logs).error("Re-run SonarQube Scanner using the -X switch to enable full debug logging."); } - + @Test - public void show_error_MessageException() { + public void show_error_MessageException_debug() { Exception e = createException(true); - testException(e, false); + testException(e, true); verify(logs).error("Error during SonarQube Scanner execution"); + verify(logs).error("my message"); verify(logs).error("Caused by: NPE"); - verify(logs).error("Re-run SonarQube Scanner using the -X switch to enable full debug logging."); } @Test |