1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
|
/*
* SonarScanner CLI
* Copyright (C) 2011-2025 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
package org.sonarsource.scanner.cli;
import java.io.IOException;
import java.net.URISyntaxException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.HashMap;
import java.util.Map;
import java.util.Properties;
import org.apache.commons.lang3.SystemUtils;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatCode;
import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
import static org.junit.jupiter.api.Assumptions.assumeTrue;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
class ConfTest {
private final Map<String, String> env = new HashMap<>();
private final Properties args = new Properties();
private final Cli cli = mock(Cli.class);
private final Conf conf = new Conf(cli, env);
@BeforeEach
void initConf() {
env.clear();
when(cli.properties()).thenReturn(args);
}
@Test
void should_load_global_settings_by_home() throws Exception {
Path home = Paths.get(getClass().getResource("ConfTest/shouldLoadRunnerSettingsByHome/").toURI());
args.setProperty("scanner.home", home.toAbsolutePath().toString());
Properties properties = conf.properties();
assertThat(properties).containsEntry("sonar.prop", "value");
}
@Test
void should_not_fail_if_no_home() {
assertThat(conf.properties()).isNotEmpty();
// worst case, use current path
assertThat(conf.properties().getProperty("sonar.projectBaseDir")).isEqualTo(Paths.get("").toAbsolutePath().toString());
}
@Test
void should_set_bootstrap_time_only_once() {
Properties properties = conf.properties();
assertThat(properties).containsKey("sonar.scanner.bootstrapStartTime");
String value = properties.getProperty("sonar.scanner.bootstrapStartTime");
assertThat(conf.properties())
.containsEntry("sonar.scanner.bootstrapStartTime", value);
}
@Test
void base_dir_can_be_relative() throws URISyntaxException {
Path projectHome = Paths.get(getClass().getResource("ConfTest/shouldLoadModuleConfiguration/project").toURI());
args.setProperty("project.home", projectHome.getParent().toAbsolutePath().toString());
args.setProperty("sonar.projectBaseDir", "project");
Properties properties = conf.properties();
assertThat(properties.getProperty("module1.sonar.projectName")).isEqualTo("Module 1");
assertThat(properties.getProperty("module2.sonar.projectName")).isEqualTo("Module 2");
assertThat(properties.getProperty("sonar.projectBaseDir")).isEqualTo(projectHome.toString());
}
@Test
void should_load_conf_by_direct_path() throws Exception {
Path settings = Paths.get(getClass().getResource("ConfTest/shouldLoadRunnerSettingsByDirectPath/other-conf.properties").toURI());
args.setProperty("scanner.settings", settings.toAbsolutePath().toString());
assertThat(conf.properties()).containsEntry("sonar.prop", "otherValue");
}
@Test
void shouldLoadCompleteConfiguration() throws Exception {
Path runnerHome = Paths.get(getClass().getResource("ConfTest/shouldLoadCompleteConfiguration/runner").toURI());
Path projectHome = Paths.get(getClass().getResource("ConfTest/shouldLoadCompleteConfiguration/project").toURI());
args.setProperty("scanner.home", runnerHome.toAbsolutePath().toString());
args.setProperty("project.home", projectHome.toAbsolutePath().toString());
Properties properties = conf.properties();
assertThat(properties.getProperty("project.prop")).isEqualTo("foo");
assertThat(properties.getProperty("overridden.prop")).isEqualTo("project scope");
assertThat(properties.getProperty("global.prop")).isEqualTo("jdbc:mysql:localhost/sonar");
assertThat(properties.getProperty("sonar.projectBaseDir")).isEqualTo(projectHome.toString());
}
@Test
void shouldLoadModuleConfiguration() throws Exception {
Path projectHome = Paths.get(getClass().getResource("ConfTest/shouldLoadModuleConfiguration/project").toURI());
args.setProperty("project.home", projectHome.toAbsolutePath().toString());
Properties properties = conf.properties();
assertThat(properties.getProperty("module1.sonar.projectName")).isEqualTo("Module 1");
assertThat(properties.getProperty("module2.sonar.projectName")).isEqualTo("Module 2");
assertThat(properties.getProperty("sonar.projectBaseDir")).isEqualTo(projectHome.toString());
}
@Test
void shouldSupportDeepModuleConfigurationInRoot() throws Exception {
Path projectHome = Paths.get(getClass().getResource("ConfTest/shouldSupportDeepModuleConfigurationInRoot/project").toURI());
args.setProperty("project.home", projectHome.toAbsolutePath().toString());
Properties properties = conf.properties();
assertThat(properties.getProperty("1.sonar.projectName")).isEqualTo("Module 1");
assertThat(properties.getProperty("1.11.sonar.projectName")).isEqualTo("Module 11");
assertThat(properties.getProperty("1.11.111.sonar.projectName")).isEqualTo("Module 111");
assertThat(properties.getProperty("1.12.sonar.projectName")).isEqualTo("Module 12");
assertThat(properties.getProperty("2.sonar.projectName")).isEqualTo("Module 2");
// SONARUNNER-125
assertThat(properties.getProperty("11.111.sonar.projectName")).isNull();
assertThat(properties.getProperty("sonar.projectBaseDir")).isEqualTo(projectHome.toString());
}
@Test
void shouldLoadModuleConfigurationOverrideBasedir() throws Exception {
Path projectHome = Paths.get(getClass().getResource("ConfTest/shouldLoadModuleConfigurationOverrideBasedir/project").toURI());
args.setProperty("project.home", projectHome.toAbsolutePath().toString());
Properties properties = conf.properties();
assertThat(properties.getProperty("module1.sonar.projectName")).isEqualTo("Module 1");
assertThat(properties.getProperty("module2.sonar.projectName")).isEqualTo("Module 2");
assertThat(properties.getProperty("module3.sonar.projectName")).isEqualTo("Module 3");
assertThat(properties.getProperty("sonar.projectBaseDir")).isEqualTo(projectHome.toString());
}
@Test
void shouldCliOverrideSettingFiles() throws Exception {
Path projectHome = Paths.get(getClass().getResource("ConfTest/shouldLoadModuleConfigurationOverrideBasedir/project").toURI());
args.setProperty("project.home", projectHome.toAbsolutePath().toString());
args.setProperty("module1.sonar.projectName", "mod1");
args.setProperty("module2.sonar.projectName", "mod2");
args.setProperty("module3.sonar.projectName", "mod3");
Properties properties = conf.properties();
assertThat(properties.getProperty("module1.sonar.projectName")).isEqualTo("mod1");
assertThat(properties.getProperty("module2.sonar.projectName")).isEqualTo("mod2");
assertThat(properties.getProperty("module3.sonar.projectName")).isEqualTo("mod3");
assertThat(properties.getProperty("sonar.projectBaseDir")).isEqualTo(projectHome.toString());
}
@Test
void shouldUseCliToDiscoverModules() throws Exception {
Path projectHome = Paths.get(getClass().getResource("ConfTest/shouldLoadModuleConfigurationOverrideBasedir/project").toURI());
args.setProperty("project.home", projectHome.toAbsolutePath().toString());
args.setProperty("sonar.modules", "module1");
args.setProperty("module1.sonar.projectBaseDir", "module_3");
Properties properties = conf.properties();
assertThat(properties.getProperty("module1.sonar.projectName")).isEqualTo("Module 3");
assertThat(properties.getProperty("module2.sonar.projectName")).isNull();
assertThat(properties.getProperty("module3.sonar.projectName")).isNull();
assertThat(properties.getProperty("sonar.projectBaseDir")).isEqualTo(projectHome.toString());
}
@Test
void shouldLoadModuleConfigurationWithoutRootConf() throws Exception {
Path projectHome = Paths.get(getClass().getResource("ConfTest/shouldLoadModuleConfigurationWithoutRootConf/project").toURI());
args.setProperty("project.home", projectHome.toAbsolutePath().toString());
args.put("sonar.modules", "module1,module2");
Properties properties = conf.properties();
assertThat(properties.getProperty("module1.sonar.projectName")).isEqualTo("Module 1");
assertThat(properties.getProperty("module2.sonar.projectName")).isEqualTo("Module 2");
assertThat(properties.getProperty("sonar.projectBaseDir")).isEqualTo(projectHome.toString());
}
@Test
void failModuleBaseDirDoesNotExist() {
args.setProperty("sonar.modules", "module1");
args.setProperty("module1.sonar.projectBaseDir", "invalid");
assertThatIllegalStateException()
.isThrownBy(conf::properties)
.withMessageStartingWith("The base directory of the module 'module1' does not exist");
}
@Test
void failModulePropertyFileDoesNotExist() {
args.setProperty("sonar.modules", "module1");
args.setProperty("module1.sonar.projectConfigFile", "invalid");
assertThatIllegalStateException()
.isThrownBy(conf::properties)
.withMessageStartingWith("The properties file of the module 'module1' does not exist");
}
@Test
void shouldSupportSettingBaseDirFromCli(@TempDir Path projectHome) throws Exception {
Path projectBaseDir = Paths.get(getClass().getResource("ConfTest/shouldLoadModuleConfiguration/project").toURI());
args.setProperty("project.home", projectHome.toString());
args.setProperty("sonar.projectBaseDir", projectBaseDir.toAbsolutePath().toString());
Properties properties = conf.properties();
assertThat(properties.getProperty("module1.sonar.projectName")).isEqualTo("Module 1");
assertThat(properties.getProperty("module2.sonar.projectName")).isEqualTo("Module 2");
assertThat(properties.getProperty("sonar.projectBaseDir")).isEqualTo(projectBaseDir.toString());
}
@Test
void ignoreEmptyModule(@TempDir Path projectHome) throws Exception {
Path projectBaseDir = Paths.get(getClass().getResource("ConfTest/emptyModules/project").toURI());
args.setProperty("project.home", projectHome.toString());
args.setProperty("sonar.projectBaseDir", projectBaseDir.toAbsolutePath().toString());
assertThatCode(conf::properties)
.doesNotThrowAnyException();
}
@Test
void shouldGetList() {
Properties props = new Properties();
props.put("prop", " foo ,, bar , \n\ntoto,tutu");
assertThat(Conf.getListFromProperty(props, "prop")).containsOnly("foo", "bar", "toto", "tutu");
}
@Test
void shouldNotResolveSymlinks(@TempDir Path root) throws IOException, URISyntaxException {
assumeTrue(SystemUtils.IS_OS_UNIX);
Path realProjectHome = Paths.get(getClass().getResource("ConfTest/shouldLoadModuleConfiguration/project").toURI());
Path linkProjectHome = root.resolve("link");
try {
Files.createSymbolicLink(linkProjectHome, realProjectHome);
args.setProperty("project.home", linkProjectHome.toAbsolutePath().toString());
Properties properties = conf.properties();
assertThat(properties.getProperty("module1.sonar.projectName")).isEqualTo("Module 1");
assertThat(properties.getProperty("module2.sonar.projectName")).isEqualTo("Module 2");
assertThat(properties.getProperty("sonar.projectBaseDir")).isEqualTo(linkProjectHome.toString());
assertThat(properties.getProperty("module1.sonar.projectBaseDir")).isEqualTo(linkProjectHome.resolve("module1").toString());
assertThat(properties.getProperty("module2.sonar.projectBaseDir")).isEqualTo(linkProjectHome.resolve("module2").toString());
} finally {
Files.delete(linkProjectHome);
}
}
// SQSCANNER-24
@Test
void should_load_project_settings_using_property() throws Exception {
Path home = Paths.get(getClass().getResource("ConfTest/shouldOverrideProjectSettingsPath/").toURI());
args.setProperty("project.home", home.toAbsolutePath().toString());
Properties properties = conf.properties();
assertThat(properties).containsEntry("sonar.prop", "default");
args.setProperty("project.settings", home.resolve("conf/sq-project.properties").toAbsolutePath().toString());
properties = conf.properties();
assertThat(properties).containsEntry("sonar.prop", "expected");
}
@Test
void should_handle_non_latin_characters() throws Exception {
Path home = Paths.get(getClass().getResource("ConfTest/shouldHandleNonLatinChars/project").toURI());
args.setProperty("project.home", home.toAbsolutePath().toString());
Properties properties = conf.properties();
assertThat(properties).containsEntry("project.nonlatin", "Non Latin ÇŞĞIİÖÜ");
}
}
|