aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulien Lancelot <julien.lancelot@gmail.com>2013-07-08 10:38:15 +0200
committerJulien Lancelot <julien.lancelot@gmail.com>2013-07-08 10:38:15 +0200
commit1ace6fef25bfce62a9b96a3a079e80cb75f819a7 (patch)
tree5ca56b2a7c1d8ed499c6e5d5152d1b9c18911971
parent3b1037379fe64ede71e194392a99b57e9c5fff07 (diff)
downloadsonarqube-1ace6fef25bfce62a9b96a3a079e80cb75f819a7.tar.gz
sonarqube-1ace6fef25bfce62a9b96a3a079e80cb75f819a7.zip
Fix quality flaws
-rw-r--r--sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java3
-rw-r--r--sonar-server/src/main/java/org/sonar/server/issue/SetSeverityAction.java3
-rw-r--r--sonar-server/src/main/java/org/sonar/server/issue/TransitionAction.java3
3 files changed, 6 insertions, 3 deletions
diff --git a/sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java b/sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java
index cb12690cb26..8550c60b2a3 100644
--- a/sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java
@@ -45,7 +45,8 @@ public class CommentAction extends Action implements ServerComponent {
@Override
public boolean verify(Map<String, Object> properties, List<Issue> issues, UserSession userSession) {
- return comment(properties) != null;
+ comment(properties);
+ return true;
}
@Override
diff --git a/sonar-server/src/main/java/org/sonar/server/issue/SetSeverityAction.java b/sonar-server/src/main/java/org/sonar/server/issue/SetSeverityAction.java
index 4a5ea4c82f1..ab9ab82c973 100644
--- a/sonar-server/src/main/java/org/sonar/server/issue/SetSeverityAction.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/SetSeverityAction.java
@@ -46,7 +46,8 @@ public class SetSeverityAction extends Action implements ServerComponent {
@Override
public boolean verify(Map<String, Object> properties, List<Issue> issues, UserSession userSession) {
- return severity(properties) != null;
+ severity(properties);
+ return true;
}
@Override
diff --git a/sonar-server/src/main/java/org/sonar/server/issue/TransitionAction.java b/sonar-server/src/main/java/org/sonar/server/issue/TransitionAction.java
index cc949f993dc..16da057468a 100644
--- a/sonar-server/src/main/java/org/sonar/server/issue/TransitionAction.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/TransitionAction.java
@@ -43,7 +43,8 @@ public class TransitionAction extends Action implements ServerComponent {
@Override
public boolean verify(Map<String, Object> properties, List<Issue> issues, UserSession userSession) {
- return transition(properties) != null;
+ transition(properties);
+ return true;
}
@Override