aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSimon Brandhof <simon.brandhof@gmail.com>2012-10-10 16:19:17 +0200
committerSimon Brandhof <simon.brandhof@gmail.com>2012-10-10 16:21:24 +0200
commit14e81abf83cff0f76b7cc38131d7991f9afae0b3 (patch)
tree578e5829eb1714d4c5cd5984f47501fdb7ed17cb
parentb3b21c66379d99688ce5e65a811fdd79bf0a9c6d (diff)
downloadsonarqube-14e81abf83cff0f76b7cc38131d7991f9afae0b3.tar.gz
sonarqube-14e81abf83cff0f76b7cc38131d7991f9afae0b3.zip
Fix some quality flaws
-rw-r--r--plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/widgets/WidgetsConstants.java5
-rw-r--r--sonar-plugin-api/src/main/java/org/sonar/api/profiles/RulesProfile.java1
-rw-r--r--sonar-plugin-api/src/test/java/org/sonar/api/utils/command/CommandTest.java2
3 files changed, 3 insertions, 5 deletions
diff --git a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/widgets/WidgetsConstants.java b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/widgets/WidgetsConstants.java
index 7fab6f3c020..6f44845d316 100644
--- a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/widgets/WidgetsConstants.java
+++ b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/widgets/WidgetsConstants.java
@@ -19,8 +19,6 @@
*/
package org.sonar.plugins.core.widgets;
-import org.sonar.api.web.WidgetProperty;
-
/**
* Constants shared accross multiple widgets
*/
@@ -28,7 +26,8 @@ interface WidgetsConstants {
/**
* Widget property option used to filter out all the metrics which keys start with "new_".
- * @see WidgetProperty#options()
+ *
+ * @see org.sonar.api.web.WidgetProperty#options()
*/
String FILTER_OUT_NEW_METRICS = "key:^(?!new_).*";
}
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/profiles/RulesProfile.java b/sonar-plugin-api/src/main/java/org/sonar/api/profiles/RulesProfile.java
index 9b25030aa54..afb2104b597 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/profiles/RulesProfile.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/profiles/RulesProfile.java
@@ -396,7 +396,6 @@ public class RulesProfile implements Cloneable {
public Object clone() {
RulesProfile clone = RulesProfile.create(getName(), getLanguage());
clone.setDefaultProfile(getDefaultProfile());
- clone.setProvided(getProvided());
clone.setParentName(getParentName());
if (CollectionUtils.isNotEmpty(activeRules)) {
clone.setActiveRules(new ArrayList<ActiveRule>(CollectionUtils.collect(activeRules, new Transformer() {
diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/utils/command/CommandTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/utils/command/CommandTest.java
index 2ae9c89b4f8..f85fc0e6db1 100644
--- a/sonar-plugin-api/src/test/java/org/sonar/api/utils/command/CommandTest.java
+++ b/sonar-plugin-api/src/test/java/org/sonar/api/utils/command/CommandTest.java
@@ -92,7 +92,7 @@ public class CommandTest {
if (SystemUtils.IS_OS_WINDOWS) {
Command command = Command.create("foo.bat");
command.setNewShell(true);
- assertThat(command.toCommandLine()).isEqualTo("cmd /C foo.bat");
+ assertThat(command.toCommandLine()).isEqualTo("cmd /C call foo.bat");
assertThat(command.isNewShell()).isTrue();
} else {
Command command = Command.create("foo.sh");