diff options
| author | Simon Brandhof <simon.brandhof@gmail.com> | 2011-08-12 12:08:33 +0200 |
|---|---|---|
| committer | Simon Brandhof <simon.brandhof@gmail.com> | 2011-08-12 12:08:33 +0200 |
| commit | 2b79a7c204edc49f4635aff7471f384307a1f6d9 (patch) | |
| tree | 9c24adfb8d55a08e85986afd0986984aa9c4d822 | |
| parent | 1e3d7e4dc18b79d21aea4c0ffd4a40cb9a037dd4 (diff) | |
| download | sonarqube-2b79a7c204edc49f4635aff7471f384307a1f6d9.tar.gz sonarqube-2b79a7c204edc49f4635aff7471f384307a1f6d9.zip | |
Do not show crappy error page if url /plugins/* has bad parameters
3 files changed, 4 insertions, 1 deletions
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/controllers/plugins/configuration_controller.rb b/sonar-server/src/main/webapp/WEB-INF/app/controllers/plugins/configuration_controller.rb index f5ea76a519d..5160ea28c8f 100644 --- a/sonar-server/src/main/webapp/WEB-INF/app/controllers/plugins/configuration_controller.rb +++ b/sonar-server/src/main/webapp/WEB-INF/app/controllers/plugins/configuration_controller.rb @@ -25,6 +25,8 @@ class Plugins::ConfigurationController < ApplicationController page_id=params[:page] @page_proxy=java_facade.getPage(page_id) + return redirect_to(home_path) unless @page_proxy + authorized=@page_proxy.getUserRoles().size==0 unless authorized @page_proxy.getUserRoles().each do |role| diff --git a/sonar-server/src/main/webapp/WEB-INF/app/controllers/plugins/home_controller.rb b/sonar-server/src/main/webapp/WEB-INF/app/controllers/plugins/home_controller.rb index 59ce20ce328..8f53a48b208 100644 --- a/sonar-server/src/main/webapp/WEB-INF/app/controllers/plugins/home_controller.rb +++ b/sonar-server/src/main/webapp/WEB-INF/app/controllers/plugins/home_controller.rb @@ -25,6 +25,7 @@ class Plugins::HomeController < ApplicationController page_id=params[:page] @page_proxy=java_facade.getPage(page_id) + return redirect_to(home_path) unless @page_proxy authorized=@page_proxy.getUserRoles().size==0 unless authorized @page_proxy.getUserRoles().each do |role| diff --git a/sonar-server/src/main/webapp/WEB-INF/app/controllers/plugins/resource_controller.rb b/sonar-server/src/main/webapp/WEB-INF/app/controllers/plugins/resource_controller.rb index 5db6657cebd..b8967a29821 100644 --- a/sonar-server/src/main/webapp/WEB-INF/app/controllers/plugins/resource_controller.rb +++ b/sonar-server/src/main/webapp/WEB-INF/app/controllers/plugins/resource_controller.rb @@ -31,7 +31,7 @@ class Plugins::ResourceController < ApplicationController page_id=params[:page] @page_proxy=java_facade.getPage(page_id) - return redirect_to home_url if @page_proxy.nil? + return redirect_to(home_path) unless @page_proxy authorized=@page_proxy.getUserRoles().size==0 unless authorized |