SONAR-20021 Add clean_code_attribute column to rules table

11 files changed, 477 insertions, 3 deletions

diff --git a/server/sonar-db-dao/src/schema/schema-sq.ddl b/server/sonar-db-dao/src/schema/schema-sq.ddl
index cdc4eb7f5c1..7f0bef150d3 100644
--- a/server/sonar-db-dao/src/schema/schema-sq.ddl
+++ b/server/sonar-db-dao/src/schema/schema-sq.ddl
@@ -902,7 +902,8 @@ CREATE TABLE "RULES"(
     "AD_HOC_DESCRIPTION" CHARACTER LARGE OBJECT,
     "AD_HOC_SEVERITY" CHARACTER VARYING(10),
     "AD_HOC_TYPE" TINYINT,
-    "EDUCATION_PRINCIPLES" CHARACTER VARYING(255)
+    "EDUCATION_PRINCIPLES" CHARACTER VARYING(255),
+    "CLEAN_CODE_ATTRIBUTE" CHARACTER VARYING(40)
 );
 ALTER TABLE "RULES" ADD CONSTRAINT "PK_RULES" PRIMARY KEY("UUID");
 CREATE UNIQUE INDEX "RULES_REPO_KEY" ON "RULES"("PLUGIN_RULE_KEY" NULLS FIRST, "PLUGIN_NAME" NULLS FIRST);
diff --git a/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v102/AddCleanCodeAttributeInRules.java b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v102/AddCleanCodeAttributeInRules.java
new file mode 100644
index 00000000000..4fa13e109ec
--- /dev/null
+++ b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v102/AddCleanCodeAttributeInRules.java
@@ -0,0 +1,54 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2023 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.server.platform.db.migration.version.v102;
+
+import java.sql.Connection;
+import java.sql.SQLException;
+import org.sonar.db.Database;
+import org.sonar.db.DatabaseUtils;
+import org.sonar.server.platform.db.migration.def.ColumnDef;
+import org.sonar.server.platform.db.migration.def.VarcharColumnDef;
+import org.sonar.server.platform.db.migration.sql.AddColumnsBuilder;
+import org.sonar.server.platform.db.migration.step.DdlChange;
+
+public class AddCleanCodeAttributeInRules extends DdlChange {
+  private static final String TABLE_NAME = "rules";
+  private static final String COLUMN_NAME = "clean_code_attribute";
+  private static final int NEW_COLUMN_SIZE = 40;
+
+
+  public AddCleanCodeAttributeInRules(Database db) {
+    super(db);
+  }
+
+  @Override
+  public void execute(Context context) throws SQLException {
+    try (Connection connection = getDatabase().getDataSource().getConnection()) {
+      if (!DatabaseUtils.tableColumnExists(connection, TABLE_NAME, COLUMN_NAME)) {
+        ColumnDef columnDef = VarcharColumnDef.newVarcharColumnDefBuilder()
+          .setColumnName(COLUMN_NAME)
+          .setLimit(NEW_COLUMN_SIZE)
+          .setIsNullable(true)
+          .build();
+        context.execute(new AddColumnsBuilder(getDialect(), TABLE_NAME).addColumn(columnDef).build());
+      }
+    }
+  }
+}
diff --git a/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v102/DbVersion102.java b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v102/DbVersion102.java
index a9b3582ef42..2d516a92b83 100644
--- a/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v102/DbVersion102.java
+++ b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v102/DbVersion102.java
@@ -81,10 +81,13 @@ public class DbVersion102 implements DbVersion {
       .add(10_2_027, "Populate column 'created_at_temp' in 'components' table", PopulateCreatedAtTempInComponents.class)
       .add(10_2_028, "Drop column 'created_at' in 'components' table", DropCreatedAtInComponents.class)
       .add(10_2_029, "Rename column 'created_at_temp' to 'created_at' in 'components' table", RenameCreatedAtTempInComponents.class)
-
       .add(10_2_030, "Create table 'anticipated_transitions'", CreateAnticipatedTransitionsTable.class)
 
       .add(10_2_031, "Increase size of 'ce_queue.is_last_key' from 55 to 80 characters", IncreaseIsLastKeyInCeActivity.class)
-      .add(10_2_032, "Increase size of 'ce_queue.main_is_last_key' from 55 to 80 characters", IncreaseMainIsLastKeyInCeActivity.class);
+      .add(10_2_032, "Increase size of 'ce_queue.main_is_last_key' from 55 to 80 characters", IncreaseMainIsLastKeyInCeActivity.class)
+      .add(10_2_033, "Add column 'clean_code_attribute' in 'rules' table", AddCleanCodeAttributeInRules.class)
+      .add(10_2_034, "Populate 'clean_code_attribute' column in 'rules' table", PopulateCleanCodeAttributeColumnInRules.class)
+      //TODO SONAR-20073
+      //.add(10_2_035, "Make 'clean_code_attribute' column not nullable in 'rules' table", MakeCleanCodeAttributeColumnNotNullableInRules.class);
   }
 }
diff --git a/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v102/MakeCleanCodeAttributeColumnNotNullableInRules.java b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v102/MakeCleanCodeAttributeColumnNotNullableInRules.java
new file mode 100644
index 00000000000..df05a8453cc
--- /dev/null
+++ b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v102/MakeCleanCodeAttributeColumnNotNullableInRules.java
@@ -0,0 +1,47 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2023 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.server.platform.db.migration.version.v102;
+
+import java.sql.SQLException;
+import org.sonar.db.Database;
+import org.sonar.server.platform.db.migration.def.VarcharColumnDef;
+import org.sonar.server.platform.db.migration.sql.AlterColumnsBuilder;
+import org.sonar.server.platform.db.migration.step.DdlChange;
+
+public class MakeCleanCodeAttributeColumnNotNullableInRules extends DdlChange {
+
+  private static final String TABLE_NAME = "rules";
+  private static final String COLUMN_NAME = "clean_code_attribute";
+  private static final int COLUMN_SIZE = 40;
+
+  public MakeCleanCodeAttributeColumnNotNullableInRules(Database db) {
+    super(db);
+  }
+
+  @Override
+  public void execute(Context context) throws SQLException {
+    VarcharColumnDef columnDef = VarcharColumnDef.newVarcharColumnDefBuilder(COLUMN_NAME)
+      .setColumnName(COLUMN_NAME)
+      .setLimit(COLUMN_SIZE)
+      .setIsNullable(false)
+      .build();
+    context.execute(new AlterColumnsBuilder(getDialect(), TABLE_NAME).updateColumn(columnDef).build());
+  }
+}
diff --git a/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v102/PopulateCleanCodeAttributeColumnInRules.java b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v102/PopulateCleanCodeAttributeColumnInRules.java
new file mode 100644
index 00000000000..5faa03483f6
--- /dev/null
+++ b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v102/PopulateCleanCodeAttributeColumnInRules.java
@@ -0,0 +1,59 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2023 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.server.platform.db.migration.version.v102;
+
+import java.sql.SQLException;
+import org.sonar.api.rules.CleanCodeAttribute;
+import org.sonar.db.Database;
+import org.sonar.server.platform.db.migration.step.DataChange;
+import org.sonar.server.platform.db.migration.step.MassUpdate;
+
+public class PopulateCleanCodeAttributeColumnInRules extends DataChange {
+
+  private static final String SELECT_QUERY = """
+    SELECT uuid, clean_code_attribute
+    FROM rules
+    WHERE clean_code_attribute is null
+    """;
+
+  private static final String UPDATE_QUERY = """
+    UPDATE rules
+    SET clean_code_attribute=?
+    WHERE uuid=?
+    """;
+
+  public PopulateCleanCodeAttributeColumnInRules(Database db) {
+    super(db);
+  }
+
+  @Override
+  protected void execute(Context context) throws SQLException {
+    MassUpdate massUpdate = context.prepareMassUpdate();
+    massUpdate.select(SELECT_QUERY);
+    massUpdate.update(UPDATE_QUERY);
+
+    massUpdate.execute((row, update, index) -> {
+      String ruleUuid = row.getString(1);
+      update.setString(1, CleanCodeAttribute.CONVENTIONAL.name())
+        .setString(2, ruleUuid);
+      return true;
+    });
+  }
+}
diff --git a/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v102/AddCleanCodeAttributeInRulesTest.java b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v102/AddCleanCodeAttributeInRulesTest.java
new file mode 100644
index 00000000000..f77c5109c07
--- /dev/null
+++ b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v102/AddCleanCodeAttributeInRulesTest.java
@@ -0,0 +1,51 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2023 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.server.platform.db.migration.version.v102;
+
+import java.sql.SQLException;
+import java.sql.Types;
+import org.junit.Rule;
+import org.junit.Test;
+import org.sonar.db.CoreDbTester;
+
+public class AddCleanCodeAttributeInRulesTest {
+  private static final String TABLE_NAME = "rules";
+  private static final String COLUMN_NAME = "clean_code_attribute";
+
+  @Rule
+  public final CoreDbTester db = CoreDbTester.createForSchema(AddCleanCodeAttributeInRulesTest.class, "schema.sql");
+
+  private final AddCleanCodeAttributeInRules underTest = new AddCleanCodeAttributeInRules(db.database());
+
+  @Test
+  public void execute_whenColumnDoesNotExist_shouldCreateColumn() throws SQLException {
+    db.assertColumnDoesNotExist(TABLE_NAME, COLUMN_NAME);
+    underTest.execute();
+    db.assertColumnDefinition(TABLE_NAME, COLUMN_NAME, Types.VARCHAR, 40, true);
+  }
+
+  @Test
+  public void execute_whenExecutedTwice_shouldNotFail() throws SQLException {
+    db.assertColumnDoesNotExist(TABLE_NAME, COLUMN_NAME);
+    underTest.execute();
+    underTest.execute();
+    db.assertColumnDefinition(TABLE_NAME, COLUMN_NAME, Types.VARCHAR, 40, true);
+  }
+}
diff --git a/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v102/MakeCleanCodeAttributeColumnNotNullableInRulesTest.java b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v102/MakeCleanCodeAttributeColumnNotNullableInRulesTest.java
new file mode 100644
index 00000000000..d29dae44376
--- /dev/null
+++ b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v102/MakeCleanCodeAttributeColumnNotNullableInRulesTest.java
@@ -0,0 +1,52 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2023 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.server.platform.db.migration.version.v102;
+
+import java.sql.SQLException;
+import org.junit.Rule;
+import org.junit.Test;
+import org.sonar.db.CoreDbTester;
+
+import static java.sql.Types.VARCHAR;
+
+public class MakeCleanCodeAttributeColumnNotNullableInRulesTest {
+  private static final String TABLE_NAME = "rules";
+  private static final String COLUMN_NAME = "clean_code_attribute";
+
+  @Rule
+  public final CoreDbTester db = CoreDbTester.createForSchema(MakeCleanCodeAttributeColumnNotNullableInRulesTest.class, "schema.sql");
+
+  private final MakeCleanCodeAttributeColumnNotNullableInRules underTest = new MakeCleanCodeAttributeColumnNotNullableInRules(db.database());
+
+  @Test
+  public void execute_whenColumnIsNullable_shouldMakeColumnNullable() throws SQLException {
+    db.assertColumnDefinition(TABLE_NAME, COLUMN_NAME, VARCHAR, 40, true);
+    underTest.execute();
+    db.assertColumnDefinition(TABLE_NAME, COLUMN_NAME, VARCHAR, 40, false);
+  }
+
+  @Test
+  public void execute_whenExecutedTwice_shouldMakeColumnNullable() throws SQLException {
+    db.assertColumnDefinition(TABLE_NAME, COLUMN_NAME, VARCHAR, 40, true);
+    underTest.execute();
+    underTest.execute();
+    db.assertColumnDefinition(TABLE_NAME, COLUMN_NAME, VARCHAR, 40, false);
+  }
+}
diff --git a/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v102/PopulateCleanCodeAttributeColumnInRulesTest.java b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v102/PopulateCleanCodeAttributeColumnInRulesTest.java
new file mode 100644
index 00000000000..cb2dab2531a
--- /dev/null
+++ b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v102/PopulateCleanCodeAttributeColumnInRulesTest.java
@@ -0,0 +1,82 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2023 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.server.platform.db.migration.version.v102;
+
+import java.sql.SQLException;
+import javax.annotation.Nullable;
+import org.junit.Rule;
+import org.junit.Test;
+import org.sonar.api.rules.CleanCodeAttribute;
+import org.sonar.db.CoreDbTester;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatCode;
+
+public class PopulateCleanCodeAttributeColumnInRulesTest {
+
+  private static final String TABLE_NAME = "rules";
+
+  @Rule
+  public final CoreDbTester db = CoreDbTester.createForSchema(PopulateCleanCodeAttributeColumnInRulesTest.class, "schema.sql");
+
+  private final PopulateCleanCodeAttributeColumnInRules underTest = new PopulateCleanCodeAttributeColumnInRules(db.database());
+
+  @Test
+  public void execute_whenRulesDoNotExist_shouldNotFail() {
+    assertThatCode(underTest::execute).doesNotThrowAnyException();
+  }
+
+  @Test
+  public void execute_whenRuleWithUndefinedCleanCodeAttribute_shouldUpdate() throws SQLException {
+    insertRule("1", null);
+    underTest.execute();
+    assertThat(db.select("select UUID, CLEAN_CODE_ATTRIBUTE from rules"))
+      .extracting(stringObjectMap -> stringObjectMap.get("CLEAN_CODE_ATTRIBUTE")).containsExactly(CleanCodeAttribute.CONVENTIONAL.name());
+  }
+
+  @Test
+  public void execute_whenRuleWithUndefinedCleanCodeAttribute_shouldBeReentrant() throws SQLException {
+    insertRule("1", null);
+    underTest.execute();
+    underTest.execute();
+    assertThat(db.select("select UUID, CLEAN_CODE_ATTRIBUTE from rules"))
+      .extracting(stringObjectMap -> stringObjectMap.get("CLEAN_CODE_ATTRIBUTE")).containsExactly(CleanCodeAttribute.CONVENTIONAL.name());
+  }
+
+  @Test
+  public void execute_whenRuleWithDefinedCleanCodeAttribute_shouldNotUpdate() throws SQLException {
+    insertRule("1", CleanCodeAttribute.FOCUSED);
+    underTest.execute();
+    assertThat(db.select("select UUID, CLEAN_CODE_ATTRIBUTE from rules"))
+      .extracting(stringObjectMap -> stringObjectMap.get("CLEAN_CODE_ATTRIBUTE")).containsExactly(CleanCodeAttribute.FOCUSED.name());
+  }
+
+  private void insertRule(String uuid, @Nullable CleanCodeAttribute cleanCodeAttribute) {
+    db.executeInsert(TABLE_NAME,
+      "UUID", uuid,
+      "PLUGIN_RULE_KEY", "key",
+      "PLUGIN_NAME", "name",
+      "SCOPE", "1",
+      "CLEAN_CODE_ATTRIBUTE", cleanCodeAttribute != null ? cleanCodeAttribute.name() : null,
+      "IS_TEMPLATE", false,
+      "IS_AD_HOC", false,
+      "IS_EXTERNAL", false);
+  }
+}
diff --git a/server/sonar-db-migration/src/test/resources/org/sonar/server/platform/db/migration/version/v102/AddCleanCodeAttributeInRulesTest/schema.sql b/server/sonar-db-migration/src/test/resources/org/sonar/server/platform/db/migration/version/v102/AddCleanCodeAttributeInRulesTest/schema.sql
new file mode 100644
index 00000000000..06e99d24329
--- /dev/null
+++ b/server/sonar-db-migration/src/test/resources/org/sonar/server/platform/db/migration/version/v102/AddCleanCodeAttributeInRulesTest/schema.sql
@@ -0,0 +1,41 @@
+CREATE TABLE "RULES"(
+                        "UUID" CHARACTER VARYING(40) NOT NULL,
+                        "NAME" CHARACTER VARYING(200),
+                        "PLUGIN_RULE_KEY" CHARACTER VARYING(200) NOT NULL,
+                        "PLUGIN_KEY" CHARACTER VARYING(200),
+                        "PLUGIN_CONFIG_KEY" CHARACTER VARYING(200),
+                        "PLUGIN_NAME" CHARACTER VARYING(255) NOT NULL,
+                        "SCOPE" CHARACTER VARYING(20) NOT NULL,
+                        "PRIORITY" INTEGER,
+                        "STATUS" CHARACTER VARYING(40),
+                        "LANGUAGE" CHARACTER VARYING(20),
+                        "DEF_REMEDIATION_FUNCTION" CHARACTER VARYING(20),
+                        "DEF_REMEDIATION_GAP_MULT" CHARACTER VARYING(20),
+                        "DEF_REMEDIATION_BASE_EFFORT" CHARACTER VARYING(20),
+                        "GAP_DESCRIPTION" CHARACTER VARYING(4000),
+                        "SYSTEM_TAGS" CHARACTER VARYING(4000),
+                        "IS_TEMPLATE" BOOLEAN DEFAULT FALSE NOT NULL,
+                        "DESCRIPTION_FORMAT" CHARACTER VARYING(20),
+                        "RULE_TYPE" TINYINT,
+                        "SECURITY_STANDARDS" CHARACTER VARYING(4000),
+                        "IS_AD_HOC" BOOLEAN NOT NULL,
+                        "IS_EXTERNAL" BOOLEAN NOT NULL,
+                        "CREATED_AT" BIGINT,
+                        "UPDATED_AT" BIGINT,
+                        "TEMPLATE_UUID" CHARACTER VARYING(40),
+                        "NOTE_DATA" CHARACTER LARGE OBJECT,
+                        "NOTE_USER_UUID" CHARACTER VARYING(255),
+                        "NOTE_CREATED_AT" BIGINT,
+                        "NOTE_UPDATED_AT" BIGINT,
+                        "REMEDIATION_FUNCTION" CHARACTER VARYING(20),
+                        "REMEDIATION_GAP_MULT" CHARACTER VARYING(20),
+                        "REMEDIATION_BASE_EFFORT" CHARACTER VARYING(20),
+                        "TAGS" CHARACTER VARYING(4000),
+                        "AD_HOC_NAME" CHARACTER VARYING(200),
+                        "AD_HOC_DESCRIPTION" CHARACTER LARGE OBJECT,
+                        "AD_HOC_SEVERITY" CHARACTER VARYING(10),
+                        "AD_HOC_TYPE" TINYINT,
+                        "EDUCATION_PRINCIPLES" CHARACTER VARYING(255)
+);
+ALTER TABLE "RULES" ADD CONSTRAINT "PK_RULES" PRIMARY KEY("UUID");
+CREATE UNIQUE INDEX "RULES_REPO_KEY" ON "RULES"("PLUGIN_RULE_KEY" NULLS FIRST, "PLUGIN_NAME" NULLS FIRST);
diff --git a/server/sonar-db-migration/src/test/resources/org/sonar/server/platform/db/migration/version/v102/MakeCleanCodeAttributeColumnNotNullableInRulesTest/schema.sql b/server/sonar-db-migration/src/test/resources/org/sonar/server/platform/db/migration/version/v102/MakeCleanCodeAttributeColumnNotNullableInRulesTest/schema.sql
new file mode 100644
index 00000000000..6ba0dd13082
--- /dev/null
+++ b/server/sonar-db-migration/src/test/resources/org/sonar/server/platform/db/migration/version/v102/MakeCleanCodeAttributeColumnNotNullableInRulesTest/schema.sql
@@ -0,0 +1,42 @@
+CREATE TABLE "RULES"(
+                        "UUID" CHARACTER VARYING(40) NOT NULL,
+                        "NAME" CHARACTER VARYING(200),
+                        "PLUGIN_RULE_KEY" CHARACTER VARYING(200) NOT NULL,
+                        "PLUGIN_KEY" CHARACTER VARYING(200),
+                        "PLUGIN_CONFIG_KEY" CHARACTER VARYING(200),
+                        "PLUGIN_NAME" CHARACTER VARYING(255) NOT NULL,
+                        "SCOPE" CHARACTER VARYING(20) NOT NULL,
+                        "PRIORITY" INTEGER,
+                        "STATUS" CHARACTER VARYING(40),
+                        "LANGUAGE" CHARACTER VARYING(20),
+                        "DEF_REMEDIATION_FUNCTION" CHARACTER VARYING(20),
+                        "DEF_REMEDIATION_GAP_MULT" CHARACTER VARYING(20),
+                        "DEF_REMEDIATION_BASE_EFFORT" CHARACTER VARYING(20),
+                        "GAP_DESCRIPTION" CHARACTER VARYING(4000),
+                        "SYSTEM_TAGS" CHARACTER VARYING(4000),
+                        "IS_TEMPLATE" BOOLEAN DEFAULT FALSE NOT NULL,
+                        "DESCRIPTION_FORMAT" CHARACTER VARYING(20),
+                        "RULE_TYPE" TINYINT,
+                        "SECURITY_STANDARDS" CHARACTER VARYING(4000),
+                        "IS_AD_HOC" BOOLEAN NOT NULL,
+                        "IS_EXTERNAL" BOOLEAN NOT NULL,
+                        "CREATED_AT" BIGINT,
+                        "UPDATED_AT" BIGINT,
+                        "TEMPLATE_UUID" CHARACTER VARYING(40),
+                        "NOTE_DATA" CHARACTER LARGE OBJECT,
+                        "NOTE_USER_UUID" CHARACTER VARYING(255),
+                        "NOTE_CREATED_AT" BIGINT,
+                        "NOTE_UPDATED_AT" BIGINT,
+                        "REMEDIATION_FUNCTION" CHARACTER VARYING(20),
+                        "REMEDIATION_GAP_MULT" CHARACTER VARYING(20),
+                        "REMEDIATION_BASE_EFFORT" CHARACTER VARYING(20),
+                        "TAGS" CHARACTER VARYING(4000),
+                        "AD_HOC_NAME" CHARACTER VARYING(200),
+                        "AD_HOC_DESCRIPTION" CHARACTER LARGE OBJECT,
+                        "AD_HOC_SEVERITY" CHARACTER VARYING(10),
+                        "AD_HOC_TYPE" TINYINT,
+                        "EDUCATION_PRINCIPLES" CHARACTER VARYING(255),
+                        "CLEAN_CODE_ATTRIBUTE" CHARACTER VARYING(40)
+);
+ALTER TABLE "RULES" ADD CONSTRAINT "PK_RULES" PRIMARY KEY("UUID");
+CREATE UNIQUE INDEX "RULES_REPO_KEY" ON "RULES"("PLUGIN_RULE_KEY" NULLS FIRST, "PLUGIN_NAME" NULLS FIRST);
diff --git a/server/sonar-db-migration/src/test/resources/org/sonar/server/platform/db/migration/version/v102/PopulateCleanCodeAttributeColumnInRulesTest/schema.sql b/server/sonar-db-migration/src/test/resources/org/sonar/server/platform/db/migration/version/v102/PopulateCleanCodeAttributeColumnInRulesTest/schema.sql
new file mode 100644
index 00000000000..6ba0dd13082
--- /dev/null
+++ b/server/sonar-db-migration/src/test/resources/org/sonar/server/platform/db/migration/version/v102/PopulateCleanCodeAttributeColumnInRulesTest/schema.sql
@@ -0,0 +1,42 @@
+CREATE TABLE "RULES"(
+                        "UUID" CHARACTER VARYING(40) NOT NULL,
+                        "NAME" CHARACTER VARYING(200),
+                        "PLUGIN_RULE_KEY" CHARACTER VARYING(200) NOT NULL,
+                        "PLUGIN_KEY" CHARACTER VARYING(200),
+                        "PLUGIN_CONFIG_KEY" CHARACTER VARYING(200),
+                        "PLUGIN_NAME" CHARACTER VARYING(255) NOT NULL,
+                        "SCOPE" CHARACTER VARYING(20) NOT NULL,
+                        "PRIORITY" INTEGER,
+                        "STATUS" CHARACTER VARYING(40),
+                        "LANGUAGE" CHARACTER VARYING(20),
+                        "DEF_REMEDIATION_FUNCTION" CHARACTER VARYING(20),
+                        "DEF_REMEDIATION_GAP_MULT" CHARACTER VARYING(20),
+                        "DEF_REMEDIATION_BASE_EFFORT" CHARACTER VARYING(20),
+                        "GAP_DESCRIPTION" CHARACTER VARYING(4000),
+                        "SYSTEM_TAGS" CHARACTER VARYING(4000),
+                        "IS_TEMPLATE" BOOLEAN DEFAULT FALSE NOT NULL,
+                        "DESCRIPTION_FORMAT" CHARACTER VARYING(20),
+                        "RULE_TYPE" TINYINT,
+                        "SECURITY_STANDARDS" CHARACTER VARYING(4000),
+                        "IS_AD_HOC" BOOLEAN NOT NULL,
+                        "IS_EXTERNAL" BOOLEAN NOT NULL,
+                        "CREATED_AT" BIGINT,
+                        "UPDATED_AT" BIGINT,
+                        "TEMPLATE_UUID" CHARACTER VARYING(40),
+                        "NOTE_DATA" CHARACTER LARGE OBJECT,
+                        "NOTE_USER_UUID" CHARACTER VARYING(255),
+                        "NOTE_CREATED_AT" BIGINT,
+                        "NOTE_UPDATED_AT" BIGINT,
+                        "REMEDIATION_FUNCTION" CHARACTER VARYING(20),
+                        "REMEDIATION_GAP_MULT" CHARACTER VARYING(20),
+                        "REMEDIATION_BASE_EFFORT" CHARACTER VARYING(20),
+                        "TAGS" CHARACTER VARYING(4000),
+                        "AD_HOC_NAME" CHARACTER VARYING(200),
+                        "AD_HOC_DESCRIPTION" CHARACTER LARGE OBJECT,
+                        "AD_HOC_SEVERITY" CHARACTER VARYING(10),
+                        "AD_HOC_TYPE" TINYINT,
+                        "EDUCATION_PRINCIPLES" CHARACTER VARYING(255),
+                        "CLEAN_CODE_ATTRIBUTE" CHARACTER VARYING(40)
+);
+ALTER TABLE "RULES" ADD CONSTRAINT "PK_RULES" PRIMARY KEY("UUID");
+CREATE UNIQUE INDEX "RULES_REPO_KEY" ON "RULES"("PLUGIN_RULE_KEY" NULLS FIRST, "PLUGIN_NAME" NULLS FIRST);