diff options
| author | 7PH <benjamin.raymond@sonarsource.com> | 2024-08-15 11:36:36 +0200 |
|---|---|---|
| committer | sonartech <sonartech@sonarsource.com> | 2024-08-20 20:02:56 +0000 |
| commit | 5d06156e16cd6b0242072ca5e932854baa7c3c78 (patch) | |
| tree | 410f7c9946c0869262e8ab97300ccf5dd4c863a8 | |
| parent | 563a8712bf5ca5a67cf00f730944b2715454be65 (diff) | |
| download | sonarqube-5d06156e16cd6b0242072ca5e932854baa7c3c78.tar.gz sonarqube-5d06156e16cd6b0242072ca5e932854baa7c3c78.zip | |
SONAR-22287 Fix a11y issues on Issue Detail page
| -rw-r--r-- | server/sonar-web/src/main/js/apps/issues/__tests__/IssuesSourceViewer-it.tsx | 4 | ||||
| -rw-r--r-- | server/sonar-web/src/main/js/apps/issues/crossComponentSourceViewer/IssueSourceViewerHeader.tsx | 3 |
2 files changed, 3 insertions, 4 deletions
diff --git a/server/sonar-web/src/main/js/apps/issues/__tests__/IssuesSourceViewer-it.tsx b/server/sonar-web/src/main/js/apps/issues/__tests__/IssuesSourceViewer-it.tsx index 1cac63aa8ba..b24d7b21e0d 100644 --- a/server/sonar-web/src/main/js/apps/issues/__tests__/IssuesSourceViewer-it.tsx +++ b/server/sonar-web/src/main/js/apps/issues/__tests__/IssuesSourceViewer-it.tsx @@ -104,8 +104,8 @@ describe('issues source viewer', () => { renderProjectIssuesApp('project/issues?issues=issue101&open=issue101&id=myproject'); await waitOnDataLoaded(); - expect(screen.getByRole('separator', { name: 'test1.js' })).toBeInTheDocument(); - expect(screen.getByRole('separator', { name: 'test2.js' })).toBeInTheDocument(); + expect(screen.getByLabelText('test1.js')).toBeInTheDocument(); + expect(screen.getByLabelText('test2.js')).toBeInTheDocument(); // Both line 1 of test1.js and test2.js should be rendered after expanding lines above snippet in test2.js expect(ui.line1.getAll()).toHaveLength(1); diff --git a/server/sonar-web/src/main/js/apps/issues/crossComponentSourceViewer/IssueSourceViewerHeader.tsx b/server/sonar-web/src/main/js/apps/issues/crossComponentSourceViewer/IssueSourceViewerHeader.tsx index 0d7464ba00a..528712bb163 100644 --- a/server/sonar-web/src/main/js/apps/issues/crossComponentSourceViewer/IssueSourceViewerHeader.tsx +++ b/server/sonar-web/src/main/js/apps/issues/crossComponentSourceViewer/IssueSourceViewerHeader.tsx @@ -89,7 +89,7 @@ export function IssueSourceViewerHeader(props: Readonly<Props>) { const borderColor = themeColor('codeLineBorder')({ theme }); - const IssueSourceViewerStyle = styled.div` + const IssueSourceViewerStyle = styled.section` border: 1px solid ${borderColor}; border-bottom: none; `; @@ -113,7 +113,6 @@ export function IssueSourceViewerHeader(props: Readonly<Props>) { 'sw-flex sw-justify-space-between sw-items-center sw-px-4 sw-py-3 sw-text-sm', className, )} - role="separator" > <div className="sw-flex-1"> {displayProjectName && ( |