diff options
| author | Jeremy Davis <jeremy.davis@sonarsource.com> | 2023-11-01 14:27:22 +0100 |
|---|---|---|
| committer | sonartech <sonartech@sonarsource.com> | 2023-11-01 20:02:36 +0000 |
| commit | 808ea9e82202aee431ca8cd6463075fde61256f0 (patch) | |
| tree | 384e977df01abe33d4d82026c0d568490ad2e846 | |
| parent | 11adae6c170c8763ddf11e60dd1cebbe7f256c7f (diff) | |
| download | sonarqube-808ea9e82202aee431ca8cd6463075fde61256f0.tar.gz sonarqube-808ea9e82202aee431ca8cd6463075fde61256f0.zip | |
SONAR-20834 Improve Quality Gate details scrolling
| -rw-r--r-- | server/sonar-web/src/main/js/apps/quality-gates/components/App.tsx | 27 |
1 files changed, 12 insertions, 15 deletions
diff --git a/server/sonar-web/src/main/js/apps/quality-gates/components/App.tsx b/server/sonar-web/src/main/js/apps/quality-gates/components/App.tsx index b4eed74db87..526675bf4b5 100644 --- a/server/sonar-web/src/main/js/apps/quality-gates/components/App.tsx +++ b/server/sonar-web/src/main/js/apps/quality-gates/components/App.tsx @@ -59,8 +59,6 @@ interface State { qualityGates: QualityGate[]; } -const MAIN_CONTENT_TOP_PADDING = 48; - class App extends React.PureComponent<Props, State> { mounted = false; state: State = { canCreate: false, loading: true, qualityGates: [] }; @@ -139,7 +137,7 @@ class App extends React.PureComponent<Props, State> { <Suggestions suggestions="quality_gates" /> <StyledContentWrapper - className="sw-col-span-3 sw-px-4 sw-py-6 sw-border-t-0 sw-rounded-0" + className="sw-col-span-3 sw-px-4 sw-py-6 sw-border-y-0 sw-rounded-0" style={{ height: `calc(100vh - ${LAYOUT_GLOBAL_NAV_HEIGHT + LAYOUT_FOOTER_HEIGHT}px)`, }} @@ -151,20 +149,20 @@ class App extends React.PureComponent<Props, State> { </StyledContentWrapper> {name !== undefined && ( - <StyledContentWrapper - className="sw-col-span-9 sw-overflow-y-auto sw-mt-12" + <div + className="sw-col-span-9 sw-overflow-y-auto" style={{ - height: `calc(100vh - ${ - LAYOUT_GLOBAL_NAV_HEIGHT + LAYOUT_FOOTER_HEIGHT - }px - ${MAIN_CONTENT_TOP_PADDING}px)`, + height: `calc(100vh - ${LAYOUT_GLOBAL_NAV_HEIGHT + LAYOUT_FOOTER_HEIGHT}px)`, }} > - <Details - qualityGateName={name} - onSetDefault={this.handleSetDefault} - refreshQualityGates={this.fetchQualityGates} - /> - </StyledContentWrapper> + <StyledContentWrapper className="sw-my-12"> + <Details + qualityGateName={name} + onSetDefault={this.handleSetDefault} + refreshQualityGates={this.fetchQualityGates} + /> + </StyledContentWrapper> + </div> )} </div> </PageContentFontWrapper> @@ -185,6 +183,5 @@ const StyledContentWrapper = withTheme(styled.div` border-radius: 4px; background-color: ${themeColor('filterbar')}; border: ${themeBorder('default', 'filterbarBorder')}; - border-bottom: none; overflow-x: hidden; `); |