diff options
| author | Wouter Admiraal <wouter.admiraal@sonarsource.com> | 2022-07-29 17:22:58 +0200 |
|---|---|---|
| committer | sonartech <sonartech@sonarsource.com> | 2022-08-02 20:04:05 +0000 |
| commit | b43d59a860d38e0bd9399f43a3d028ed96fc85b9 (patch) | |
| tree | 1b100fdd5e053e6fea99693875fae1f62f27df86 | |
| parent | f50957ded4b4a67aa6028f45ff0a493359191cfa (diff) | |
| download | sonarqube-b43d59a860d38e0bd9399f43a3d028ed96fc85b9.tar.gz sonarqube-b43d59a860d38e0bd9399f43a3d028ed96fc85b9.zip | |
SONAR-16885 [892372] Group of navigation links missing semantics
3 files changed, 7 insertions, 4 deletions
diff --git a/server/sonar-web/src/main/js/apps/component-measures/sidebar/Sidebar.tsx b/server/sonar-web/src/main/js/apps/component-measures/sidebar/Sidebar.tsx index ce346568958..611320a1e92 100644 --- a/server/sonar-web/src/main/js/apps/component-measures/sidebar/Sidebar.tsx +++ b/server/sonar-web/src/main/js/apps/component-measures/sidebar/Sidebar.tsx @@ -58,7 +58,7 @@ export default class Sidebar extends React.PureComponent<Props, State> { render() { const { showFullMeasures } = this.props; return ( - <div> + <nav aria-label={translate('secondary')}> <A11ySkipTarget anchor="measures_filters" label={translate('component_measures.skip_to_filters')} @@ -80,7 +80,7 @@ export default class Sidebar extends React.PureComponent<Props, State> { showFullMeasures={showFullMeasures} /> ))} - </div> + </nav> ); } } diff --git a/server/sonar-web/src/main/js/apps/component-measures/sidebar/__tests__/__snapshots__/Sidebar-test.tsx.snap b/server/sonar-web/src/main/js/apps/component-measures/sidebar/__tests__/__snapshots__/Sidebar-test.tsx.snap index 75e622da8f5..fc32787d667 100644 --- a/server/sonar-web/src/main/js/apps/component-measures/sidebar/__tests__/__snapshots__/Sidebar-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/component-measures/sidebar/__tests__/__snapshots__/Sidebar-test.tsx.snap @@ -1,7 +1,9 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`should display two facets 1`] = ` -<div> +<nav + aria-label="secondary" +> <A11ySkipTarget anchor="measures_filters" label="component_measures.skip_to_filters" @@ -87,5 +89,5 @@ exports[`should display two facets 1`] = ` selected="duplicated_lines_density" showFullMeasures={true} /> -</div> +</nav> `; diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties index 3a31c043dac..000590eb25e 100644 --- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties +++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties @@ -190,6 +190,7 @@ start_date=Start Date x_show={0} shown x_selected={0} selected x_of_y_shown={0} of {1} shown +secondary=Secondary size=Size skip=Skip skip_to_content=Skip to main content |