aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulien Lancelot <julien.lancelot@sonarsource.com>2015-03-31 16:25:34 +0200
committerJulien Lancelot <julien.lancelot@sonarsource.com>2015-03-31 16:25:34 +0200
commitf0672915fe8b2b0e8e574606939dee7feab1530b (patch)
tree806292420a2b0708ec64ed3b0dfc87597c0d68e1
parent0d0d869e1c850925e74c2640c1d8517550935c6c (diff)
downloadsonarqube-f0672915fe8b2b0e8e574606939dee7feab1530b.tar.gz
sonarqube-f0672915fe8b2b0e8e574606939dee7feab1530b.zip
Fix quality flaw
-rw-r--r--server/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdater.java5
1 files changed, 3 insertions, 2 deletions
diff --git a/server/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdater.java b/server/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdater.java
index 69f7f2a5db5..98476084a21 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdater.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/rule/RuleUpdater.java
@@ -216,9 +216,10 @@ public class RuleUpdater implements ServerComponent {
}
private void updateDebtRemediationFunction(RuleUpdate update, Context context) {
+ Integer subChar = context.rule.getSubCharacteristicId();
boolean noChar =
- (context.rule.getDefaultSubCharacteristicId() == null && context.rule.getSubCharacteristicId() == null) ||
- (context.rule.getSubCharacteristicId() != null && context.rule.getSubCharacteristicId().intValue() == RuleDto.DISABLED_CHARACTERISTIC_ID);
+ (context.rule.getDefaultSubCharacteristicId() == null && subChar == null) ||
+ (subChar != null && subChar.intValue() == RuleDto.DISABLED_CHARACTERISTIC_ID);
DebtRemediationFunction function = update.getDebtRemediationFunction();
if (noChar || function == null) {