aboutsummaryrefslogtreecommitdiffstats
path: root/plugins
diff options
context:
space:
mode:
authorEvgeny Mandrikov <mandrikov@gmail.com>2011-05-30 22:07:23 +0400
committerEvgeny Mandrikov <mandrikov@gmail.com>2011-05-30 22:31:26 +0400
commit49d5f33b357d2a49cee0f2a511cd354a21ec6398 (patch)
tree0fef92608ed1de1f87987e945e7ef3ba8c802997 /plugins
parent6c4d1e705ab4cd7f20512762cecd542a3220f63b (diff)
downloadsonarqube-49d5f33b357d2a49cee0f2a511cd354a21ec6398.tar.gz
sonarqube-49d5f33b357d2a49cee0f2a511cd354a21ec6398.zip
Fix violations
Diffstat (limited to 'plugins')
-rw-r--r--plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/UnitTestDecorator.java2
-rw-r--r--plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgeOrphanResources.java2
-rw-r--r--plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgePropertyOrphans.java4
3 files changed, 4 insertions, 4 deletions
diff --git a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/UnitTestDecorator.java b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/UnitTestDecorator.java
index 0658a9733ab..e0758ca0e36 100644
--- a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/UnitTestDecorator.java
+++ b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/UnitTestDecorator.java
@@ -70,7 +70,7 @@ public class UnitTestDecorator implements Decorator {
private Double sumChildren(DecoratorContext jobContext, Metric metric) {
Collection<Measure> childrenMeasures = jobContext.getChildrenMeasures(metric);
- if (childrenMeasures != null && childrenMeasures.size() > 0) {
+ if (childrenMeasures != null && !childrenMeasures.isEmpty()) {
Double sum = 0.0;
boolean hasChildrenMeasures = false;
for (Measure measure : childrenMeasures) {
diff --git a/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgeOrphanResources.java b/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgeOrphanResources.java
index f3e6d62a8d1..9178b5ad85d 100644
--- a/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgeOrphanResources.java
+++ b/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgeOrphanResources.java
@@ -42,7 +42,7 @@ public final class PurgeOrphanResources extends Purge {
Query query = getSession().createQuery("SELECT r1.id FROM " + ResourceModel.class.getSimpleName() +
" r1 WHERE r1.rootId IS NOT NULL AND NOT EXISTS(FROM " + ResourceModel.class.getSimpleName() + " r2 WHERE r1.rootId=r2.id)");
List<Integer> idsToDelete = query.getResultList();
- if (idsToDelete.size() > 0) {
+ if (!idsToDelete.isEmpty()) {
PurgeUtils.executeQuery(getSession(), "", idsToDelete, "DELETE FROM " + ResourceModel.class.getSimpleName() + " WHERE id in (:ids)");
}
}
diff --git a/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgePropertyOrphans.java b/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgePropertyOrphans.java
index 74dda00b9a7..cdc9c708f05 100644
--- a/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgePropertyOrphans.java
+++ b/plugins/sonar-dbcleaner-plugin/src/main/java/org/sonar/plugins/dbcleaner/purges/PurgePropertyOrphans.java
@@ -49,7 +49,7 @@ public final class PurgePropertyOrphans extends Purge {
Query query = getSession().createQuery("SELECT p.id FROM " + Property.class.getSimpleName() +
" p WHERE p.resourceId IS NOT NULL AND NOT EXISTS(FROM " + ResourceModel.class.getSimpleName() + " r WHERE r.id=p.resourceId)");
List<Integer> idsToDelete = query.getResultList();
- if (idsToDelete.size() > 0) {
+ if (!idsToDelete.isEmpty()) {
PurgeUtils.executeQuery(getSession(), "", idsToDelete, "DELETE FROM " + Property.class.getSimpleName() + " WHERE id in (:ids)");
}
}
@@ -58,7 +58,7 @@ public final class PurgePropertyOrphans extends Purge {
Query query = getSession().createQuery("SELECT p.id FROM " + Property.class.getSimpleName() +
" p WHERE p.userId IS NOT NULL AND NOT EXISTS(FROM " + User.class.getSimpleName() + " u WHERE u.id=p.userId)");
List<Integer> idsToDelete = query.getResultList();
- if (idsToDelete.size() > 0) {
+ if (!idsToDelete.isEmpty()) {
PurgeUtils.executeQuery(getSession(), "", idsToDelete, "DELETE FROM " + Property.class.getSimpleName() + " WHERE id in (:ids)");
}
}