aboutsummaryrefslogtreecommitdiffstats
path: root/server/sonar-alm-client/src/main
diff options
context:
space:
mode:
authorDuarte Meneses <duarte.meneses@sonarsource.com>2021-06-30 13:47:02 -0400
committersonartech <sonartech@sonarsource.com>2021-07-01 20:03:19 +0000
commitb5566d14514a36eec77e4fc21133167653e53965 (patch)
tree189bc22122d2427fc6f35e38f313ea4a735b5391 /server/sonar-alm-client/src/main
parentc1f985398916637be241e6f052bf5977e5fb28e3 (diff)
downloadsonarqube-b5566d14514a36eec77e4fc21133167653e53965.tar.gz
sonarqube-b5566d14514a36eec77e4fc21133167653e53965.zip
SONAR-15118 Reading DevOps response header should be case-insensitive
Diffstat (limited to 'server/sonar-alm-client/src/main')
-rw-r--r--server/sonar-alm-client/src/main/java/org/sonar/alm/client/github/GithubApplicationHttpClientImpl.java2
-rw-r--r--server/sonar-alm-client/src/main/java/org/sonar/alm/client/gitlab/GitlabHttpClient.java8
2 files changed, 6 insertions, 4 deletions
diff --git a/server/sonar-alm-client/src/main/java/org/sonar/alm/client/github/GithubApplicationHttpClientImpl.java b/server/sonar-alm-client/src/main/java/org/sonar/alm/client/github/GithubApplicationHttpClientImpl.java
index 0f56ffc5c52..71b654655dd 100644
--- a/server/sonar-alm-client/src/main/java/org/sonar/alm/client/github/GithubApplicationHttpClientImpl.java
+++ b/server/sonar-alm-client/src/main/java/org/sonar/alm/client/github/GithubApplicationHttpClientImpl.java
@@ -203,7 +203,7 @@ public class GithubApplicationHttpClientImpl implements GithubApplicationHttpCli
@CheckForNull
private static String readNextEndPoint(okhttp3.Response response) {
- String links = response.header("link");
+ String links = response.headers().get("link");
if (links == null || links.isEmpty() || !links.contains("rel=\"next\"")) {
return null;
}
diff --git a/server/sonar-alm-client/src/main/java/org/sonar/alm/client/gitlab/GitlabHttpClient.java b/server/sonar-alm-client/src/main/java/org/sonar/alm/client/gitlab/GitlabHttpClient.java
index ffe6e647de6..4932e2db87e 100644
--- a/server/sonar-alm-client/src/main/java/org/sonar/alm/client/gitlab/GitlabHttpClient.java
+++ b/server/sonar-alm-client/src/main/java/org/sonar/alm/client/gitlab/GitlabHttpClient.java
@@ -29,6 +29,7 @@ import java.util.Arrays;
import java.util.List;
import java.util.Optional;
import javax.annotation.Nullable;
+import okhttp3.Headers;
import okhttp3.OkHttpClient;
import okhttp3.Request;
import okhttp3.RequestBody;
@@ -302,11 +303,12 @@ public class GitlabHttpClient {
.build();
try (Response response = client.newCall(request).execute()) {
+ Headers headers = response.headers();
checkResponseIsSuccessful(response, "Could not get projects from GitLab instance");
List<Project> projectList = Project.parseJsonArray(response.body().string());
- int returnedPageNumber = parseAndGetIntegerHeader(response.header("X-Page"));
- int returnedPageSize = parseAndGetIntegerHeader(response.header("X-Per-Page"));
- int totalProjects = parseAndGetIntegerHeader(response.header("X-Total"));
+ int returnedPageNumber = parseAndGetIntegerHeader(headers.get("X-Page"));
+ int returnedPageSize = parseAndGetIntegerHeader(headers.get("X-Per-Page"));
+ int totalProjects = parseAndGetIntegerHeader(headers.get("X-Total"));
return new ProjectList(projectList, returnedPageNumber, returnedPageSize, totalProjects);
} catch (JsonSyntaxException e) {
throw new IllegalArgumentException("Could not parse GitLab answer to search projects. Got a non-json payload as result.");