diff options
author | Léo Geoffroy <leo.geoffroy@sonarsource.com> | 2023-04-03 09:35:11 +0200 |
---|---|---|
committer | sonartech <sonartech@sonarsource.com> | 2023-04-04 20:03:16 +0000 |
commit | 3195a1ad95466c1e722f42348a1e12ba908b36f7 (patch) | |
tree | 67e964bc07e2cba95414081a0f8749d675b35f2d /server/sonar-ce-common | |
parent | 3f602a70548d285d61d0295b704aa18a3b8314b8 (diff) | |
download | sonarqube-3195a1ad95466c1e722f42348a1e12ba908b36f7.tar.gz sonarqube-3195a1ad95466c1e722f42348a1e12ba908b36f7.zip |
SONAR-18850 remove usage main branch project UUID in ce task
Diffstat (limited to 'server/sonar-ce-common')
-rw-r--r-- | server/sonar-ce-common/src/it/java/org/sonar/ce/queue/CeQueueImplIT.java | 8 | ||||
-rw-r--r-- | server/sonar-ce-common/src/main/java/org/sonar/ce/queue/CeTaskSubmit.java | 5 |
2 files changed, 6 insertions, 7 deletions
diff --git a/server/sonar-ce-common/src/it/java/org/sonar/ce/queue/CeQueueImplIT.java b/server/sonar-ce-common/src/it/java/org/sonar/ce/queue/CeQueueImplIT.java index e2bf5ee90b5..296cf548629 100644 --- a/server/sonar-ce-common/src/it/java/org/sonar/ce/queue/CeQueueImplIT.java +++ b/server/sonar-ce-common/src/it/java/org/sonar/ce/queue/CeQueueImplIT.java @@ -92,7 +92,7 @@ public class CeQueueImplIT { @Test public void submit_populates_component_name_and_key_of_CeTask_if_component_exists() { ComponentDto componentDto = insertComponent(ComponentTesting.newPrivateProjectDto("PROJECT_1")); - CeTaskSubmit taskSubmit = createTaskSubmit(CeTaskTypes.REPORT, Component.fromDto(componentDto), null); + CeTaskSubmit taskSubmit = createTaskSubmit(CeTaskTypes.REPORT, Component.fromDto(componentDto.uuid(), componentDto.uuid()), null); CeTask task = underTest.submit(taskSubmit); @@ -227,7 +227,7 @@ public class CeQueueImplIT { @Test public void massSubmit_populates_component_name_and_key_of_CeTask_if_project_exists() { ComponentDto componentDto1 = insertComponent(ComponentTesting.newPrivateProjectDto("PROJECT_1")); - CeTaskSubmit taskSubmit1 = createTaskSubmit(CeTaskTypes.REPORT, Component.fromDto(componentDto1), null); + CeTaskSubmit taskSubmit1 = createTaskSubmit(CeTaskTypes.REPORT, Component.fromDto(componentDto1.uuid(), componentDto1.uuid()), null); CeTaskSubmit taskSubmit2 = createTaskSubmit("something", newComponent(randomAlphabetic(12)), null); List<CeTask> tasks = underTest.massSubmit(asList(taskSubmit1, taskSubmit2)); @@ -242,8 +242,8 @@ public class CeQueueImplIT { ComponentDto project = insertComponent(ComponentTesting.newPrivateProjectDto("PROJECT_1")); ComponentDto branch1 = db.components().insertProjectBranch(project); ComponentDto branch2 = db.components().insertProjectBranch(project); - CeTaskSubmit taskSubmit1 = createTaskSubmit(CeTaskTypes.REPORT, Component.fromDto(branch1), null); - CeTaskSubmit taskSubmit2 = createTaskSubmit("something", Component.fromDto(branch2), null); + CeTaskSubmit taskSubmit1 = createTaskSubmit(CeTaskTypes.REPORT, Component.fromDto(branch1.uuid(), project.uuid()), null); + CeTaskSubmit taskSubmit2 = createTaskSubmit("something", Component.fromDto(branch2.uuid(), project.uuid()), null); List<CeTask> tasks = underTest.massSubmit(asList(taskSubmit1, taskSubmit2)); diff --git a/server/sonar-ce-common/src/main/java/org/sonar/ce/queue/CeTaskSubmit.java b/server/sonar-ce-common/src/main/java/org/sonar/ce/queue/CeTaskSubmit.java index b950b130573..dcfc17b5545 100644 --- a/server/sonar-ce-common/src/main/java/org/sonar/ce/queue/CeTaskSubmit.java +++ b/server/sonar-ce-common/src/main/java/org/sonar/ce/queue/CeTaskSubmit.java @@ -126,9 +126,8 @@ public final class CeTaskSubmit { this.mainComponentUuid = requireNonNull(nullToEmpty(mainComponentUuid), "mainComponentUuid can't be null"); } - public static Component fromDto(ComponentDto dto) { - String uuid = dto.uuid(); - return new Component(uuid, firstNonNull(dto.getMainBranchProjectUuid(), uuid)); + public static Component fromDto(String componentUuid, String mainComponentUuid) { + return new Component(componentUuid, mainComponentUuid); } public static Component fromDto(ProjectDto dto) { |