SONARCLOUD-161 add Dialect#supportsUpsert(), true only on postgreSQL

3 files changed, 30 insertions, 1 deletions

diff --git a/server/sonar-db-core/src/main/java/org/sonar/db/dialect/AbstractDialect.java b/server/sonar-db-core/src/main/java/org/sonar/db/dialect/AbstractDialect.java
index f4f738aa5de..0959ff1c390 100644
--- a/server/sonar-db-core/src/main/java/org/sonar/db/dialect/AbstractDialect.java
+++ b/server/sonar-db-core/src/main/java/org/sonar/db/dialect/AbstractDialect.java
@@ -87,6 +87,11 @@ abstract class AbstractDialect implements Dialect {
     return 1;
   }
 
+  @Override
+  public boolean supportsUpsert() {
+    return false;
+  }
+
   Version checkDbVersion(DatabaseMetaData metaData, Version minSupported) throws SQLException {
     int major = metaData.getDatabaseMajorVersion();
     int minor = metaData.getDatabaseMinorVersion();
diff --git a/server/sonar-db-core/src/main/java/org/sonar/db/dialect/Dialect.java b/server/sonar-db-core/src/main/java/org/sonar/db/dialect/Dialect.java
index 42278d51111..44ad59239cd 100644
--- a/server/sonar-db-core/src/main/java/org/sonar/db/dialect/Dialect.java
+++ b/server/sonar-db-core/src/main/java/org/sonar/db/dialect/Dialect.java
@@ -64,6 +64,8 @@ public interface Dialect {
    */
   boolean supportsMigration();
 
+  boolean supportsUpsert();
+
   /**
    * This method is called when connecting for the first
    * time to the database.
diff --git a/server/sonar-db-core/src/main/java/org/sonar/db/dialect/PostgreSql.java b/server/sonar-db-core/src/main/java/org/sonar/db/dialect/PostgreSql.java
index f80169aef21..5613e13fc83 100644
--- a/server/sonar-db-core/src/main/java/org/sonar/db/dialect/PostgreSql.java
+++ b/server/sonar-db-core/src/main/java/org/sonar/db/dialect/PostgreSql.java
@@ -25,12 +25,19 @@ import java.sql.SQLException;
 import java.util.List;
 import org.apache.commons.lang.StringUtils;
 import org.sonar.api.utils.Version;
+import org.sonar.api.utils.log.Loggers;
+
+import static com.google.common.base.Preconditions.checkState;
 
 public class PostgreSql extends AbstractDialect {
 
   public static final String ID = "postgresql";
   static final List<String> INIT_STATEMENTS = ImmutableList.of("SET standard_conforming_strings=on", "SET backslash_quote=off");
   private static final Version MIN_SUPPORTED_VERSION = Version.create(9, 3, 0);
+  private static final Version MIN_UPSERT_VERSION = Version.create(9, 5, 0);
+
+  private boolean initialized = false;
+  private boolean supportsUpsert = false;
 
   public PostgreSql() {
     super(ID, "org.postgresql.Driver", "true", "false", "SELECT 1");
@@ -52,7 +59,22 @@ public class PostgreSql extends AbstractDialect {
   }
 
   @Override
+  public boolean supportsUpsert() {
+    checkState(initialized, "onInit() must be called before calling supportsUpsert()");
+    return supportsUpsert;
+  }
+
+  @Override
   public void init(DatabaseMetaData metaData) throws SQLException {
-    checkDbVersion(metaData, MIN_SUPPORTED_VERSION);
+    checkState(!initialized, "onInit() must be called once");
+
+    Version version = checkDbVersion(metaData, MIN_SUPPORTED_VERSION);
+
+    supportsUpsert = version.compareTo(MIN_UPSERT_VERSION) >= 0;
+    if (!supportsUpsert) {
+      Loggers.get(getClass()).warn("Upgrading PostgreSQL to {} or greater is recommended for better performances", MIN_UPSERT_VERSION);
+    }
+
+    initialized = true;
   }
 }