SONARCLOUD-161 add Dialect#supportsUpsert(), true only on postgreSQL

5 files changed, 57 insertions, 2 deletions

diff --git a/server/sonar-db-core/src/test/java/org/sonar/db/dialect/H2Test.java b/server/sonar-db-core/src/test/java/org/sonar/db/dialect/H2Test.java
index b208e97e984..246739ae3d6 100644
--- a/server/sonar-db-core/src/test/java/org/sonar/db/dialect/H2Test.java
+++ b/server/sonar-db-core/src/test/java/org/sonar/db/dialect/H2Test.java
@@ -75,4 +75,9 @@ public class H2Test {
 
     assertThat(logs.logs(LoggerLevel.WARN)).contains("H2 database should be used for evaluation purpose only.");
   }
+
+  @Test
+  public void supportsUpsert_returns_false() {
+    assertThat(underTest.supportsUpsert()).isFalse();
+  }
 }
diff --git a/server/sonar-db-core/src/test/java/org/sonar/db/dialect/MsSqlTest.java b/server/sonar-db-core/src/test/java/org/sonar/db/dialect/MsSqlTest.java
index ba4a9a5836f..973520d7f4b 100644
--- a/server/sonar-db-core/src/test/java/org/sonar/db/dialect/MsSqlTest.java
+++ b/server/sonar-db-core/src/test/java/org/sonar/db/dialect/MsSqlTest.java
@@ -90,6 +90,11 @@ public class MsSqlTest {
     underTest.init(metadata);
   }
 
+  @Test
+  public void supportsUpsert_returns_false() {
+    assertThat(underTest.supportsUpsert()).isFalse();
+  }
+
   private DatabaseMetaData newMetadata(int dbMajorVersion, int dbMinorVersion) throws SQLException {
     DatabaseMetaData metadata = mock(DatabaseMetaData.class, Mockito.RETURNS_DEEP_STUBS);
     when(metadata.getDatabaseMajorVersion()).thenReturn(dbMajorVersion);
diff --git a/server/sonar-db-core/src/test/java/org/sonar/db/dialect/MySqlTest.java b/server/sonar-db-core/src/test/java/org/sonar/db/dialect/MySqlTest.java
index de15828f258..e6d80631dbe 100644
--- a/server/sonar-db-core/src/test/java/org/sonar/db/dialect/MySqlTest.java
+++ b/server/sonar-db-core/src/test/java/org/sonar/db/dialect/MySqlTest.java
@@ -102,6 +102,11 @@ public class MySqlTest {
     assertThat(logs.logs(LoggerLevel.WARN)).contains("MySQL support is deprecated and will be dropped soon.");
   }
 
+  @Test
+  public void supportsUpsert_returns_false() {
+    assertThat(underTest.supportsUpsert()).isFalse();
+  }
+
   private DatabaseMetaData newMetadata(int dbMajorVersion, int dbMinorVersion) throws SQLException {
     DatabaseMetaData metadata = mock(DatabaseMetaData.class, Mockito.RETURNS_DEEP_STUBS);
     when(metadata.getDatabaseMajorVersion()).thenReturn(dbMajorVersion);
diff --git a/server/sonar-db-core/src/test/java/org/sonar/db/dialect/OracleTest.java b/server/sonar-db-core/src/test/java/org/sonar/db/dialect/OracleTest.java
index e0725a0d0a0..2eb3564b20f 100644
--- a/server/sonar-db-core/src/test/java/org/sonar/db/dialect/OracleTest.java
+++ b/server/sonar-db-core/src/test/java/org/sonar/db/dialect/OracleTest.java
@@ -131,6 +131,11 @@ public class OracleTest {
     }
   }
 
+  @Test
+  public void supportsUpsert_returns_false() {
+    assertThat(underTest.supportsUpsert()).isFalse();
+  }
+
   private DatabaseMetaData newMetadata(int dbMajorVersion, int dbMinorVersion, String driverVersion) throws SQLException {
     DatabaseMetaData metadata = mock(DatabaseMetaData.class, Mockito.RETURNS_DEEP_STUBS);
     when(metadata.getDatabaseMajorVersion()).thenReturn(dbMajorVersion);
diff --git a/server/sonar-db-core/src/test/java/org/sonar/db/dialect/PostgreSqlTest.java b/server/sonar-db-core/src/test/java/org/sonar/db/dialect/PostgreSqlTest.java
index 3e1b7b065a4..d911c5dce8e 100644
--- a/server/sonar-db-core/src/test/java/org/sonar/db/dialect/PostgreSqlTest.java
+++ b/server/sonar-db-core/src/test/java/org/sonar/db/dialect/PostgreSqlTest.java
@@ -26,6 +26,8 @@ import org.junit.Test;
 import org.junit.rules.ExpectedException;
 import org.mockito.Mockito;
 import org.sonar.api.utils.MessageException;
+import org.sonar.api.utils.log.LogTester;
+import org.sonar.api.utils.log.LoggerLevel;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.mock;
@@ -35,6 +37,8 @@ public class PostgreSqlTest {
 
   @Rule
   public ExpectedException expectedException = ExpectedException.none();
+  @Rule
+  public LogTester logs = new LogTester();
 
   private PostgreSql underTest = new PostgreSql();
 
@@ -78,7 +82,7 @@ public class PostgreSqlTest {
   }
 
   @Test
-  public void init_throws_MessageException_if_postgresql_9_2() throws Exception {
+  public void postgresql_9_2_is_not_supported() throws Exception {
     expectedException.expect(MessageException.class);
     expectedException.expectMessage("Unsupported postgresql version: 9.2. Minimal supported version is 9.3.");
 
@@ -87,9 +91,40 @@ public class PostgreSqlTest {
   }
 
   @Test
-  public void init_does_not_fail_if_postgresql_9_3() throws Exception {
+  public void postgresql_9_3_is_supported_without_upsert() throws Exception {
     DatabaseMetaData metadata = newMetadata( 9, 3);
     underTest.init(metadata);
+
+    assertThat(underTest.supportsUpsert()).isFalse();
+    assertThat(logs.logs(LoggerLevel.WARN)).contains("Upgrading PostgreSQL to 9.5 or greater is recommended for better performances");
+  }
+
+  @Test
+  public void postgresql_9_5_is_supported_with_upsert() throws Exception {
+    DatabaseMetaData metadata = newMetadata( 9, 5);
+    underTest.init(metadata);
+
+    assertThat(underTest.supportsUpsert()).isTrue();
+    assertThat(logs.logs(LoggerLevel.WARN)).isEmpty();
+  }
+
+  @Test
+  public void init_throws_ISE_if_called_twice() throws Exception {
+    DatabaseMetaData metaData = newMetadata(9, 5);
+    underTest.init(metaData);
+
+    expectedException.expect(IllegalStateException.class);
+    expectedException.expectMessage("onInit() must be called once");
+
+    underTest.init(metaData);
+  }
+
+  @Test
+  public void supportsUpsert_throws_ISE_if_not_initialized() {
+    expectedException.expect(IllegalStateException.class);
+    expectedException.expectMessage("onInit() must be called before calling supportsUpsert()");
+
+    underTest.supportsUpsert();
   }
 
   private DatabaseMetaData newMetadata(int dbMajorVersion, int dbMinorVersion) throws SQLException {