aboutsummaryrefslogtreecommitdiffstats
path: root/server/sonar-db-migration/src/test/java
diff options
context:
space:
mode:
authorSimon Brandhof <simon.brandhof@sonarsource.com>2017-05-05 10:11:51 +0200
committerSimon Brandhof <simon.brandhof@sonarsource.com>2017-05-05 10:11:51 +0200
commit788e9efeaf3284175b2d3e5079b9256d64239ac8 (patch)
tree3892f4a5b3be16002387d03f554ff232e70fbe79 /server/sonar-db-migration/src/test/java
parent64ef4f0554f6ca67474305bca1a125fd8cdbe6bb (diff)
downloadsonarqube-788e9efeaf3284175b2d3e5079b9256d64239ac8.tar.gz
sonarqube-788e9efeaf3284175b2d3e5079b9256d64239ac8.zip
Improve reliability of SupportPrivateProjectInDefaultPermissionTemplateTest
There were some false-positives due to generated random values that are not unique.
Diffstat (limited to 'server/sonar-db-migration/src/test/java')
-rw-r--r--server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v64/SupportPrivateProjectInDefaultPermissionTemplateTest.java10
1 files changed, 5 insertions, 5 deletions
diff --git a/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v64/SupportPrivateProjectInDefaultPermissionTemplateTest.java b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v64/SupportPrivateProjectInDefaultPermissionTemplateTest.java
index ed06f61eb91..24fd17e1120 100644
--- a/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v64/SupportPrivateProjectInDefaultPermissionTemplateTest.java
+++ b/server/sonar-db-migration/src/test/java/org/sonar/server/platform/db/migration/version/v64/SupportPrivateProjectInDefaultPermissionTemplateTest.java
@@ -20,9 +20,9 @@
package org.sonar.server.platform.db.migration.version.v64;
import java.sql.SQLException;
-import java.util.Random;
import java.util.stream.Stream;
import javax.annotation.Nullable;
+import org.apache.commons.lang.RandomStringUtils;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
@@ -241,7 +241,7 @@ public class SupportPrivateProjectInDefaultPermissionTemplateTest {
}
private int insertGroup(String organizationUuid) {
- String name = "name" + new Random().nextInt(122);
+ String name = "name" + RandomStringUtils.random(20);
db.executeInsert(
"GROUPS",
"ORGANIZATION_UUID", organizationUuid,
@@ -251,12 +251,12 @@ public class SupportPrivateProjectInDefaultPermissionTemplateTest {
}
private IdAndUuid insertPermissionTemplate(String organizationUuid) {
- int i = new Random().nextInt(1222);
- String uuid = "ptUuid" + i;
+ String random = RandomStringUtils.random(20);
+ String uuid = "ptUuid" + random;
db.executeInsert(
"PERMISSION_TEMPLATES",
"ORGANIZATION_UUID", organizationUuid,
- "NAME", "name" + i,
+ "NAME", "name" + random,
"KEE", uuid);
return new IdAndUuid(
((Long) db.selectFirst("select id as \"ID\" from permission_templates where kee='" + uuid + "'").get("ID")).intValue(),