diff options
| author | Wouter Admiraal <wouter.admiraal@sonarsource.com> | 2022-08-24 17:40:37 +0200 |
|---|---|---|
| committer | sonartech <sonartech@sonarsource.com> | 2022-08-29 20:02:53 +0000 |
| commit | c757692a0a8d02998bfd8839c2612e17011013a7 (patch) | |
| tree | fe7bfbb93c5e2de91034487f92bdfecce8c9ae2f /server/sonar-web/src/main/js/app/components/nav/settings | |
| parent | 479f33aad4fdd0e294be2444fd95c8931768b036 (diff) | |
| download | sonarqube-c757692a0a8d02998bfd8839c2612e17011013a7.tar.gz sonarqube-c757692a0a8d02998bfd8839c2612e17011013a7.zip | |
SONAR-16725 [891882] An icon lacks 3 to 1 contrast ratio
Diffstat (limited to 'server/sonar-web/src/main/js/app/components/nav/settings')
2 files changed, 9 insertions, 7 deletions
diff --git a/server/sonar-web/src/main/js/app/components/nav/settings/SettingsNav.tsx b/server/sonar-web/src/main/js/app/components/nav/settings/SettingsNav.tsx index 3a1381823d3..e84059e8629 100644 --- a/server/sonar-web/src/main/js/app/components/nav/settings/SettingsNav.tsx +++ b/server/sonar-web/src/main/js/app/components/nav/settings/SettingsNav.tsx @@ -43,6 +43,8 @@ interface Props { systemStatus: SysStatus; } +const ALERT_HEIGHT = 30; + export class SettingsNav extends React.PureComponent<Props> { static defaultProps = { extensions: [] @@ -249,12 +251,12 @@ export class SettingsNav extends React.PureComponent<Props> { return ( <ContextNavBar - height={notifComponent ? contextNavHeight + 30 : contextNavHeight} + height={notifComponent ? contextNavHeight + ALERT_HEIGHT : contextNavHeight} id="context-navigation" notif={notifComponent}> - <header className="navbar-context-header"> + <div className="navbar-context-header"> <h1>{translate('layout.settings')}</h1> - </header> + </div> <NavBarTabs> {this.renderConfigurationTab()} diff --git a/server/sonar-web/src/main/js/app/components/nav/settings/__tests__/__snapshots__/SettingsNav-test.tsx.snap b/server/sonar-web/src/main/js/app/components/nav/settings/__tests__/__snapshots__/SettingsNav-test.tsx.snap index 029675a85cb..383948b261d 100644 --- a/server/sonar-web/src/main/js/app/components/nav/settings/__tests__/__snapshots__/SettingsNav-test.tsx.snap +++ b/server/sonar-web/src/main/js/app/components/nav/settings/__tests__/__snapshots__/SettingsNav-test.tsx.snap @@ -29,13 +29,13 @@ exports[`should render correctly when governance is active 1`] = ` height={72} id="context-navigation" > - <header + <div className="navbar-context-header" > <h1> layout.settings </h1> - </header> + </div> <NavBarTabs> <Dropdown overlay={ @@ -182,13 +182,13 @@ exports[`should work with extensions 1`] = ` height={72} id="context-navigation" > - <header + <div className="navbar-context-header" > <h1> layout.settings </h1> - </header> + </div> <NavBarTabs> <Dropdown overlay={ |